[Lldb-commits] [lldb] acdd41b - [lldb/test] Fix typo in eventlistener.py (NFC)

Author: Med Ismail Bennani Date: 2022-03-18T21:59:11-07:00 New Revision: acdd41b4590935e39208a941fbac7889d778e8e5 URL: https://github.com/llvm/llvm-project/commit/acdd41b4590935e39208a941fbac7889d778e8e5 DIFF: https://github.com/llvm/llvm-project/commit/acdd41b4590935e39208a941fbac7889d778e8e5.

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09ff41a08776: [lldb/test] Add events listener helper class to lldbtest (authored by mib). Changed prior to commit: https://reviews.llvm.org/D12197

[Lldb-commits] [lldb] 09ff41a - [lldb/test] Add events listener helper class to lldbtest

Author: Med Ismail Bennani Date: 2022-03-18T16:35:33-07:00 New Revision: 09ff41a087760ea7e80b8e5390a05101c5a5b929 URL: https://github.com/llvm/llvm-project/commit/09ff41a087760ea7e80b8e5390a05101c5a5b929 DIFF: https://github.com/llvm/llvm-project/commit/09ff41a087760ea7e80b8e5390a05101c5a5b929.

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

mib updated this revision to Diff 416630. mib added a comment. Make `event_mask` and `event_data_extractor` class attributes to remove `EventListenerTestBase.setUp` overloading in the derived class tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:971 + "need module to resolve file address for %s", dw_op_type); +return {}; + } clayborg wrote: > Do we prefer "return {}" over "return llvm::None"? Personally, I

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. I think adding a live debugging test case is necessary. I found several bugs when working on this via live debugging the compiled `inline_sites.s` and printing variables, and those bugs were not revealed by `image lookup`. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 416621. zequanwu added a comment. Fixing bugs and refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstB

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice, thanks for bearing with me. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.org/D121977 ___

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

mib added a comment. @jingham It's a bit restrictive, but as I stated before, this class will expect to receive events from the debugger broadcaster. If you can think of other broadcasters that could be tested with this class, please let me know so we can think of another solution. CHANGES SI

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

mib updated this revision to Diff 416612. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.org/D121977 Files: lldb/packages/Python/lldbsuite/test/eventlistener.py

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/eventlistener.py:23 +def setUp(self, src_broadcaster, event_mask, event_data_extractor): +self.src_broadcaster = src_broadcaster +self.broadcaster

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. kastiglione added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-com

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

jingham added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1624 +# == +# Utility class to setup a progress event listener +# == JDevlie

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/eventlistener.py:19 +eBroadcastBitStopListenerThread = (1 << 0) +fetched_events = [] + Just `events` maybe? Comment at: lldb/packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D121977: [lldb/test] Add events listener helper class to lldbtest

mib updated this revision to Diff 416586. mib added a comment. Update `EventListener.tearDown` comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.org/D121977 Files: lldb/packages/Python/lldbsuite/test/eventlistener.py lldb/test/API/functionalitie

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

mib updated this revision to Diff 416581. mib added a comment. Address @JDevlieghere comments: - Move the `EventListener` class to a separate module and make it inherit from `TestBase` to start/stop the background listener thread in `setUp`/`tearDown`. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D122025: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

JDevlieghere created this revision. JDevlieghere added reviewers: labath, lemo, jingham, mib. Herald added a project: All. JDevlieghere requested review of this revision. The assertion checks that the command output doesn't contain any null bytes. I'm not sure if the intention was to make sure the

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1624 +# == +# Utility class to setup a progress event listener +# == mi

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1624 +# == +# Utility class to setup a progress event listener +# =

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1624 +# == +# Utility class to setup a progress event listener +# == We

[Lldb-commits] [PATCH] D122023: [trace][intelpt] fix some test failures

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d525ad38a9: [trace][intelpt] fix some test failures (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122023/n

[Lldb-commits] [lldb] b7d525a - [trace][intelpt] fix some test failures

Author: Walter Erquinigo Date: 2022-03-18T10:35:34-07:00 New Revision: b7d525ad38a9378c1669a22b9f92e5548db9b409 URL: https://github.com/llvm/llvm-project/commit/b7d525ad38a9378c1669a22b9f92e5548db9b409 DIFF: https://github.com/llvm/llvm-project/commit/b7d525ad38a9378c1669a22b9f92e5548db9b409.di

[Lldb-commits] [PATCH] D122023: [trace][intelpt] fix some test failures

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122023/new/ https://reviews.llvm.org/D122023 _

[Lldb-commits] [PATCH] D122023: [trace][intelpt] fix some test failures

wallace updated this revision to Diff 416558. wallace added a comment. Herald added a subscriber: JDevlieghere. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122023/new/ https://reviews.llvm.org/D122023 Files: lldb/source/Commands/CommandObj

[Lldb-commits] [PATCH] D122023: [trace][intelpt] fix some test failures

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Minor fixes needed and now `./bin/lldb-dotest -p TestTrace` passes correctly. - There wa

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416532. zrthxn added a comment. Reflow to 80 cols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/docs/index.rst lldb/docs/use/intel_pt.rst Index: lld

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Please reflow the document to match the 80 column limit observed in the other docs. LGTM with that addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] 453f8c8 - [lldb] Remove lldb/lldb subdir created by wrong patch level

Author: Jonas Devlieghere Date: 2022-03-18T09:06:15-07:00 New Revision: 453f8c87ff20932c79890d93474e862d52f6fe46 URL: https://github.com/llvm/llvm-project/commit/453f8c87ff20932c79890d93474e862d52f6fe46 DIFF: https://github.com/llvm/llvm-project/commit/453f8c87ff20932c79890d93474e862d52f6fe46.d

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

wallace accepted this revision. wallace added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn added a comment. Here is the screenshot as well as the HTML file The screenshot doesn't have the CSS theming... F22478403: _home_alisamar_Desktop_lldb-build_tools_lldb_docs_html_use_intel_pt.html.png F22478406: intel_pt.html

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416506. zrthxn added a comment. Herald added a subscriber: arphaman. Referenced IPT doc from main page Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/do

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett updated this revision to Diff 416477. DavidSpickett added a comment. Add comment explaining test purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121999/new/ https://reviews.llvm.org/D121999 Files: lldb/source/Plugins/Disasse

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett updated this revision to Diff 416476. DavidSpickett added a comment. Switch to a shell test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121999/new/ https://reviews.llvm.org/D121999 Files: lldb/source/Plugins/Disassembler/LLVMC/D

[Lldb-commits] [lldb] 9f052f3 - [lldb] Require x86 target for NativePDB test

Author: David Spickett Date: 2022-03-18T12:31:03Z New Revision: 9f052f3dd2d8b59dde6278aa58c6e4477c2fdef6 URL: https://github.com/llvm/llvm-project/commit/9f052f3dd2d8b59dde6278aa58c6e4477c2fdef6 DIFF: https://github.com/llvm/llvm-project/commit/9f052f3dd2d8b59dde6278aa58c6e4477c2fdef6.diff LOG

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett added a comment. > Can you make this a shell test? Great idea, I'll do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121999/new/ https://reviews.llvm.org/D121999 ___ lldb-commits mai

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

labath added a comment. Can you make this a shell test? Something like llvm-mc | lldb -o "disassemble -n function_with_funky_insns" | FileCheck ? Presumably, llvm-mc can assemble anything that we are able to disassemble... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This updates the disassembler to enable every optional extension. Prev

[Lldb-commits] [lldb] af4da4f - [lldb] Increase timeout in TestProcessIOHandlerInterrupt

Author: Pavel Labath Date: 2022-03-18T12:14:10+01:00 New Revision: af4da4f995f830aee6fcd598c3c07ecaff89 URL: https://github.com/llvm/llvm-project/commit/af4da4f995f830aee6fcd598c3c07ecaff89 DIFF: https://github.com/llvm/llvm-project/commit/af4da4f995f830aee6fcd598c3c07ecaff89.diff

[Lldb-commits] [lldb] a4d6de2 - [lldb] Fix TestProcessIOHandlerInterrupt.py for macos

Author: Pavel Labath Date: 2022-03-18T11:51:55+01:00 New Revision: a4d6de2031ad2f92d399fc8d1b1301229ed8255b URL: https://github.com/llvm/llvm-project/commit/a4d6de2031ad2f92d399fc8d1b1301229ed8255b DIFF: https://github.com/llvm/llvm-project/commit/a4d6de2031ad2f92d399fc8d1b1301229ed8255b.diff

[Lldb-commits] [PATCH] D121900: [lldb] Add more documentation on test variants

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7fc7205bb45: [lldb] Add more documentation on test variants (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121900/new/ https://reviews

[Lldb-commits] [lldb] 14bd14f - [lldb] Fix ^C handling in IOHandlerProcessSTDIO

Author: Pavel Labath Date: 2022-03-18T08:58:30+01:00 New Revision: 14bd14f9f92f9f5eff43ec3a977b127dea1cb521 URL: https://github.com/llvm/llvm-project/commit/14bd14f9f92f9f5eff43ec3a977b127dea1cb521 DIFF: https://github.com/llvm/llvm-project/commit/14bd14f9f92f9f5eff43ec3a977b127dea1cb521.diff

[Lldb-commits] [lldb] 53e9ee3 - Revert "[lldb] Fix ^C handling in IOHandlerProcessSTDIO"

Author: Pavel Labath Date: 2022-03-18T08:58:30+01:00 New Revision: 53e9ee3027dbbee79585335f608bcf5b8f668d0a URL: https://github.com/llvm/llvm-project/commit/53e9ee3027dbbee79585335f608bcf5b8f668d0a DIFF: https://github.com/llvm/llvm-project/commit/53e9ee3027dbbee79585335f608bcf5b8f668d0a.diff

[Lldb-commits] [lldb] c7fc720 - [lldb] Add more documentation on test variants

Author: Pavel Labath Date: 2022-03-18T08:58:29+01:00 New Revision: c7fc7205bb45ee24193c519e9cd2f9f64bdde4ed URL: https://github.com/llvm/llvm-project/commit/c7fc7205bb45ee24193c519e9cd2f9f64bdde4ed DIFF: https://github.com/llvm/llvm-project/commit/c7fc7205bb45ee24193c519e9cd2f9f64bdde4ed.diff

[Lldb-commits] [lldb] 0f362f9 - [lldb] Remove process->LoadModules call from DynamicLoaderPOSIXDYLD

Author: Pavel Labath Date: 2022-03-18T08:58:29+01:00 New Revision: 0f362f9d25fd7b4baca56d3c76c688ca0113813a URL: https://github.com/llvm/llvm-project/commit/0f362f9d25fd7b4baca56d3c76c688ca0113813a DIFF: https://github.com/llvm/llvm-project/commit/0f362f9d25fd7b4baca56d3c76c688ca0113813a.diff

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

labath added a comment. In D121912#3389378 , @DavidSpickett wrote: > Do you know if the pexpect test will cleanup the debugee process if some part > of the test fails? Or will we have that hanging around in its infinite loop? It won't, but the debuggee