[Lldb-commits] [PATCH] D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d3cc2783138: Correct debugserver to write xmm/ymm/zmm reg values (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123269/new/ http

[Lldb-commits] [lldb] 4d3cc27 - Correct debugserver to write xmm/ymm/zmm reg values

Author: Jason Molenda Date: 2022-04-06T23:36:52-07:00 New Revision: 4d3cc27831383987b38e60875573982af5e0538b URL: https://github.com/llvm/llvm-project/commit/4d3cc27831383987b38e60875573982af5e0538b DIFF: https://github.com/llvm/llvm-project/commit/4d3cc27831383987b38e60875573982af5e0538b.diff

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

wallace updated this revision to Diff 421093. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123281/new/ https://reviews.llvm.org/D123281 Files: lldb/include/lldb/Target/Trace.h lldb/source/Plugins/Trace/common/Tra

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some parts of the code have to distinguish between live and postmortem threads to

[Lldb-commits] [lldb] 2aca33b - Reland "[Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON""

Author: Fangrui Song Date: 2022-04-06T20:19:07-07:00 New Revision: 2aca33baf15926afe2520a06b1427a9894226fd2 URL: https://github.com/llvm/llvm-project/commit/2aca33baf15926afe2520a06b1427a9894226fd2 DIFF: https://github.com/llvm/llvm-project/commit/2aca33baf15926afe2520a06b1427a9894226fd2.diff

[Lldb-commits] [PATCH] D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123269/new/ https://reviews.llvm.org/D123269 ___

[Lldb-commits] [PATCH] D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior

jasonmolenda updated this revision to Diff 421044. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123269/new/ https://reviews.llvm.org/D123269 Files: lldb/test/Shell/Register/x86-64-write.test lldb/test/Shell/Register/x86-64-ymm-write.test lldb

[Lldb-commits] [PATCH] D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, pengfei. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. A small mistake in the method that accepts new xmm/ymm/zmm

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

clayborg added a comment. In D123020#3426867 , @JDevlieghere wrote: > In D123020#3426839 , @llunak wrote: > >> In D123020#3426252 , @labath wrote: >> BTW, does it ma

[Lldb-commits] [lldb] 815fa5b - [lldb] Remove duplicate "warning:"

Author: Jonas Devlieghere Date: 2022-04-06T15:05:27-07:00 New Revision: 815fa5bf44c459cf5e72b35da4311d6681952e1b URL: https://github.com/llvm/llvm-project/commit/815fa5bf44c459cf5e72b35da4311d6681952e1b DIFF: https://github.com/llvm/llvm-project/commit/815fa5bf44c459cf5e72b35da4311d6681952e1b.d

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool &Debugger::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; aganea wrote: > clayborg wrote: > > aganea wrot

[Lldb-commits] [PATCH] D123254: [lldb] Disable GCC's -Wstringop-truncation warning. NFC.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I saw this warning on the bots and was confused because I too came to the conclusion that we were using strncpy correctly. LGTM. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

aganea added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool &Debugger::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg wrote: > aganea wrote: > > Ideally this

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool &Debugger::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrenc

[Lldb-commits] [PATCH] D123254: [lldb] Disable GCC's -Wstringop-truncation warning. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, JDevlieghere. Herald added subscribers: pengfei, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This warning gives false positives about lldb's correct use of strncpy t

[Lldb-commits] [PATCH] D122859: [trace] Show ideas for the main interfaces for new HTR

clayborg added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:81 +// and not to a child. +lldb::user_id_t GetLastInstructionId() { return m_last_insn_id; } + This seems like it should be stored as an optional value and if the optional v

[Lldb-commits] [lldb] 6795f37 - [NFC][trace][intelpt] Remove unneeded import

Author: Walter Erquinigo Date: 2022-04-06T13:34:11-07:00 New Revision: 6795f37c1481d702e60e17b9d8e0b98faab979ca URL: https://github.com/llvm/llvm-project/commit/6795f37c1481d702e60e17b9d8e0b98faab979ca DIFF: https://github.com/llvm/llvm-project/commit/6795f37c1481d702e60e17b9d8e0b98faab979ca.di

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

aganea added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool &Debugger::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; Ideally this should be explicitly created on the

[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e38824221db: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D123203: [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae2aa2d21b24: [lldb] Silence GCC warnings about missing returns after fully covered switches. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rGe546bbfda0ab: [lldb] Fix detecting warning options for GCC (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123202/new/ https://reviews

[Lldb-commits] [lldb] ae2aa2d - [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

Author: Martin Storsjö Date: 2022-04-06T22:50:07+03:00 New Revision: ae2aa2d21b24a912314e618d1ceb8e036449b0b1 URL: https://github.com/llvm/llvm-project/commit/ae2aa2d21b24a912314e618d1ceb8e036449b0b1 DIFF: https://github.com/llvm/llvm-project/commit/ae2aa2d21b24a912314e618d1ceb8e036449b0b1.diff

[Lldb-commits] [lldb] 6e38824 - [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.

Author: Martin Storsjö Date: 2022-04-06T22:50:07+03:00 New Revision: 6e38824221db2e0d77d334d424331b3cf1ac279a URL: https://github.com/llvm/llvm-project/commit/6e38824221db2e0d77d334d424331b3cf1ac279a DIFF: https://github.com/llvm/llvm-project/commit/6e38824221db2e0d77d334d424331b3cf1ac279a.diff

[Lldb-commits] [lldb] e546bbf - [lldb] Fix detecting warning options for GCC

Author: Martin Storsjö Date: 2022-04-06T22:50:07+03:00 New Revision: e546bbfda0ab91cf78c096d8c035851cc7c3b9f3 URL: https://github.com/llvm/llvm-project/commit/e546bbfda0ab91cf78c096d8c035851cc7c3b9f3 DIFF: https://github.com/llvm/llvm-project/commit/e546bbfda0ab91cf78c096d8c035851cc7c3b9f3.diff

[Lldb-commits] [lldb] 05b4bf2 - [trace][intelpt] Introduce instruction Ids

Author: Walter Erquinigo Date: 2022-04-06T12:19:36-07:00 New Revision: 05b4bf2571244da2cef438e907036b35a0e1f99a URL: https://github.com/llvm/llvm-project/commit/05b4bf2571244da2cef438e907036b35a0e1f99a DIFF: https://github.com/llvm/llvm-project/commit/05b4bf2571244da2cef438e907036b35a0e1f99a.di

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG05b4bf257124: [trace][intelpt] Introduce instruction Ids (authored by Walter Erquinigo ). Changed prior t

[Lldb-commits] [PATCH] D123203: [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123203/new/ https://reviews.llvm.org/D123203 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

JDevlieghere added a comment. Cool, I learned something new today. Thanks for adding that comment! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123202/new/ https://reviews.llvm.org/D123202 ___ lldb-comm

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak updated this revision to Diff 420885. llunak added a comment. Rebased on ThreadPool groups (D123225 ) and adding such thread pool to LLDB (D123226 ). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ htt

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

tschuett added a comment. You cannot access/find the global thread pool? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123226/new/ https://reviews.llvm.org/D123226 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak created this revision. llunak added reviewers: clayborg, labath. llunak added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. As a preparation for parallelizing

[Lldb-commits] [PATCH] D123203: [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, that's the way we usually deal with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123203/new/ https://reviews.llvm.org/D123203 _

[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. The gcc behavior is quite annoying here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123205/new/ ht

[Lldb-commits] [PATCH] D123206: [lldb] Silence warnings about unused static variables in RegisterInfos_arm64.h

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. Move them to the only source file that included RegisterInfos_arm64.h that actually us

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. This is great. I've been bothered by this for quite a while, but I didn't realize the fix is that easy. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This matches how another similar warning is silenced in Host/posix/ProcessLauncherPosixFork.cpp. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo created this revision. mstorsjo added reviewers: jingham, labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This silences a GCC warning after 1f7b58f2a50461493f083b2ed807b25e036286f6

[Lldb-commits] [PATCH] D123203: [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This silences warnings like this: lldb/source/Core/DebuggerEvents.cpp: In member function ‘llvm::StringRef lldb_private::Diagn

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a subscriber: mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. If testing for a warning option like -Wno- with GCC, GCC won't print any diagnostic at all, l

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett updated this revision to Diff 420769. DavidSpickett added a comment. Fix "expression"/"p" result by removing non-address bits in processElfCore::ReadMemory. I missed that it overrides this. (it was nothing to do with the target addressable bits setting) Add tests for that and proc

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett updated this revision to Diff 420766. DavidSpickett added a comment. Check that the "expression" command also treats pointers as equivalent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 F