[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

2022-04-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf91446aa290: [lldb] Show the DBGError if dsymForUUID cant find a dSYM (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] af91446 - [lldb] Show the DBGError if dsymForUUID can't find a dSYM

2022-04-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-14T16:54:00-07:00 New Revision: af91446aa2903324c81d9e0b0a8a9fc037edc1a4 URL: https://github.com/llvm/llvm-project/commit/af91446aa2903324c81d9e0b0a8a9fc037edc1a4 DIFF:

[Lldb-commits] [lldb] 03049c5 - Revert "[lldb] Pin the shared cache when iterating over its images"

2022-04-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-14T16:23:56-07:00 New Revision: 03049c51251189b5aafed825095f3adcd52b3dee URL: https://github.com/llvm/llvm-project/commit/03049c51251189b5aafed825095f3adcd52b3dee DIFF:

[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

2022-04-14 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123743/new/ https://reviews.llvm.org/D123743 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

2022-04-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/ https://reviews.llvm.org/D123793

[Lldb-commits] [lldb] 428775d - [lldb] Remove TestShell.test

2022-04-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-14T12:10:54-07:00 New Revision: 428775d5186fb075e76563c5ebab8607c3620a13 URL: https://github.com/llvm/llvm-project/commit/428775d5186fb075e76563c5ebab8607c3620a13 DIFF:

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

2022-04-14 Thread Zequan Wu via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3dbf524ad75b: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3dbf524 - [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

2022-04-14 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2022-04-14T11:06:21-07:00 New Revision: 3dbf524ad75bf4aa6d4a1f72b82000943a1d967c URL: https://github.com/llvm/llvm-project/commit/3dbf524ad75bf4aa6d4a1f72b82000943a1d967c DIFF: https://github.com/llvm/llvm-project/commit/3dbf524ad75bf4aa6d4a1f72b82000943a1d967c.diff

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

2022-04-14 Thread Zequan Wu via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGef7cba71486d: [LLDB][NativePDB] Fix inline line info in line table (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/

[Lldb-commits] [lldb] ef7cba7 - [LLDB][NativePDB] Fix inline line info in line table

2022-04-14 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2022-04-14T11:00:56-07:00 New Revision: ef7cba71486df8d6905000f932805774f1cbcc46 URL: https://github.com/llvm/llvm-project/commit/ef7cba71486df8d6905000f932805774f1cbcc46 DIFF: https://github.com/llvm/llvm-project/commit/ef7cba71486df8d6905000f932805774f1cbcc46.diff

[Lldb-commits] [PATCH] D123746: [lldb] Prevent crash when adding a stop hook with --shlib

2022-04-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG64d9b233b990: [lldb] Prevent crash when adding a stop hook with --shlib (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

2022-04-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG99d9c44434f5: [lldb] Port Process::PrintWarning* to use the new diagnostic events (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] 99d9c44 - [lldb] Port Process::PrintWarning* to use the new diagnostic events

2022-04-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-14T11:00:21-07:00 New Revision: 99d9c44434f57df5f188146925eea3bd8771260d URL: https://github.com/llvm/llvm-project/commit/99d9c44434f57df5f188146925eea3bd8771260d DIFF:

[Lldb-commits] [lldb] 64d9b23 - [lldb] Prevent crash when adding a stop hook with --shlib

2022-04-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-14T11:00:21-07:00 New Revision: 64d9b233b9905a951b450eff5b258707a35e110f URL: https://github.com/llvm/llvm-project/commit/64d9b233b9905a951b450eff5b258707a35e110f DIFF:

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

2022-04-14 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122943/new/ https://reviews.llvm.org/D122943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

2022-04-14 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/ https://reviews.llvm.org/D123092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

2022-04-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Module.h:820-825 + void ReportWarningOptimization( + llvm::Optional debugger_id = llvm::None); + + void ReportWarningUnsupportedLanguage( +

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

2022-04-14 Thread Dave Lee via Phabricator via lldb-commits
kastiglione accepted this revision. kastiglione added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Core/Module.h:820-825 + void ReportWarningOptimization( + llvm::Optional debugger_id = llvm::None); + + void

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

2022-04-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Previously this would crash. Unless we'd rather treat it as `\x0` but that could be confusing. You can always search for literal 0 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

2022-04-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Given that you'd never find empty string, just error. Also add a test that an invalid expr generates an error.

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-04-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Yes, I think that's exactly what I had in mind. Basically, the idea is to structure things such that the ondemand class can sit between the actual symbol file class and the outside world, but that it does not (and cannot) interfere with any of the interactions that

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

2022-04-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123401/new/ https://reviews.llvm.org/D123401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org