[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

zrthxn added a comment. I've tried most of these changes to see the effect it has, but in my opinion this adds quite a lot of code complexity for not enough benefit in terms of memory usage which was our goal. I think this will make the DecodedThread even more of a monolith class with single-us

[Lldb-commits] [PATCH] D122523: [lldb] Fix building standalone LLDB on Windows.

MehdiChinoune added a comment. In D122523#3433643 , @mstorsjo wrote: > @MehdiChinoune can you provide your preferred form of the git author line, > `Real Name `? Mehdi Chinoune Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D122523: [lldb] Fix building standalone LLDB on Windows.

mstorsjo added a comment. @MehdiChinoune can you provide your preferred form of the git author line, `Real Name `? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122523/new/ https://reviews.llvm.org/D122523

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik added a reviewer: LLDB. philnik added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" jgorbe wrote: > Mordante wrote: > > philnik wrote: > > > Mordante wrote: > > > >

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik updated this revision to Diff 423266. philnik added a comment. - Fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123580/new/ https://reviews.llvm.org/D123580 Files: libcxx/include/string libcxx/test/libcxx/strings/basic.string/str

[Lldb-commits] [PATCH] D122523: [lldb] Fix building standalone LLDB on Windows.

MehdiChinoune added a comment. Could someone push it for me, Please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122523/new/ https://reviews.llvm.org/D122523 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D122523: [lldb] Fix building standalone LLDB on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3031fa88f01e: [lldb] Fix building standalone LLDB on Windows. (authored by MehdiChinoune, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik updated this revision to Diff 423316. philnik added a comment. - Add Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123580/new/ https://reviews.llvm.org/D123580 Files: libcxx/include/string libcxx/test/libcxx/strings/basic.strin

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman created this revision. aaron.ballman added a reviewer: lattner. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. As a project, Clang has gotten negative public feedback about our lack of communicating changes to users. There

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 __

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/Debugger.cpp:761 m_instance_name.SetString(llvm::formatv("debugger_{0}", GetID()).str()); + g_threadpool = std::make_uniqu

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

clayborg added inline comments. Comment at: lldb/source/Core/Debugger.cpp:761 m_instance_name.SetString(llvm::formatv("debugger_{0}", GetID()).str()); + g_threadpool = std::make_unique(llvm::optimal_concurrency()); if (log_callback) clayborg wrote: > act

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A trace might contain events traced during the target's execution. For example, a

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace updated this revision to Diff 423535. wallace added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123982/new/ https://reviews.llvm.org/D123982 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target

[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

wallace added a comment. let me think about it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123375/new/ https://reviews.llvm.org/D123375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D123984: [trace][intel pt] Add a memory usage test

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The existing tests that check for the memory usage of the decoded trace are using small binaries, and in this case the memo