[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 424360. yinghuitan added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu planned changes to this revision. zequanwu added a comment. Thanks for the feedback. As you pointed out that stack scanning without symbol file info is fragile due to function pointers in stack and we don't know the parameter size pushed into the stack. Originally, I want lldb to do

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

jasonmolenda added a comment. I guess the other comment I would make is whether we should have a new ivar, instead of using the unused 0th bit of search_offset. fwiw I wasn't real clear in my previous comment. As you say in the title of this, you're trying to backtrace through a case where

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

jasonmolenda added a comment. This is obviously building on Pavel's work of https://reviews.llvm.org/D66638 for Win32 systems. What problem with that existing patchset is this addressing? Pavel's original patch assumes that we can retrieve a function's expected stack frame size, and the size

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

clayborg added a comment. If we do find what looks like a return address, is there any validation done on the instruction before the return address to see if it is a function call instruction? That would be the best way to validate that something on the stack just doesn't look like a return

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

clayborg added a comment. It is unclear how this patch works. Was there support for searching for the return address on the stack already? And this patch is just adding the a few register unwind rules for when/if the return address _is_ found for x86? This will need tests.

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 424318. yinghuitan added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

yinghuitan updated this revision to Diff 424317. yinghuitan added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124110/new/ https://reviews.llvm.org/D124110 Files: lldb/include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu created this revision. zequanwu added reviewers: labath, clayborg, jasonmolenda. Herald added subscribers: atanasyan, jrtc27, kbarton, nemanjai, sdardis. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber:

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

yinghuitan added a comment. Sounds good. Here are the changes I plan to do: 1. Rename SymbolFileActual => SymbolFileCommon. 2. Inline SymbolFileCommon.h content into SymbolFile.h, 3. Move all remaining member fields of SymbolFile class into SymbolFileCommon. Comment at:

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

This revision was automatically updated to reflect the committed changes. Closed by commit rG1056c56786c1: [lldb] Adjust libc++ string formatter for changes in D123580 (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124113/new/

[Lldb-commits] [lldb] 1056c56 - [lldb] Adjust libc++ string formatter for changes in D123580

Author: Pavel Labath Date: 2022-04-21T14:07:56+02:00 New Revision: 1056c56786c10866ffd7e878f8c75ad1f0914c07 URL: https://github.com/llvm/llvm-project/commit/1056c56786c10866ffd7e878f8c75ad1f0914c07 DIFF: https://github.com/llvm/llvm-project/commit/1056c56786c10866ffd7e878f8c75ad1f0914c07.diff

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

labath added a comment. In D124113#3464287 , @philnik wrote: > LGTM assuming you checked that it actually works with my patch applied. Do > you want to land your patch first, or should we do it the other way around? I've confirmed this with the real

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM assuming you checked that it actually works with my patch applied. Do you want to land your patch first, or should we do it the other way around? Comment at:

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123500/new/ https://reviews.llvm.org/D123500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123502/new/ https://reviews.llvm.org/D123502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D124155: [lldb] Add tests which simulate the various std::string layouts

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM, but you probably want to wait for someone from the LLDB team to approve too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124155/new/

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

labath added a comment. In D124110#3463380 , @clayborg wrote: > I might suggest we rename things like suggested in my inline comment, and > then have the "SymbolFile.h" class just include the extra needed header file? > Many of the changes in this diff

[Lldb-commits] [PATCH] D124155: [lldb] Add tests which simulate the various std::string layouts

labath updated this revision to Diff 424131. labath added a comment. Herald added a subscriber: JDevlieghere. remove the stray binary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124155/new/ https://reviews.llvm.org/D124155 Files:

[Lldb-commits] [PATCH] D124155: [lldb] Add tests which simulate the various std::string layouts

labath created this revision. labath added reviewers: shafik, philnik. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Checking whether a formatter change does not break some of the supported string layouts is difficult because it requires

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

labath added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:658 + if (!using_bitmasks) +capacity *= 2; if (size == LLDB_INVALID_OFFSET || capacity == LLDB_INVALID_OFFSET || philnik wrote: > This should only be done if the

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

labath updated this revision to Diff 424125. labath marked 2 inline comments as done. labath added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124113/new/ https://reviews.llvm.org/D124113 Files: