[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

2022-04-30 Thread Luboš Luňák via Phabricator via lldb-commits
llunak updated this revision to Diff 426269. llunak added a comment. Changed to use std::call_once(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123226/new/ https://reviews.llvm.org/D123226 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/Debugger.cpp lldb/source/Plug

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

2022-04-30 Thread Luboš Luňák via Phabricator via lldb-commits
llunak marked 2 inline comments as done. llunak added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool &Debugger::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

2022-04-30 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added a comment. I vaguely recall that some lldb bots use a stand-alone build. Say I have a build directory /tmp/RelA with `-DLLVM_ENABLE_PROJECTS=clang` cmake -GNinja -S~/llvm-project/lldb -Bout/lldb -DCMAKE_PREFIX_PATH=/tmp/RelA will print CMake Warning at cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

2022-04-30 Thread Tobias Ribizel via Phabricator via lldb-commits
upsj updated this revision to Diff 426215. upsj added a comment. restore some of the previous behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cmake lldb/cmake

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

2022-04-30 Thread Luboš Luňák via Phabricator via lldb-commits
llunak added a comment. In D122974#3483647 , @llunak wrote: > I can measure 10% startup time saved when everything is already cached. > Funnily enough, profiler consistently claims that saving caches got faster > too (I already use D122975