[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj added a comment. I don't have commit access to LLVM, so feel free to merge it Tobias Ribizel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 ___ lldb-com

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak updated this revision to Diff 427188. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 Files: lldb/source/Utility/ConstString.cpp llvm/include/llvm/ADT/StringMap.h llvm/lib/Support/StringMap.cpp Index: llvm/lib/Support/StringMap.cpp

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak updated this revision to Diff 427187. llunak edited the summary of this revision. llunak added a comment. Used a temporary variable instead of repeated 'm_string_pools[h]'. Added assert that the passed-in hash value matches, guarded by EXPENSIVE_CHECKS. It will assert also hashes computed

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

jasonmolenda added a comment. Ah, I can't share the binary/corefile that led me to this issue but I can show what it looks like. I have a function with a noreturn call, it's a crashing scenario where (as always) this is the most important bit to get right, to show the crash, 0xfff02

[Lldb-commits] [lldb] a6553d9 - Remove expected fail for TestStepNoDebug on AArch64

Author: Jason Molenda Date: 2022-05-04T15:28:02-07:00 New Revision: a6553d97df39ee810aedb6ba27522910986b4bf5 URL: https://github.com/llvm/llvm-project/commit/a6553d97df39ee810aedb6ba27522910986b4bf5 DIFF: https://github.com/llvm/llvm-project/commit/a6553d97df39ee810aedb6ba27522910986b4bf5.diff

[Lldb-commits] [lldb] df552ed - Update the CFA to use $sp when $fp is restored on arm64

Author: Jason Molenda Date: 2022-05-04T14:54:17-07:00 New Revision: df552edb08c4a1f7600b97444f6315a63c998c59 URL: https://github.com/llvm/llvm-project/commit/df552edb08c4a1f7600b97444f6315a63c998c59 DIFF: https://github.com/llvm/llvm-project/commit/df552edb08c4a1f7600b97444f6315a63c998c59.diff

[Lldb-commits] [PATCH] D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf552edb08c4: Update the CFA to use $sp when $fp is restored on arm64 (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124492/new/

[Lldb-commits] [PATCH] D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When tracing on per-core mode, we are tracing all processes, which means that after hitti

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille reopened this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. @labath does that version look good? I only changed the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760 ___

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille updated this revision to Diff 427119. serge-sans-paille added a comment. Change the rest case to something that doesn't require me to implement ppc64be corefile support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760 Files:

[Lldb-commits] [PATCH] D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I'm far from an expert on this but the change makes sense to me and has good test coverage. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction

jasonmolenda created this revision. jasonmolenda added reviewers: labath, clayborg. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This is addressing

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 427081. shafik removed reviewers: teemperor, jingham, jasonmolenda. shafik added a comment. Herald added a project: All. - Expanded test - applied clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://reviews.llvm.org/D105564

[Lldb-commits] [lldb] b7d807d - [lldb] parallelize calling of Module::PreloadSymbols()

Author: Luboš Luňák Date: 2022-05-04T19:58:25+02:00 New Revision: b7d807dbcff0d9df466e0312b4fef57178d207be URL: https://github.com/llvm/llvm-project/commit/b7d807dbcff0d9df466e0312b4fef57178d207be DIFF: https://github.com/llvm/llvm-project/commit/b7d807dbcff0d9df466e0312b4fef57178d207be.diff L

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d807dbcff0: [lldb] parallelize calling of Module::PreloadSymbols() (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https:/

[Lldb-commits] [PATCH] D124947: Allow `target create` with no local file

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124947/new/ https://reviews.llvm.org/D124947 ___

[Lldb-commits] [PATCH] D124947: Allow `target create` with no local file

jingham created this revision. jingham added reviewers: JDevlieghere, labath, clayborg, jasonmolenda. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In 92eaad2dd7adb5ee92f397cef85ab11f2612294e

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673

[Lldb-commits] [PATCH] D124370: [lldb/DWARF] Fix linking direction in CopyUniqueClassMethodTypes

labath added a comment. @clayborg, @shafik, what do you make of this version? In D124370#3481338 , @dblaikie wrote: > Should the cleanups you found for the previous test case be included in this > patch (or a separate pre/post-commit?)? The description

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

hawkinsw added a comment. In D124922#3491267 , @labath wrote: > Heh, well.. there definitely are, though a lot of things that come to mind > right now are not really suitable for a first-time contributor. Is there any > specific are that you would like

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

labath added a comment. Heh, well.. there definitely are, though a lot of things that come to mind right now are not really suitable for a first-time contributor. Is there any specific are that you would like to know (or that you know already)? One of the things that I ran into recently, but ha

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks for the patch. Do you need me to commit this for you? Left two comments inline, but I can also fix that when I'm pushing it. Comment at: lldb/test/Shell/

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

hawkinsw added a comment. In D124922#3491214 , @labath wrote: > Yeah, I guess that what I am saying. > > For me the `commands` channel gives 6 lines of output for a command. Compared > to what some of our other logging channels do, that's nothing. Total

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

labath added a comment. Yeah, I guess that what I am saying. For me the `commands` channel gives 6 lines of output for a command. Compared to what some of our other logging channels do, that's nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

hawkinsw added a comment. In D124922#3491190 , @labath wrote: > Just my opinion, but I wouldn't like to complicate the logging architecture > with file-only log statements and cross-channel dependencies. If you want to > cross-reference some other loggi

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. Thanks for your patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https://reviews.llvm.org/D122975 ___ lldb-com

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

labath added a comment. Just my opinion, but I wouldn't like to complicate the logging architecture with file-only log statements and cross-channel dependencies. If you want to cross-reference some other logging channel with the executed commands then I'd say you should enable both channels. We

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew updated this revision to Diff 427010. andrew added a comment. Remove a stray change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/ https://reviews.llvm.org/D120485 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp lldb

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

DavidSpickett added a comment. Looks good to me but final decision for @mgorny . Comment at: lldb/test/API/python_api/sbvalue_const_addrof/main.cpp:2 +#include +#include Stray change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew updated this revision to Diff 426993. andrew marked 5 inline comments as done and an inline comment as not done. andrew added a comment. Cleanup based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

hawkinsw added a comment. As always, thank you for the work that you all do on lldb! An amazing tool! It is so much fun to be able to help and I //hope// that this is a helpful addition. Please let me know whether this is something that you find useful and whether or not there are changes that

[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

hawkinsw created this revision. hawkinsw added reviewers: teemperor, JDevlieghere, labath. Herald added a project: All. hawkinsw requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When logging for the lldb channel is enabled for any category a

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426983. upsj marked an inline comment as done. upsj added a comment. move standalone-specific code to LLDBStandalone.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673

[Lldb-commits] [lldb] 2df9bd3 - Do not rely on implicit int for this test

Author: Aaron Ballman Date: 2022-05-04T09:07:57-04:00 New Revision: 2df9bd30e4a0669297529fce79ffa5655de99395 URL: https://github.com/llvm/llvm-project/commit/2df9bd30e4a0669297529fce79ffa5655de99395 DIFF: https://github.com/llvm/llvm-project/commit/2df9bd30e4a0669297529fce79ffa5655de99395.diff

[Lldb-commits] [lldb] 6234313 - Fix failing buildbot for lldb

Author: Aaron Ballman Date: 2022-05-04T08:42:52-04:00 New Revision: 6234313c6d28158645395ae325840ae3c31e6539 URL: https://github.com/llvm/llvm-project/commit/6234313c6d28158645395ae325840ae3c31e6539 DIFF: https://github.com/llvm/llvm-project/commit/6234313c6d28158645395ae325840ae3c31e6539.diff

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille added a comment. In D124760#3488289 , @DavidSpickett wrote: > I reverted this due to an assert: > https://lab.llvm.org/buildbot/#/builders/96/builds/22715/steps/6/logs/stdio > (set cmake `LLVM_ENABLE_ASSERTIONS` to `ON`) > > I think