[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126435/new/ https://reviews.llvm.org/D126435 ___

[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

jasonmolenda updated this revision to Diff 432199. jasonmolenda added a comment. Address Jonas' feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126435/new/ https://reviews.llvm.org/D126435 Files: lldb/source/Core/SourceManager.cpp lldb

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw added a comment. In D126109#3535931 , @JDevlieghere wrote: > In D126109#3534522 , @hawkinsw > wrote: > >> @DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the >> proper protocol f

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw updated this revision to Diff 432192. hawkinsw added a comment. Updating the revision to consider feedback (!= None vs is not None) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 Files: lldb/

[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

JDevlieghere added a comment. Very nice Comment at: lldb/source/Core/SourceManager.cpp:69-73 + FileSpec resolved_fspec = file_spec; + if (!FileSystem::Instance().Exists(file_spec) && + file_spec.GetDirectory().GetCString()[0] == '~') { +FileSystem::Instance().Resolve

[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Internal to Apple, we have dSYMs that include source pa

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

jingham added inline comments. Comment at: lldb/include/lldb/Target/Target.h:1451 + /// Print all the signals set in this target. + void PrintDummySignals(Stream &strm, Args signals, size_t num_signals); + JDevlieghere wrote: > Was `Args` supposed to be a refer

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

jingham updated this revision to Diff 432145. jingham added a comment. Address Jonas' review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126259/new/ https://reviews.llvm.org/D126259 Files: lldb/include/lldb/Target/Target.h lldb/incl

[Lldb-commits] [lldb] bef4da4 - Skip testing of watchpoint hit-count/ignore-count on multithreaded

Author: Jason Molenda Date: 2022-05-25T16:05:51-07:00 New Revision: bef4da4a6aef8196f007f44e3e9c8e3419ffb623 URL: https://github.com/llvm/llvm-project/commit/bef4da4a6aef8196f007f44e3e9c8e3419ffb623 DIFF: https://github.com/llvm/llvm-project/commit/bef4da4a6aef8196f007f44e3e9c8e3419ffb623.diff

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

dblaikie added a comment. In D122974#3536342 , @llunak wrote: > In D122974#3535669 , @dblaikie > wrote: > >>> It doesn't make sense to require a stable hash algorithm for an internal >>> cache file. >> >> It's a

[Lldb-commits] [PATCH] D125844: [LLDB][NativePDB] Check for missing type info to avoid crash.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c9f3ec4ad5d: [LLDB][NativePDB] Check for missing type info to avoid crash. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125844/new/

[Lldb-commits] [lldb] 5c9f3ec - [LLDB][NativePDB] Check for missing type info to avoid crash.

Author: Zequan Wu Date: 2022-05-25T13:19:27-07:00 New Revision: 5c9f3ec4ad5d930f38c5682345a589ce57a5d602 URL: https://github.com/llvm/llvm-project/commit/5c9f3ec4ad5d930f38c5682345a589ce57a5d602 DIFF: https://github.com/llvm/llvm-project/commit/5c9f3ec4ad5d930f38c5682345a589ce57a5d602.diff LOG

[Lldb-commits] [lldb] 8e757c6 - Fix conversion error to Expected

Author: Thomas Preud'homme Date: 2022-05-25T20:51:14+01:00 New Revision: 8e757c6b500dc18f0cc5a7c027682ac2aacf8eb0 URL: https://github.com/llvm/llvm-project/commit/8e757c6b500dc18f0cc5a7c027682ac2aacf8eb0 DIFF: https://github.com/llvm/llvm-project/commit/8e757c6b500dc18f0cc5a7c027682ac2aacf8eb0.

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e757c6b500d: Fix conversion error to Expected (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126402/new/ https://reviews.llvm.org/D126

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

thopre added a comment. In D126402#3538078 , @wallace wrote: > thank you! > > I'm surprised the compiler didn't do this automatically As mentioned, this is GCC 7.5. It might be different with a newer version. Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D125844: [LLDB][NativePDB] Check for missing type info to avoid crash.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125844/new/ https://reviews.llvm.org/D125844 ___ lldb-

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thank you! I'm surprised the compiler didn't do this automatically Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126402/new/ https://reviews.

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

thopre created this revision. thopre added reviewers: wallace, jj10306. Herald added a project: All. thopre requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Ubuntu 18.04 with GCC 7.5 Intel trace code fails to build due to failure to conve

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

JDevlieghere added a comment. I was about to push a fix but it seems like it was already fixed by: commit 4391625255c62074037d95a55232a87eae70c60b Author: Kazu Hirata Date: Wed May 25 09:49:05 2022 -0700 [lldb] Fix an unused function warning This patch fixes:

[Lldb-commits] [PATCH] D126394: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This should be the final patch to support intel pt decoding per cpu. It kind of does its

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

qram9 added a comment. Hi there, This change has caused the following warning: llvm-project/lldb/source/Host/common/PseudoTerminal.cpp:106:20: error: unused function 'use_ptsname' [-Werror,-Wunused-function] static std::string use_ptsname(int fd) { ^ 1 error generated. The build compiler is

[Lldb-commits] [lldb] 4391625 - [lldb] Fix an unused function warning

Author: Kazu Hirata Date: 2022-05-25T09:49:05-07:00 New Revision: 4391625255c62074037d95a55232a87eae70c60b URL: https://github.com/llvm/llvm-project/commit/4391625255c62074037d95a55232a87eae70c60b DIFF: https://github.com/llvm/llvm-project/commit/4391625255c62074037d95a55232a87eae70c60b.diff L

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. alvinhochun updated this revision to Diff 432010. alvinhochun added a comment. alvinhochun published this revision for review. Herald added a project:

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. I know very little about the interpreter so someone else can comment there. Certainly seems like a useful change. Added some generic comments. Comment at: lldb/test/API/lang/c/fpeval/TestFPEval.py:1

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

kpdev42 created this revision. kpdev42 added reviewers: clayborg, granata.enrico, davide, k8stone. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Patch adds support for fadd, fsub, fdiv, fmul and fcmp