[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. feedback-v1 Comment at: lldb/include/lldb/Target/Trace.h:520 + /// core id -> data kind -> size + llvm::DenseMap> + m_live_core_data;

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jsji. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125943/new/ https://reviews.llvm.org/D125943

[Lldb-commits] [PATCH] D126730: Fix a bug where `break com add -s py -o "some_python" BKPT_NAME` only added the command to the first breakpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rGd92f7f790c8e: Fix a copy-paste error in br com add -s py -o some_python BKPT_NAME (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d92f7f7 - Fix a copy-paste error in "br com add -s py -o 'some_python' BKPT_NAME"

Author: Jim Ingham Date: 2022-05-31T17:24:14-07:00 New Revision: d92f7f790c8e74bf796a0313cb296d726628142e URL: https://github.com/llvm/llvm-project/commit/d92f7f790c8e74bf796a0313cb296d726628142e DIFF: https://github.com/llvm/llvm-project/commit/d92f7f790c8e74bf796a0313cb296d726628142e.diff

[Lldb-commits] [lldb] ca73de4 - Adapt LLDB for D120540.

Author: Adrian Prantl Date: 2022-05-31T16:56:37-07:00 New Revision: ca73de43744503a557b1f3709c0ff4751798702f URL: https://github.com/llvm/llvm-project/commit/ca73de43744503a557b1f3709c0ff4751798702f DIFF: https://github.com/llvm/llvm-project/commit/ca73de43744503a557b1f3709c0ff4751798702f.diff

[Lldb-commits] [PATCH] D126730: Fix a bug where `break com add -s py -o "some_python" BKPT_NAME` only added the command to the first breakpoint

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126730/new/ https://reviews.llvm.org/D126730

[Lldb-commits] [PATCH] D126730: Fix a bug where `break com add -s py -o "some_python" BKPT_NAME` only added the command to the first breakpoint

jingham created this revision. jingham added reviewers: kastiglione, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This was a "probably should have copy-pasted" error. A "!" was omitted

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

clayborg added a comment. In D126464#3545142 , @PRESIDENT810 wrote: > I have refactored my code so it should looks cleaner now, but I'm not sure > how to add a test. It seems that adding a test for thin archive on macOS > platforms can be not so

[Lldb-commits] [PATCH] D126702: [lldb] Fix TCPSocket::Connect when getaddrinfo returns multiple addrs

ddiproietto created this revision. Herald added a project: All. ddiproietto requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TCPSocket::Connect() calls SocketAddress::GetAddressInfo() and tries to connect any of them (in a for loop). This

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp:119 + }; + for (SectionType section_type : g_sections) { +if (SectionSP section_sp = mstorsjo wrote: > alvinhochun wrote: > > mstorsjo wrote: > >

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp:119 + }; + for (SectionType section_type : g_sections) { +if (SectionSP section_sp = alvinhochun wrote: > mstorsjo wrote: > > I'm curious - this adds

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp:119 + }; + for (SectionType section_type : g_sections) { +if (SectionSP section_sp = mstorsjo wrote: > I'm curious - this adds new logic (copied

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

mstorsjo added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp:427 + + auto view_deleter = [](void *pMem) { ::UnmapViewOfFile(pMem); }; + std::unique_ptr pMem( alvinhochun wrote: > mstorsjo wrote: > > Do you need a

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

alvinhochun added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp:427 + + auto view_deleter = [](void *pMem) { ::UnmapViewOfFile(pMem); }; + std::unique_ptr pMem( mstorsjo wrote: > Do you need a check against `NULL`

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

mstorsjo added a reviewer: labath. mstorsjo added a comment. The implementation looks reasonable to me (I didn't investigate alternative ways of doing it but trust the reasoning that this is the most reasonable way of finding the pathname of an open handle with this filesystem driver).

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp:119 + }; + for (SectionType section_type : g_sections) { +if (SectionSP section_sp = I'm curious - this adds new logic (copied from SymbolVendorELF