[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectRegexCommand.cpp:74-76 // Pass in true for "no context switching". The command that called us // should have set up the context appropriately, we shouldn't have to // redo that. --

[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

jingham added a comment. In D126789#3550572 , @kastiglione wrote: > thank you for fixing! > > Q: why does this test have this thin `test_X`/`do_x_test` separation? We did that separation originally (and the sample test reflects that) so that you could

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:668 + [this, old_sync]() { +this->GetDebugger().SetAsyncExecution(!old_sync); + }); this should be `old_sync` (no `!`) Repository: rG LL

[Lldb-commits] [PATCH] D126596: [lldb, test] Fix typos in the lldb tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Interesting insight in which tests were clearly copied from the sample test. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 62b4482 - Revert "Adapt LLDB for D120540."

Author: Adrian Prantl Date: 2022-06-01T10:33:53-07:00 New Revision: 62b448217595c33788693f4b682ea5a84d9e2005 URL: https://github.com/llvm/llvm-project/commit/62b448217595c33788693f4b682ea5a84d9e2005 DIFF: https://github.com/llvm/llvm-project/commit/62b448217595c33788693f4b682ea5a84d9e2005.diff

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione added a comment. I noticed that the example python command and this feature don't support specifying breakpoint locations. Should it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 _

[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

kastiglione added a comment. thank you for fixing! Q: why does this test have this thin `test_X`/`do_x_test` separation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126789/new/ https://reviews.llvm.org/D126789 __

[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126789/new/ https://reviews.llvm.org/D126789 ___

[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

jingham added a comment. Note, the original code tries to finesse this by passing eLazyBoolCalculate, which then resolves to a check against the current command depth. But that check was wrong for SBDebugger.HandleCommand, which is considered at depth 0, and anyway, I don't think it ever makes

[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

jingham created this revision. jingham added reviewers: kastiglione, clayborg. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. At present, if you run a regex command (e.g. the `b` command) you will get t

[Lldb-commits] [PATCH] D126770: [lldb] [Process/FreeBSD] Do not send SIGSTOP to stopped process

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Do not send SIGSTOP when requested to halt a process that's already stopped. This results in the signal