[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

aheejin accepted this revision. aheejin added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

aheejin added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff updated this revision to Diff 434650. dschuff added a comment. - expand comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127164/new/ https://reviews.llvm.org/D127164 Files: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp ll

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:256 + WASM_SEC_TAG = 13, // Tag declarations + WASM_SEC_LAST_KNOWN = 14,// Update this when adding new sections }; aheejin wrote: > - Does this pass clang-format? Because we

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff updated this revision to Diff 434647. dschuff added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127164/new/ https://reviews.llvm.org/D127164 Files: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp l

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

aheejin added inline comments. Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:256 + WASM_SEC_TAG = 13, // Tag declarations + WASM_SEC_LAST_KNOWN = 14,// Update this when adding new sections }; - Does this pass clang-format? Because we don't have a spa

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff created this revision. dschuff added reviewers: aheejin, sbc100. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google. Herald added a reviewer: jhenderson. Herald added a project: All. dschuff requested review of this revision. Herald added subscrib

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

clayborg added a comment. Jim Ingham should give any final OK since he is the code owner of the thread plans. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48865/new/ https://reviews.llvm.org/D48865 ___

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun updated this revision to Diff 434568. alvinhochun edited the summary of this revision. alvinhochun added a comment. Addressed comments, added CRC checking for debuglink (only applies if the object does not contain a PDB build id) and added tests for this. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 added a comment. @labath In the meantime, a lot of time passed and someone patched it in D120690 , but the order on the documentation is wrong and the Python bindings need swig definitions. This patch introduces those, after rebasing with main. CHANGES

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 updated this revision to Diff 434543. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116136/new/ https://reviews.llvm.org/D116136 Files: lldb/bindings/python/python-extensions.swig lldb/docs/python_api_enums.rst Index: lldb/docs/python_api_enums.r

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:883 + std::string gnu_debuglink_file = data.GetCStr(&gnu_debuglink_offset); + gnu_debuglink_offset = llvm::alignTo(gnu_debuglink_offset, 4); + data.GetU32(&gnu

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:883 + std::string gnu_debuglink_file = data.GetCStr(&gnu_debuglink_offset); + gnu_debuglink_offset = llvm::alignTo(gnu_debuglink_offset, 4); + data.GetU32(&g

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun planned changes to this revision. alvinhochun added a comment. In D126367#3560233 , @DavidSpickett wrote: > Can you include some links to documentation of the debuglink feature in the > commit message? I assume > https://sourceware.org/gdb/

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added a comment. FWIW, most of the logic for how to deal with the gnu debuglink contents here is copied from the corresponding preexisting methods for ELF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126367/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. I won't have time to comment much more but Omair might be able to help. Also you might want to look at how the apple platforms select their ABI if you haven't already. If the answer is "with a flag in the object file" then

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Can you include some links to documentation of the debuglink feature in the commit message? I assume https://sourceware.org/gdb/onlinedocs/gdb/Separate-Debug-Files.html is what you'd want. Comment at: l

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

DavidSpickett added a comment. There is an arch setting to `target create` but I doubt passing the whole triple there will make a difference (truncated to arch only at best). Platforms do have settings so you could try adding something to `remote-windows` or presumably `host` when run on Window

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

alvinhochun added a comment. In D127048#3559918 , @mstorsjo wrote: > In D127048#3559866 , @DavidSpickett > wrote: > >>> This changes the PE/COFF and PDB plugins to set the module triple according >>> to the defa

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

mstorsjo added a comment. In D127048#3559866 , @DavidSpickett wrote: >> This changes the PE/COFF and PDB plugins to set the module triple according >> to the default target triple used to build LLDB. > > I'm missing some context here but using triple us

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

DavidSpickett added a comment. > This changes the PE/COFF and PDB plugins to set the module triple according > to the default target triple used to build LLDB. I'm missing some context here but using triple used when *building* lldb seems to conflict with the idea that the same lldb (client at