[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

Michael137 updated this revision to Diff 436083. Michael137 added a comment. Redundant destructor definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127481/new/ https://reviews.llvm.org/D127481 Files:

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

Michael137 updated this revision to Diff 436077. Michael137 added a comment. - Updated tests to avoid using `self.expect` and instead the more specific assertions from `lldbtest` and `SB API` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

jingham accepted this revision. jingham added a comment. This looks good to me as well. The job of "recreating the object from an eval of the repr output" is not even possible for many SB objects, by the time the object was made it's lost the factory invocation that produced it. And anyway, I

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9fa21ce82f: [lldb/crashlog] Show help when the command is called without any argument (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5a9fa21 - [lldb/crashlog] Show help when the command is called without any argument

Author: Med Ismail Bennani Date: 2022-06-10T13:44:43-07:00 New Revision: 5a9fa21ce82fc04d77d52eb1255dd3cf0292d573 URL: https://github.com/llvm/llvm-project/commit/5a9fa21ce82fc04d77d52eb1255dd3cf0292d573 DIFF:

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

aprantl added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/TestDataFormatterLibcxxSpan.py:23 + '[4] = 12345', + '}']) + Something you could

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun added a comment. Does this test look good: diff diff --git a/lldb/test/Shell/Commands/command-target-create-resolve-exe.test b/lldb/test/Shell/Commands/command-target-create-resolve-exe.test new file mode 100644 index ..3dfa7f0d9853 --- /dev/null +++

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

Michael137 updated this revision to Diff 435985. Michael137 added a comment. - Update to use Doxygen-style comments - Improve test robustness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127481/new/ https://reviews.llvm.org/D127481 Files:

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun added a comment. I suppose it is possible to have a Windows-only test for this. (Someone will need to verify them for me though as I don't have a build that runs tests on Windows.) This doesn't currently work with a path without the suffix though (like

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione updated this revision to Diff 435980. kastiglione added a comment. update TestConvenienceVariables.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 Files: lldb/bindings/macros.swig

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

mib accepted this revision. mib added a comment. Thanks @kastiglione ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione updated this revision to Diff 435972. kastiglione added a comment. add test/API/sanity/TestReprStrEquality.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 Files:

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

DavidSpickett added a comment. Is it easy to test this? Ideally this behaviour works with a path to a file as well as `PATH` itself e.g. `C:\foo` becomes `C:\foo.exe` and you could write a test that only runs on Windows quite easily. If not I guess you could do a shell test that compiles a

[Lldb-commits] [PATCH] D127038: Add some documentation for the "breakpoint name" feature

mib accepted this revision. mib added a comment. Thanks Jim! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127038/new/ https://reviews.llvm.org/D127038 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione added a comment. Note also that the tests use `str()` in many places, so we can be sure this hasn't regressed that. I will add a test for `repr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/

[Lldb-commits] [PATCH] D127038: Add some documentation for the "breakpoint name" feature

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thank you again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127038/new/ https://reviews.llvm.org/D127038

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

mib accepted this revision. mib added a comment. Thanks for clarifying! LGTM with a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 ___ lldb-commits

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense to me. Maybe add a small shell test that includes the example from the description? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 435939. mgorny added a comment. I've gotten so absorbed by fixing server code that I've forgotten to actually finish the test case ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 Files:

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione added a comment. @mib I tried but failed to answer that in the original commit description. I have reworded it to be more clear. Here's the relevant paragraph: > For convenience, this change switches all SB classes that implement to > `__str__` to instead implement `__repr__`. **The

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

aprantl added a comment. Thanks, this looks really good! I have a couple of small comments inline. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.h:77 +// libc++ std::span<> +bool LibcxxSpanSummaryProvider(ValueObject , Stream , `/// Formatter for

[Lldb-commits] [PATCH] D127437: [LLDB][Docs] Fix formatting of example code-block

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36757b511ea: [LLDB][Docs] Fix formatting of example code-block (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127437/new/

[Lldb-commits] [lldb] d36757b - [LLDB][Docs] Fix formatting of example code-block

Author: Adrian Prantl Date: 2022-06-10T08:17:08-07:00 New Revision: d36757b511ea6ef466a8ce608a5431a5e6173632 URL: https://github.com/llvm/llvm-project/commit/d36757b511ea6ef466a8ce608a5431a5e6173632 DIFF: https://github.com/llvm/llvm-project/commit/d36757b511ea6ef466a8ce608a5431a5e6173632.diff

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

mgorny added a comment. Thanks for the review and welcome back! In D126614#3572845 , @labath wrote: > (I think Jim would be interested in following this.) Ok, I've added him to all the related diffs. > I'm not sure I understand what this does. Is it

[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

hawkinsw added a comment. In D126240#3564913 , @jgorbe wrote: > I've been experimenting a little bit and it seems that I can avoid the > deadlocks I was seeing by applying only the modification to > `TypeCategoryMap::Add`. This would avoid the problem

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Modify the behavior of the `k` packet to kill all inferiors rather than just the current one.

[Lldb-commits] [PATCH] D127497: [lldb] [llgs] Refactor SendStopReasonForState for multiprocess

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Refactor GDBRemoteCommunicationServerLLGS::SendStopReasonForState() to accept process as an

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/span/Makefile:5 + +CXXFLAGS_EXTRAS := -std=c++20 -O0 +include Makefile.rules Might need to have some compiler version checks here since by

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

Michael137 updated this revision to Diff 435855. Michael137 added a comment. Herald added a subscriber: JDevlieghere. Removed redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127481/new/ https://reviews.llvm.org/D127481 Files:

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

Michael137 created this revision. Michael137 added reviewers: aprantl, shafik. Herald added a subscriber: mgorny. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a libcxx formatter

[Lldb-commits] [PATCH] D126668: LLDB: Fix resolving nested template parameters

labath added a comment. I don't really have the full context here, but I am wondering if we shouldn't somehow take the `DW_AT_declaration` attribute into account here. It seems like that should give a more definitive answer as to whether we can expect to see a full set of template parameters

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

labath added a reviewer: jingham. labath added a comment. (I think Jim would be interested in following this.) I'm not sure I understand what this does. Is it that, when the setting is enabled, lldb uses non-stop communication at the protocol level, but then forces an all-stop whenever one

[Lldb-commits] [PATCH] D126770: [lldb] [Process/FreeBSD] Do not send SIGSTOP to stopped process

labath added a comment. (Actually, I don't think we do it for the main `Halt` operation (though maybe we should) -- only for the SIGSTOPs send to individual threads when we're performing an all-stop.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126770: [lldb] [Process/FreeBSD] Do not send SIGSTOP to stopped process

labath added a comment. Herald added a subscriber: JDevlieghere. This still leaves the possibility of a race where the process stops on its own while you're in the process of sending the signal, right? I believe that on linux we handling this by checking the stopped events: If the application

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

labath added a comment. > How do we usually add tests for STL data structures? I have https://reviews.llvm.org/D124155, which would allow testing of different string layouts in one go. It remains to be seen how maintainable will that test be when it starts supporting many string layouts. OTOH,

[Lldb-commits] [lldb] df94877 - [lldb] [test] Implement getting thread ID on FreeBSD

Author: Michał Górny Date: 2022-06-10T10:26:58+02:00 New Revision: df948771124953df9e69e44e3bc70ea7948e51f1 URL: https://github.com/llvm/llvm-project/commit/df948771124953df9e69e44e3bc70ea7948e51f1 DIFF: https://github.com/llvm/llvm-project/commit/df948771124953df9e69e44e3bc70ea7948e51f1.diff

[Lldb-commits] [PATCH] D126982: [lldb] [test] Implement getting thread ID on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf9487711249: [lldb] [test] Implement getting thread ID on FreeBSD (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION