[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1186-1191 + // dyld doesn't think there is a binary at this address, + // but maybe there isn't a binary YET - let's look in memory + // for a proper mach-o header e

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny updated this revision to Diff 441624. mgorny added a comment. Use semaphores to sync instead of relying on ugly sleeps. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128932/new/ https://reviews.llvm.org/D128932 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicati

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteForkNonStop.py:116 +parent_pid, parent_tid, child_pid, child_tid = ( +self.start_fork_test(["fork", "sleep:2", "print-pid", "sleep:2", + "st

[Lldb-commits] [lldb] 3d477bb - [LLDB] Xfail TestStepNoDebug.py AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-07-01T12:25:43+04:00 New Revision: 3d477bbeee55ca965553778e62085a37d062323f URL: https://github.com/llvm/llvm-project/commit/3d477bbeee55ca965553778e62085a37d062323f DIFF: https://github.com/llvm/llvm-project/commit/3d477bbeee55ca965553778e62085a37d06232

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny updated this revision to Diff 441664. mgorny added a comment. Fix `sem_destroy()` assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128932/new/ https://reviews.llvm.org/D128932 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/te

[Lldb-commits] [lldb] b15b142 - [lldb/test] Don't use preexec_fn for launching inferiors

Author: Pavel Labath Date: 2022-07-01T14:36:01+02:00 New Revision: b15b1421bc9a11b318b65b489e5fd58dd917db1f URL: https://github.com/llvm/llvm-project/commit/b15b1421bc9a11b318b65b489e5fd58dd917db1f DIFF: https://github.com/llvm/llvm-project/commit/b15b1421bc9a11b318b65b489e5fd58dd917db1f.diff

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

labath added a comment. Some flakyness here: https://lab.llvm.org/buildbot/#/builders/68/builds/35111/steps/6/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126983/new/ https://reviews.llvm.org/D126983 __

[Lldb-commits] [PATCH] D128989: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Support using the vCont packet to resume multiple processes simultaneously when in non-stop mod

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

mgorny added a comment. In D126983#3624800 , @labath wrote: > Some flakyness here: > https://lab.llvm.org/buildbot/#/builders/68/builds/35111/steps/6/logs/stdio That's so rare it's going to be hard figuring out if any changes actually fix it. My only i

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

labath added a comment. In D126983#3624901 , @mgorny wrote: > In D126983#3624800 , @labath wrote: > >> Some flakyness here: >> https://lab.llvm.org/buildbot/#/builders/68/builds/35111/steps/6/logs/stdio > > That'

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

mgorny added a comment. I don't think we can reliably check whether additional threads aren't run then. I have another idea that could work better if we could assume that the scheduler runs threads of the same process somehow evenly — or well, I suppose it'd be better in any case. Rather than s

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

mgorny added a comment. In D126983#3624915 , @labath wrote: > Don't we have the ability to wait for a specific output from the process? Hmm, actually thinking about it, I suppose we could wait for m*n messages from m threads (say, n=5) and then we shoul

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

mgorny added a comment. Unfortunately, switching to `output_match` makes the test even more flaky. I think it doesn't handle it well if two output lines get sent as a single packet. That said, the other tests are probably flaky the other way — they rely on all signals being reported in a single

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu updated this revision to Diff 441726. RamNalamothu added a comment. Make the test case insensitive to compiler optimizations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 Files: lldb/sourc

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Perform a major refactoring of vCont-threads tests in order to attempt to improve their stabili

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny updated this revision to Diff 441768. mgorny added a comment. Remove obsolete include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129012/new/ https://reviews.llvm.org/D129012 Files: lldb/test/API/tools/lldb-server/vCont-threads/TestGdbRemote_vContThreads.py lldb/test/API