[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. let's try to have tests soon. It seems that the code can be simplified and tests will be very handy Comment at: lldb/include/lldb/lldb-enumerations.h:976 + eIns

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 442420. persona0220 marked an inline comment as done. persona0220 added a comment. Add some more documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembl

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 442417. persona0220 marked 13 inline comments as done. persona0220 added a comment. - Terms ‘control flow kind’ and ‘control flow type’ was mixed across source codes -> Unify into ‘control flow kind’ - Divide the ‘GetControlFlowKind’ function into two fun

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere created this revision. JDevlieghere added reviewers: labath, dblaikie, clayborg, aprantl, mib. Herald added a project: All. JDevlieghere requested review of this revision. Make sure we use the libc++ from the build dir. Currently, by passing `-stdlib=libc++`, we might pick up the sys

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8b811bf800: [lldb/Core] Fix finite progress event reporting (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.l

[Lldb-commits] [lldb] ea8b811 - [lldb/Core] Fix finite progress event reporting

Author: Med Ismail Bennani Date: 2022-07-05T16:25:40-07:00 New Revision: ea8b811bf800680e7d7bde1e8d6ff43f8ecf17cf URL: https://github.com/llvm/llvm-project/commit/ea8b811bf800680e7d7bde1e8d6ff43f8ecf17cf DIFF: https://github.com/llvm/llvm-project/commit/ea8b811bf800680e7d7bde1e8d6ff43f8ecf17cf.

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 ___ lldb-commits mailing list

[Lldb-commits] [lldb] bb9b30f - [LLDB] Remove TestLoadUnload.py Arm/Linux Xfail decorator

Author: Muhammad Omair Javaid Date: 2022-07-06T01:39:52+04:00 New Revision: bb9b30ffbe7c80c94807f01eb31429e4f9f2ce2e URL: https://github.com/llvm/llvm-project/commit/bb9b30ffbe7c80c94807f01eb31429e4f9f2ce2e DIFF: https://github.com/llvm/llvm-project/commit/bb9b30ffbe7c80c94807f01eb31429e4f9f2ce

[Lldb-commits] [lldb] 5cca2ef - [LLDB] Remove TestLoadUnload.py Arm/Linux Xfail decorator

Author: Muhammad Omair Javaid Date: 2022-07-06T01:14:40+04:00 New Revision: 5cca2ef3c35a08ce439e65e04a8d18d5bb4a6e4e URL: https://github.com/llvm/llvm-project/commit/5cca2ef3c35a08ce439e65e04a8d18d5bb4a6e4e DIFF: https://github.com/llvm/llvm-project/commit/5cca2ef3c35a08ce439e65e04a8d18d5bb4a6e

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 442397. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core

[Lldb-commits] [lldb] f51c47d - Revert "[lldb/test] Don't use preexec_fn for launching inferiors"

Author: Jonas Devlieghere Date: 2022-07-05T10:12:57-07:00 New Revision: f51c47d987917d18108f0415334f47c75db9e908 URL: https://github.com/llvm/llvm-project/commit/f51c47d987917d18108f0415334f47c75db9e908 DIFF: https://github.com/llvm/llvm-project/commit/f51c47d987917d18108f0415334f47c75db9e908.d

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

mgorny marked 5 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:147 +// vCtrlC may not do anything, so timeout if we don't get notification +if (ReadPacket(stop_response, millisecond

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1840-1841 return; -if (data->GetCompleted()) - m_current_event_id.reset(); } else { We should still reset the `m_current_event_id` here, otherwise we can get out of

[Lldb-commits] [PATCH] D126655: [lldb] [gdb-remote] Be more explicit about notification reading

mgorny abandoned this revision. mgorny added a comment. I'm going to merge this into D126614 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126655/new/ https://reviews.llvm.org/D126655 ___ lldb-commits maili

[Lldb-commits] [lldb] b7b1109 - [LLDB] Fix decorator import in TestTwoHitsOneActual.py

Author: Muhammad Omair Javaid Date: 2022-07-05T15:26:26+04:00 New Revision: b7b11091efd2f9e5e90bc449b1c2591ae0af9648 URL: https://github.com/llvm/llvm-project/commit/b7b11091efd2f9e5e90bc449b1c2591ae0af9648 DIFF: https://github.com/llvm/llvm-project/commit/b7b11091efd2f9e5e90bc449b1c2591ae0af96

[Lldb-commits] [lldb] 3b2496e - [LLDB] Skip TestTwoHitsOneActual.py on Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2022-07-05T15:01:51+04:00 New Revision: 3b2496e8faae2ba99f2d56f11f1cb44b68c353ae URL: https://github.com/llvm/llvm-project/commit/3b2496e8faae2ba99f2d56f11f1cb44b68c353ae DIFF: https://github.com/llvm/llvm-project/commit/3b2496e8faae2ba99f2d56f11f1cb44b68c353

[Lldb-commits] [lldb] ba14e4d - [LLDB] Disable TestGdbRemoteFork* for Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2022-07-05T13:45:26+04:00 New Revision: ba14e4d65cddb6057374c71232e17cbc03be974d URL: https://github.com/llvm/llvm-project/commit/ba14e4d65cddb6057374c71232e17cbc03be974d DIFF: https://github.com/llvm/llvm-project/commit/ba14e4d65cddb6057374c71232e17cbc03be97

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

thakis added a comment. Done. Thanks for the fix! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc46ae6df5f7: [lldb] Add support to load object files from thin archives (authored by PRESIDENT810, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [lldb] dc46ae6 - [lldb] Add support to load object files from thin archives

Author: Kaining Zhong Date: 2022-07-05T10:52:26+02:00 New Revision: dc46ae6df5f769b80b56a30f6d77f962fa90833d URL: https://github.com/llvm/llvm-project/commit/dc46ae6df5f769b80b56a30f6d77f962fa90833d DIFF: https://github.com/llvm/llvm-project/commit/dc46ae6df5f769b80b56a30f6d77f962fa90833d.diff

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. much better! Thanks for doing this. There are two main things to do. 1. The algorithm you are using to classify the instructions uses too many acronyms and it's very well document