[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442779. wallace added a comment. rename 'process trace save' to 'trace save' because it can actually dump the information of multiple processes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442770. wallace added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files: lldb/bindings/interface/SBTrace.i

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442769. wallace added a comment. improve command handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files: lldb/bindings/interface/SBTrace.i

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442765. wallace added a comment. make relative all paths being returned in the description file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files:

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace updated this revision to Diff 442759. wallace added a comment. minor improvements for autocompletion in the CLI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 Files:

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:582 } - + Target *target = m_exe_ctx.GetTargetPtr(); many formatting changes sneaked in. The actual changes are in the end of this file

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

jasonmolenda updated this revision to Diff 442720. jasonmolenda added a comment. Updated patch to address Jonas and David's feedback. Updated the test C file so the mach header sizeofcmds is correct. Update test to test querying an invalid mach-o binary, and the combination of a valid &

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A trace bundle contains many trace files, and, in the case of intel pt, the

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

jingham added a comment. I'm not sure whether I'm bothered that this patch handles the other captures for lambda's with captured "this" pretty differently from ones that don't capture "this". But the method for the ones that don't capture "this" is more straightforward, so maybe that's

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere updated this revision to Diff 442635. JDevlieghere added a comment. Herald added a subscriber: mgorny. I still have to test different configurations, but putting it up here for feedback about the general direction. This doesn't account yet for remote runs. Should be easy to detect

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere added a comment. In D129166#3633243 , @labath wrote: > In D129166#3633116 , @JDevlieghere > wrote: > >> Thanks for the thoughtful reply Pavel. The remote tests are something we >> care about as

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath added a comment. In D129166#3633116 , @JDevlieghere wrote: > Thanks for the thoughtful reply Pavel. The remote tests are something we care > about as well, so I'd like to have a solution for that. What do you think > about adding a "stdlib"

Re: [Lldb-commits] [lldb] f51c47d - Revert "[lldb/test] Don't use preexec_fn for launching inferiors"

I didn't get around to it today but I was planning to at least take a look today. Thanks for following up. On Wed, Jul 6, 2022 at 8:14 AM Pavel Labath wrote: > On 05/07/2022 19:14, Jonas Devlieghere via lldb-commits wrote: > > > > Author: Jonas Devlieghere > > Date: 2022-07-05T10:12:57-07:00 >

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere added a comment. In D129166#3632597 , @labath wrote: > I'm afraid this will not work on systems which do not default to libc++ > (which includes at least linux and windows), because `-stdlib=libc++` is not > "equivalent" to `-nostdlib++

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny updated this revision to Diff 442602. mgorny added a comment. Replace semaphores with completely non-fancy file-based locking. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128932/new/ https://reviews.llvm.org/D128932 Files:

Re: [Lldb-commits] [lldb] f51c47d - Revert "[lldb/test] Don't use preexec_fn for launching inferiors"

On 05/07/2022 19:14, Jonas Devlieghere via lldb-commits wrote: Author: Jonas Devlieghere Date: 2022-07-05T10:12:57-07:00 New Revision: f51c47d987917d18108f0415334f47c75db9e908 URL: https://github.com/llvm/llvm-project/commit/f51c47d987917d18108f0415334f47c75db9e908 DIFF:

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442563. Michael137 added a comment. - Fixed doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Materializer.h

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442561. Michael137 added a comment. - Add `AddOneVariable` overload that takes `ValueObjectSP` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files:

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1110 // does not interfere with our protocol. -StopSTDIOForwarding(); +if (!m_non_stop) + StopSTDIOForwarding(); mgorny

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteForkNonStop.py:116 +parent_pid, parent_tid, child_pid, child_tid = ( +self.start_fork_test(["fork", "sleep:2", "print-pid", "sleep:2", +

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:32 + get_thread_id()); +write(STDOUT_FILENO, buf, strlen(buf)); +

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny updated this revision to Diff 442550. mgorny marked an inline comment as done. mgorny edited the summary of this revision. mgorny added a comment. Implement the discussed changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129012/new/ https://reviews.llvm.org/D129012 Files:

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny marked an inline comment as done. mgorny added a comment. In D129012#3631985 , @labath wrote: > I can also imagine a setup where most of the verification happens inside the > inferior. Like, each time a thread gets to run it increments a variable

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath added a comment. I'm afraid this will not work on systems which do not default to libc++ (which includes at least linux and windows), because `-stdlib=libc++` is not "equivalent" to `-nostdlib++ -lc++` -- the former changes the include paths to use libc++, while the latter doesn't. And,

[Lldb-commits] [PATCH] D129177: [lldb][AArch64] Use "+all" feature for the disassembler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5fdcfac1bbe: [lldb][AArch64] Use +all feature for the disassembler (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129177/new/

[Lldb-commits] [lldb] e5fdcfa - [lldb][AArch64] Use "+all" feature for the disassembler

Author: David Spickett Date: 2022-07-06T12:15:01Z New Revision: e5fdcfac1bbea28c4f26721e8ff7ebddde0f9f2d URL: https://github.com/llvm/llvm-project/commit/e5fdcfac1bbea28c4f26721e8ff7ebddde0f9f2d DIFF: https://github.com/llvm/llvm-project/commit/e5fdcfac1bbea28c4f26721e8ff7ebddde0f9f2d.diff

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442525. Michael137 added a comment. - [LLDB][NFC] Create variable for hardcoded alignment/size constants in materializer - [LLDB][Expression] Allow instantiation of IR Entity from ValueObject - Removed redundant m_object_pointer_type Repository: rG

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

mgorny updated this revision to Diff 442519. mgorny marked 2 inline comments as done. mgorny added a comment. Partial update. Implemented most of the requests, except what noted below. Also implemented support for `%Stdio:` stdout forwarding style as was eventually implemented in LLGS. I

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:249 // // For Lvalues // Minor: Should we update this documentation? Comment at:

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

labath added a comment. My only complaint is about the restriction in CanTakeAddressOfLValue. It seems arbitrary. There's anything in C++ or DWARF that would prevent us from having constant-valued variables of class types. It's just that clang/llvm does not know how to emit the

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny added a comment. In D128932#3631903 , @labath wrote: > I have a feeling the semaphores will not work (compile) on darwin. I didn't > find any sem_init call there -- just sem_open. Maybe instead of semaphores we > could use files for the

[Lldb-commits] [PATCH] D129177: [lldb][AArch64] Use "+all" feature for the disassembler

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129177/new/ https://reviews.llvm.org/D129177

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath added a comment. Seems like an improvement. I'd like to hear what you make of the inline comment though. I can also imagine a setup where most of the verification happens inside the inferior. Like, each time a thread gets to run it increments a variable specific to that thread. Once

[Lldb-commits] [PATCH] D128617: [lldb] Stop passing both i386 and i686 in parallel as architectures on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG4270c9cd44f2: [lldb] Stop passing both i386 and i686 in parallel as architectures on Windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4270c9c - [lldb] Stop passing both i386 and i686 in parallel as architectures on Windows

Author: Martin Storsjö Date: 2022-07-06T12:13:36+03:00 New Revision: 4270c9cd44f2703bc5376ff085d0add156af9080 URL: https://github.com/llvm/llvm-project/commit/4270c9cd44f2703bc5376ff085d0add156af9080 DIFF:

[Lldb-commits] [PATCH] D129177: [lldb][AArch64] Use "+all" feature for the disassembler

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The "+all" feature name was added in

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

labath added a comment. I have a feeling the semaphores will not work (compile) on darwin. I didn't find any sem_init call there -- just sem_open. Maybe instead of semaphores we could use files for the synchronization? Something similar to the `wait_for_file_on_target` function, just in the

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

jasonmolenda added a comment. Thanks for the review David. I am still fiddling with handling the case where debugserver is handed the address of something that isn't actually a Mach-O binary in memory, but I'll update the patch soon with these. Comment at: