[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham added a comment. I'm out tomorrow, so I won't get a chance for a detailed reply till Monday. But my short reactions are: 1. Setting the breakpoint search to only check base names will of course make all your file and line breakpoints work, but they will also pick up extra hits. In co

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

hawkinsw added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2717 if (module_file.GetDirectory().IsEmpty()) { error.SetErrorString("invalid directory name"); return false; Sorry for

[Lldb-commits] [PATCH] D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thanks to fredz...@fb.com for coming up with this feature. When tracing in p

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When there's an error with the pathname in "command script import" lldb just says "

[Lldb-commits] [PATCH] D129332: [trace][intel pt] Support dumping the trace info in json

wallace updated this revision to Diff 443097. wallace added a comment. improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129332/new/ https://reviews.llvm.org/D129332 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/Comman

[Lldb-commits] [lldb] 72d9390 - Add a little extra test coverage for simple template names

Author: David Blaikie Date: 2022-07-08T00:12:29Z New Revision: 72d9390778966d4f87ec4b1de63c107b2fd46b9a URL: https://github.com/llvm/llvm-project/commit/72d9390778966d4f87ec4b1de63c107b2fd46b9a DIFF: https://github.com/llvm/llvm-project/commit/72d9390778966d4f87ec4b1de63c107b2fd46b9a.diff LOG:

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3637310 , @jingham wrote: > In D129307#3636695 , @clayborg > wrote: > >> In D129307#3636573 , @jingham >> wrote: >> >>> I'm not enti

[Lldb-commits] [lldb] e4c5bca - Revert "[LLDB][NFC] Decouple dwarf location table from DWARFExpression."

Author: Jonas Devlieghere Date: 2022-07-07T16:36:10-07:00 New Revision: e4c5bca597a6f12e8f789a53e862387b9808ff48 URL: https://github.com/llvm/llvm-project/commit/e4c5bca597a6f12e8f789a53e862387b9808ff48 DIFF: https://github.com/llvm/llvm-project/commit/e4c5bca597a6f12e8f789a53e862387b9808ff48.d

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

jasonmolenda updated this revision to Diff 443083. jasonmolenda added a comment. One more patch update to address David's further feedback. This is ready to land now, will give it a day in case anyone has comments or suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

jasonmolenda added inline comments. Comment at: lldb/test/API/macosx/unregistered-macho/TestUnregisteredMacho.py:46 +self.expect (both_gdb_packet, substrs=['response: {"images":[{"load_address":%d,' % macho_addr]) +self.expect (both_gdb_packet, substrs=['response

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham added a comment. In D129307#3636695 , @clayborg wrote: > In D129307#3636573 , @jingham wrote: > >> I'm not entirely clear what problem this is solving. Any actor setting >> breakpoints can already choose

[Lldb-commits] [lldb] 562c346 - [LLDB] Fix aggregate-indirect-arg.cpp failure introduced by 227dffd0b6d78154516ace45f6ed28259c7baa48

Author: Zequan Wu Date: 2022-07-07T15:01:07-07:00 New Revision: 562c3467a6738aa89203f72fc1d1343e5baadf3c URL: https://github.com/llvm/llvm-project/commit/562c3467a6738aa89203f72fc1d1343e5baadf3c DIFF: https://github.com/llvm/llvm-project/commit/562c3467a6738aa89203f72fc1d1343e5baadf3c.diff LOG

[Lldb-commits] [PATCH] D129332: [trace][intel pt] Support dumping the trace info in json

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thanks to ym...@fb.com for coming up with this change. `thread trace dump in

[Lldb-commits] [lldb] b92c334 - Remove dead code: TypeMap::RemoveMismatchedTypes(TypeClass type_class)

Author: David Blaikie Date: 2022-07-07T20:46:14Z New Revision: b92c33495aeda7d7fa7f5d3f518c59cc5785fd9f URL: https://github.com/llvm/llvm-project/commit/b92c33495aeda7d7fa7f5d3f518c59cc5785fd9f DIFF: https://github.com/llvm/llvm-project/commit/b92c33495aeda7d7fa7f5d3f518c59cc5785fd9f.diff LOG:

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat updated this revision to Diff 443053. werat added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 Files: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat updated this revision to Diff 443052. werat added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Index

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat updated this revision to Diff 443051. werat marked 2 inline comments as done. werat added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat marked 6 inline comments as done. werat added a comment. In D81471#3632297 , @labath wrote: > I guess the condition we really want to express here is "does this expression > refer to a constexpr variable (ideally one without a location)"? And the >

[Lldb-commits] [PATCH] D129327: [lldb] Add support for using integral const static data members in the expression evaluator

werat created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: shafik. Herald added a project: All. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds support for using const static integral data membe

[Lldb-commits] [lldb] 6edbde1 - Simplify some AsCString usage that was also explicitly handling default

Author: David Blaikie Date: 2022-07-07T20:27:05Z New Revision: 6edbde100132f5dc025bed64059d9fb770abd19e URL: https://github.com/llvm/llvm-project/commit/6edbde100132f5dc025bed64059d9fb770abd19e DIFF: https://github.com/llvm/llvm-project/commit/6edbde100132f5dc025bed64059d9fb770abd19e.diff LOG:

[Lldb-commits] [lldb] 856ebe9 - Retrieve as StringRef since that's how it'll be used

Author: David Blaikie Date: 2022-07-07T20:13:36Z New Revision: 856ebe9e8247698095a66f98647ee5d7cb12f337 URL: https://github.com/llvm/llvm-project/commit/856ebe9e8247698095a66f98647ee5d7cb12f337 DIFF: https://github.com/llvm/llvm-project/commit/856ebe9e8247698095a66f98647ee5d7cb12f337.diff LOG:

[Lldb-commits] [lldb] 5ade38c - [lldb] Add comments to describe m_memory_addr and IsInMemory

Author: Augusto Noronha Date: 2022-07-07T13:11:50-07:00 New Revision: 5ade38c28573b92b8b0bfd1fe7feef2fbea76ddf URL: https://github.com/llvm/llvm-project/commit/5ade38c28573b92b8b0bfd1fe7feef2fbea76ddf DIFF: https://github.com/llvm/llvm-project/commit/5ade38c28573b92b8b0bfd1fe7feef2fbea76ddf.dif

[Lldb-commits] [PATCH] D129319: [lldb] Add comments to describe m_memory_addr and IsInMemory

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ade38c28573: [lldb] Add comments to describe m_memory_addr and IsInMemory (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129319/ne

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, assuming this isn't already covered (I couldn't immediately find a test that covers string literals) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [lldb] 65cac0e - Use StringRef to avoid unnecessary copies into std::strings

Author: David Blaikie Date: 2022-07-07T19:50:12Z New Revision: 65cac0ed9266e3551663358de677161ce25a25bf URL: https://github.com/llvm/llvm-project/commit/65cac0ed9266e3551663358de677161ce25a25bf DIFF: https://github.com/llvm/llvm-project/commit/65cac0ed9266e3551663358de677161ce25a25bf.diff LOG:

[Lldb-commits] [PATCH] D129319: [lldb] Add comments to describe m_memory_addr and IsInMemory

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM, this isn't clear right now reading the source. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129319/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D129319: [lldb] Add comments to describe m_memory_addr and IsInMemory

augusto2112 created this revision. augusto2112 added a reviewer: jasonmolenda. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129319

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3636573 , @jingham wrote: > I'm not entirely clear what problem this is solving. Any actor setting > breakpoints can already choose the match depth by simply providing that many > directory components. I.e. if I kn

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

dblaikie added a comment. > The overall logic and the include and library paths make sense to me. The > rpath thingy will not work on windows as it (afaik) has no equivalent feature > (it has the equivalent of (DY)LD_LIBRARY_PATH though). Any idea what the libc++ tests do on Windows then? (on l

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I'm not entirely clear what problem this is solving. Any actor setting breakpoints can already choose the match depth by simply providing that many directory components. I.e. if

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere updated this revision to Diff 442994. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129166/new/ https://reviews.llvm.org/D129166 Files: lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/packages/Python/lldbsuite/test/configuration.py lldb/packages/Python/lld

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227dffd0b6d7: [LLDB][NFC] Decouple dwarf location table from DWARFExpression. (authored by zequanwu). Changed prior to commit: https://reviews.llv

[Lldb-commits] [lldb] 227dffd - [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

Author: Zequan Wu Date: 2022-07-07T10:26:58-07:00 New Revision: 227dffd0b6d78154516ace45f6ed28259c7baa48 URL: https://github.com/llvm/llvm-project/commit/227dffd0b6d78154516ace45f6ed28259c7baa48 DIFF: https://github.com/llvm/llvm-project/commit/227dffd0b6d78154516ace45f6ed28259c7baa48.diff LOG

[Lldb-commits] [PATCH] D111978: [lldb] Improve the error message in run_to_breakpoint_do_run

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGec48a0df9151: [lldb] Improve the error message in run_to_breakpoint_do_run (authored by JDevlieghere). Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [lldb] ec48a0d - [lldb] Improve the error message in run_to_breakpoint_do_run

Author: Jonas Devlieghere Date: 2022-07-07T10:22:45-07:00 New Revision: ec48a0df9151a5192381e44bee6a48a08ed8932b URL: https://github.com/llvm/llvm-project/commit/ec48a0df9151a5192381e44bee6a48a08ed8932b DIFF: https://github.com/llvm/llvm-project/commit/ec48a0df9151a5192381e44bee6a48a08ed8932b.d

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan updated this revision to Diff 442973. yinghuitan added a comment. Remove unnecessary format changes caused by IDE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129307/new/ https://reviews.llvm.org/D129307 Files: lldb/include/lldb/Bre

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some build system (li

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442954. Michael137 added a comment. Herald added a subscriber: mgorny. - Add more documentation - Moved `GetLambdaValueObject` into common utility header - Added defensive check to `EntityVariable::GetValueObject` Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/main.cpp:351 + break; +std::this_thread::sleep_for(std::chrono::milliseconds(125 * i)); + } labath wrote: > I'm not convinced this will be enough. How about `125 * (1<

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Fixed up in https://reviews.llvm.org/rGf3d43eca34d4. Next time I will remember to check what a test failure looks like. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129

[Lldb-commits] [lldb] f3d43ec - [lldb][Windows] Fixup overlapping memory regions tests

Author: David Spickett Date: 2022-07-07T15:36:14Z New Revision: f3d43eca34d4e3ddff2ba8a020ca21a9e963dd4f URL: https://github.com/llvm/llvm-project/commit/f3d43eca34d4e3ddff2ba8a020ca21a9e963dd4f DIFF: https://github.com/llvm/llvm-project/commit/f3d43eca34d4e3ddff2ba8a020ca21a9e963dd4f.diff LOG

[Lldb-commits] [lldb] d955185 - [lldb/test] Use the shim executable for TestGdbRemoteAttach*Or*Wait as well

Author: Pavel Labath Date: 2022-07-07T17:35:15+02:00 New Revision: d955185b9413c4bbe90d4b1f91790ddcc78baf99 URL: https://github.com/llvm/llvm-project/commit/d955185b9413c4bbe90d4b1f91790ddcc78baf99 DIFF: https://github.com/llvm/llvm-project/commit/d955185b9413c4bbe90d4b1f91790ddcc78baf99.diff

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:119 +or (region_end > previous_base and region_end <= previous_end): +self.assertFalse(base_address in base_addresses, +

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny added a comment. Herald added a subscriber: JDevlieghere. @labath, any clue why it'd be broken on Debian? https://lab.llvm.org/buildbot/#/builders/68/builds/35396 AssertionError: '$T0athread:1ddf55;name:a.out;00:;01:;02:e1bf0b8 [truncated]... != '$W00'

[Lldb-commits] [lldb] fad93cd - Revert "[lldb] [test] Improve stability of llgs vCont-threads tests"

Author: Michał Górny Date: 2022-07-07T17:01:43+02:00 New Revision: fad93cd6821992baf0e1b5c45c1606aa5fde2938 URL: https://github.com/llvm/llvm-project/commit/fad93cd6821992baf0e1b5c45c1606aa5fde2938 DIFF: https://github.com/llvm/llvm-project/commit/fad93cd6821992baf0e1b5c45c1606aa5fde2938.diff

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:777 + lldb::ValueObjectSP + GetValueObject(ExecutionContextScope *scope) const override { +return ValueObjectVariable::Create(scope, m_variable_sp); jingham wrote: > Naive

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG86e472317c8f: [lldb] [test] Improve stability of llgs vCont-threads tests (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://re

[Lldb-commits] [lldb] 86e4723 - [lldb] [test] Improve stability of llgs vCont-threads tests

Author: Michał Górny Date: 2022-07-07T16:33:55+02:00 New Revision: 86e472317c8fd9309b76c32ca55fcdeaf63f853b URL: https://github.com/llvm/llvm-project/commit/86e472317c8fd9309b76c32ca55fcdeaf63f853b DIFF: https://github.com/llvm/llvm-project/commit/86e472317c8fd9309b76c32ca55fcdeaf63f853b.diff

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; labath wrote: > mgorny wrote: >

[Lldb-commits] [lldb] 8262ff4 - [lldb/test] Add a couple of libc++ std::string layouts

Author: Pavel Labath Date: 2022-07-07T16:20:20+02:00 New Revision: 8262ff44c53568564dc919a43fae274c8b748176 URL: https://github.com/llvm/llvm-project/commit/8262ff44c53568564dc919a43fae274c8b748176 DIFF: https://github.com/llvm/llvm-project/commit/8262ff44c53568564dc919a43fae274c8b748176.diff

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

labath added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:91 + +def test_unique_base_addresses(self): +# In the past on Windows we were recording AllocationBase as the base address rename to test_region

[Lldb-commits] [lldb] 1ca8a97 - [lldb][Windows] Fix memory region base addresses when a range is split

Author: David Spickett Date: 2022-07-07T13:55:48Z New Revision: 1ca8a978023f1c1fe6018ac87ed06b7ce26f0b77 URL: https://github.com/llvm/llvm-project/commit/1ca8a978023f1c1fe6018ac87ed06b7ce26f0b77 DIFF: https://github.com/llvm/llvm-project/commit/1ca8a978023f1c1fe6018ac87ed06b7ce26f0b77.diff LOG

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca8a978023f: [lldb][Windows] Fix memory region base addresses when a range is split (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett updated this revision to Diff 442896. DavidSpickett added a comment. - Use self.process() - Check for overlapping regions instead of just the base addresses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129272/new/ https://reviews.ll

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; mgorny wrote: > labath wrote: > > I guess this should technically be a `

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

DavidSpickett added inline comments. Comment at: lldb/test/API/macosx/unregistered-macho/TestUnregisteredMacho.py:46 +self.expect (both_gdb_packet, substrs=['response: {"images":[{"load_address":%d,' % macho_addr]) +self.expect (both_gdb_packet, substrs=['respons

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; labath wrote: > I guess this should technically be a `volatile sig_atomi

[Lldb-commits] [lldb] 11a0969 - [lldb] Fixup TestLoadAfterAttach for 82ba3f4

Author: Pavel Labath Date: 2022-07-07T15:06:40+02:00 New Revision: 11a09692ad960a8e547f05f070fe8b24664a4e24 URL: https://github.com/llvm/llvm-project/commit/11a09692ad960a8e547f05f070fe8b24664a4e24 DIFF: https://github.com/llvm/llvm-project/commit/11a09692ad960a8e547f05f070fe8b24664a4e24.diff

[Lldb-commits] [lldb] 82ba3f4 - Recommit "[lldb/test] Don't use preexec_fn for launching inferiors"

Author: Pavel Labath Date: 2022-07-07T14:38:33+02:00 New Revision: 82ba3f44657ac91b4bef95dbf647dfbab482e502 URL: https://github.com/llvm/llvm-project/commit/82ba3f44657ac91b4bef95dbf647dfbab482e502 DIFF: https://github.com/llvm/llvm-project/commit/82ba3f44657ac91b4bef95dbf647dfbab482e502.diff

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, thanks. I'd consider strengthening the test to look for overlapping address ranges instead of just identical base addresses. Comment at: lldb/test/API/functional

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, let's give this a shot. Comment at: lldb/test/API/tools/lldb-server/main.cpp:351 + break; +std::this_thread::sleep_for(std::chrono::milliseconds(125 * i)

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Follow up to https://discourse.llvm.org/t/unexplained-memory-regions-on-windows/62662. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we recorded AllocationBase as the base address of the region we get from VirtualQueryEx. However, thi

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath added a comment. The overall logic and the include and library paths make sense to me. The rpath thingy will not work on windows as it (afaik) has no equivalent feature (it has the equivalent of (DY)LD_LIBRARY_PATH though). Do you just want to make that unsupported. I don't think we're r

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath accepted this revision. labath added inline comments. Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; I guess this should technically be a `vol

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny updated this revision to Diff 442823. mgorny edited the summary of this revision. mgorny added a comment. Ok, so the previous version was fundamentally botched wrt synchronization. Here's a new that: 1. Uses a barrier to ensure that all threads actually start before we `SIGSTOP`. Otherwi

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

jchecahi updated this revision to Diff 442819. jchecahi added a comment. [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test This test should exercise the usage of expressions containing string literals and ensure that lldb doesn't crash. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

serge-sans-paille added a reviewer: JDevlieghere. serge-sans-paille added inline comments. Comment at: lldb/test/Shell/Expr/TestStringLiteralExpr.test:1 +# RUN: echo %t +# RUN: echo %s This line and the one below looks like debug code and should be removed Repo

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

jchecahi created this revision. Herald added a project: All. jchecahi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test should exercise the usage of expressions containing string literals and ensure that lldb doesn't crash. Reposi

[Lldb-commits] [PATCH] D129257: [trace][intel pt] Add a cgroup filter

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It turns out that cgroup filtering is relatively trivial and works really nic