[Lldb-commits] [PATCH] D130528: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG4871dfc64e35: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2 (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4871dfc - [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

Author: Slava Gurevich Date: 2022-07-25T20:52:45-07:00 New Revision: 4871dfc64e35e9cf07008c56299125694c81720a URL: https://github.com/llvm/llvm-project/commit/4871dfc64e35e9cf07008c56299125694c81720a DIFF:

[Lldb-commits] [PATCH] D130528: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

fixathon updated this revision to Diff 447545. fixathon added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130528/new/ https://reviews.llvm.org/D130528 Files:

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added subscribers: jsji, ctetreau, pengfei. Herald added a project: All. JDevlieghere requested review of this revision. Xcode 14 no longer puts the Rosetta expanded shared cache under `16.0`.

[Lldb-commits] [PATCH] D130528: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

shafik added a comment. I believe this broke the lldb build bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45608/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130528/new/ https://reviews.llvm.org/D130528

[Lldb-commits] [lldb] 9877159 - Revert "[LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2"

Author: Slava Gurevich Date: 2022-07-25T18:23:19-07:00 New Revision: 9877159dd65ae6d2c4afc4c459d2eefe2473e616 URL: https://github.com/llvm/llvm-project/commit/9877159dd65ae6d2c4afc4c459d2eefe2473e616 DIFF:

[Lldb-commits] [PATCH] D130528: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

fixathon reopened this revision. fixathon added a comment. This revision is now accepted and ready to land. Reopen to fix up a couple of typomatic bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130528/new/ https://reviews.llvm.org/D130528

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg added a comment. In D130045#3675738 , @labath wrote: > In D130045#310 , @JDevlieghere > wrote: > >> I'm slightly worried about the change to make the new "fuzzy" matching the >> default. While it

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

jasonmolenda added a comment. I should have added, this bug has been in lldb probably forever - at least for a few years. Also, this test case explicitly builds without debug information because debug information (on Darwin) results in a different bug being hit, where these data symbols are

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. If you add a binary to

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

clayborg marked 4 inline comments as done. clayborg added a comment. Marking things as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130401/new/ https://reviews.llvm.org/D130401 ___ lldb-commits

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

clayborg updated this revision to Diff 447523. clayborg added a comment. - Added windows tests to make sure FileSpecList::FindCompatibleIndex() works on windows - Use lambdas to simplify code in FileSpecList::FindCompatibleIndex() - Remove the "full" argument from FindCompatibleIndex - Reword

[Lldb-commits] [PATCH] D130528: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9aedd94e679: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2 (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b9aedd9 - [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

Author: Slava Gurevich Date: 2022-07-25T16:40:57-07:00 New Revision: b9aedd94e6796e4b4866ab4c091b736b3db58cb7 URL: https://github.com/llvm/llvm-project/commit/b9aedd94e6796e4b4866ab4c091b736b3db58cb7 DIFF:

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

clayborg added inline comments. Comment at: lldb/include/lldb/Core/FileSpecList.h:140-141 + /// + /// \param[in] full + /// Should FileSpec::Equal be called with "full" true or false. + /// labath wrote: > Is this ever being called with full=false? If

[Lldb-commits] [PATCH] D130528: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 2

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, yinghuitan, jingham, JDevlieghere. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Improve LLDB reliability by fixing the

[Lldb-commits] [PATCH] D130524: Don't hold the StackFrame mutex while getting a ValueObject Dynamic value

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg, augusto2112. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We've noticed occasional hangs in the test

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

tzb99 added a comment. In D128250#3676635 , @tzb99 wrote: > In D128250#3640942 , @Emmmer wrote: > >> This patch change: >> >> - Add the recognition of architecture riscv64 in `HostInfoBase.cpp` >> - Add the

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord added a comment. Friendly ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129682/new/ https://reviews.llvm.org/D129682 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

persona0220 updated this revision to Diff 447437. persona0220 added a comment. Add default implementation for GetControlFlowKind() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130320/new/ https://reviews.llvm.org/D130320 Files: lldb/include/lldb/Core/Disassembler.h

[Lldb-commits] [PATCH] D130504: [lldb][NFC] Pass ParsedDWARFTypeAttributes as const reference into ParseArrayType()

aeubanks created this revision. aeubanks added a reviewer: dblaikie. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes a FIXME Repository: rG LLVM Github

[Lldb-commits] [PATCH] D130340: [lldb] [gdb-remote] Refactor killing process and move it to client

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8068751189af: [lldb] [gdb-remote] Refactor killing process and move it to client (authored by mgorny). Herald added a project: LLDB. Changed prior

[Lldb-commits] [lldb] 8068751 - [lldb] [gdb-remote] Refactor killing process and move it to client

Author: Michał Górny Date: 2022-07-25T18:43:32+02:00 New Revision: 8068751189af3099d9abef8953a9639d6798535c URL: https://github.com/llvm/llvm-project/commit/8068751189af3099d9abef8953a9639d6798535c DIFF: https://github.com/llvm/llvm-project/commit/8068751189af3099d9abef8953a9639d6798535c.diff

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

tzb99 added a comment. In D128250#3640942 , @Emmmer wrote: > This patch change: > > - Add the recognition of architecture riscv64 in `HostInfoBase.cpp` > - Add the recognition of architecture riscv64 and riscv32 in > `ObjectFilePECOFF.cpp` > - Add

[Lldb-commits] [lldb] 52465dc - [lldb] Make compiler-rt an optional LLDB test dependency

Author: Jonas Devlieghere Date: 2022-07-25T09:28:56-07:00 New Revision: 52465dc17877d742aad737622e0da04aea2d72cb URL: https://github.com/llvm/llvm-project/commit/52465dc17877d742aad737622e0da04aea2d72cb DIFF:

[Lldb-commits] [lldb] 91098fe - [lldb][AArch64] Use macro for unused var without asserts enabled

Author: David Spickett Date: 2022-07-25T15:14:49Z New Revision: 91098fec960f501c95c6ecdede604484750367e4 URL: https://github.com/llvm/llvm-project/commit/91098fec960f501c95c6ecdede604484750367e4 DIFF: https://github.com/llvm/llvm-project/commit/91098fec960f501c95c6ecdede604484750367e4.diff

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer added a comment. In D130342#3676318 , @DavidSpickett wrote: > Please note in the commit title/description that this is adding riscv64 only. > > Does this build if you don't have the rest of the changes from > https://reviews.llvm.org/D128250? Or

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer updated this revision to Diff 447344. Emmmer added a comment. `case llvm::Triple::riscv64:` in `ArchSpec::CharIsSignedByDefault()` is unnecessary as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/ https://reviews.llvm.org/D130342 Files:

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

DavidSpickett added a comment. Please note in the commit title/description that this is adding riscv64 only. Does this build if you don't have the rest of the changes from https://reviews.llvm.org/D128250? Or do you plan to split out more from that and have this depend on those changes.

[Lldb-commits] [lldb] 82d4f39 - [lldb][AArch64] Fix an unused variable warning in release builds. NFC

Author: Dmitri Gribenko Date: 2022-07-25T16:58:03+02:00 New Revision: 82d4f39f342165a92eaa1fe74488158942cf27b4 URL: https://github.com/llvm/llvm-project/commit/82d4f39f342165a92eaa1fe74488158942cf27b4 DIFF:

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Architecture/RISCV64/ArchitectureRISCV64.cpp:23 +void lldb_private::ArchitectureRISCV64::Initialize() { + PluginManager::RegisterPlugin(GetPluginNameStatic(), "RISC-V64", +

[Lldb-commits] [PATCH] D129487: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG883b0d5b7f87: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 883b0d5 - [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

Author: David Spickett Date: 2022-07-25T15:51:36+01:00 New Revision: 883b0d5b7f873a7d6f8c8ee13c7f6174a2a79a50 URL: https://github.com/llvm/llvm-project/commit/883b0d5b7f873a7d6f8c8ee13c7f6174a2a79a50 DIFF:

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer updated this revision to Diff 447322. Emmmer added a comment. > Why is this only needed for PECOFF? (maybe it is the only one that lists them > like this) At first, I tracked a bug from `LLDBServerTests` and thought that `GetArchitecture()` returned a wrong match, so I added `case

Re: [Lldb-commits] [lldb] 2622c5e - [lldb] Adapt lldb tests to changes in 71cdb8c6f144

On 24/07/2022 00:45, Augusto Noronha via lldb-commits wrote: Author: Augusto Noronha Date: 2022-07-23T15:37:26-07:00 New Revision: 2622c5e212646d1c8d6a43444d7c5b551f0221ad URL: https://github.com/llvm/llvm-project/commit/2622c5e212646d1c8d6a43444d7c5b551f0221ad DIFF:

[Lldb-commits] [lldb] ae8a660 - [lldb][ARM/AArch64] Use sys/uio.h instead of socket.h in native register context

Author: David Spickett Date: 2022-07-25T12:35:57Z New Revision: ae8a6602fb7260cc4b6d07689c8ac80f0fb4d86a URL: https://github.com/llvm/llvm-project/commit/ae8a6602fb7260cc4b6d07689c8ac80f0fb4d86a DIFF: https://github.com/llvm/llvm-project/commit/ae8a6602fb7260cc4b6d07689c8ac80f0fb4d86a.diff

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

labath added inline comments. Comment at: lldb/include/lldb/Core/FileSpecList.h:140-141 + /// + /// \param[in] full + /// Should FileSpec::Equal be called with "full" true or false. + /// Is this ever being called with full=false? If not can we drop it?

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

labath added a comment. In D130045#310 , @JDevlieghere wrote: > I'm slightly worried about the change to make the new "fuzzy" matching the > default. While it makes sense for the breakpoints, I wouldn't generally > expect `./a/b/c/main.cpp` to

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1347 case llvm::COFF::IMAGE_FILE_MACHINE_ARM64: + case llvm::COFF::IMAGE_FILE_MACHINE_RISCV64: ArchSpec arch; Why is this only needed for PECOFF?

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

DavidSpickett added a comment. I've stacked some reviews onto this that end in a new test that covers this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130307/new/ https://reviews.llvm.org/D130307

[Lldb-commits] [PATCH] D130468: [lldb][ARM] Add tests for vpush/vpop D registers

DavidSpickett added a reviewer: clayborg. DavidSpickett added inline comments. Comment at: lldb/test/API/arm/emulation/new-test-files/test-vpush-1-dregs-thumb.dat:70 +0x +0x +] This is the part that fails without the fix from

[Lldb-commits] [PATCH] D130468: [lldb][ARM] Add tests for vpush/vpop D registers

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we just checked via S regs and were not checking memory

[Lldb-commits] [PATCH] D130467: [lldb][ARM] Misc improvements to TestEmulations

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Look for files that end width arm/thumb.dat, meaning we don't try

[Lldb-commits] [PATCH] D130464: [lldb][ARM] Print mismatched registers in emulation tests

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Also correct the test failed message. It implies that what it's done

[Lldb-commits] [PATCH] D130462: [LLDB][ARM] Generalise adding register state in emulation tests

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since some s and d registers overlap we will error if we find both.

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

DavidSpickett added a comment. So I looked into what *should* be testing this and if it was done comprehensively it would have been testing it. However the Arm emulation tests: - Don't check D registers directly, only S (which is why we didn't miss the upper 32 bits). - Don't verify that