[Lldb-commits] [PATCH] D130582: [lldb] Skip the new mte_core_file test like other MTE tests

DavidSpickett added a comment. The windows bot is also ok with it https://lab.llvm.org/buildbot/#/builders/83/builds/21772. What setup did you have issues on and what did the errors say? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130582/new/ h

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:57 + self.assertNotEqual(second_sym.GetStartAddress().GetLoadAddress(target), + second_sym.GetStartAddress().GetFileAddress()) + -

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

DavidSpickett added a comment. @labath Did you forget about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129750/new/ https://reviews.llvm.org/D129750 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f3cd6bfc67: [clang] Implement ElaboratedType sugaring for types

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 447974. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

labath added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:219-224 + /// Get the path separator for the current path style. + /// + /// \return + /// A path separator character for this path. + char GetPathSeparator() const; + claybor

[Lldb-commits] [PATCH] D130607: [trace] Add instruction control flow kind to JSON trace dumper's output

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde3cf2e83d2: [trace] Add instruction control flow kind to JSON trace dumper's output (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [lldb] dde3cf2 - [trace] Add instruction control flow kind to JSON trace dumper's output

Author: Jakob Johnson Date: 2022-07-27T05:23:59-07:00 New Revision: dde3cf2e83d2a2aec5b46bdac64efbc28a3b2b20 URL: https://github.com/llvm/llvm-project/commit/dde3cf2e83d2a2aec5b46bdac64efbc28a3b2b20 DIFF: https://github.com/llvm/llvm-project/commit/dde3cf2e83d2a2aec5b46bdac64efbc28a3b2b20.diff

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

labath added a comment. In D130045#3678054 , @clayborg wrote: > In D130045#3675738 , @labath wrote: > >> In D130045#310 , @JDevlieghere >> wrote: >> >>> I'm slightly

[Lldb-commits] [lldb] 1400a3c - [lldb] Always use APFloat for FP dumping

Author: Pavel Labath Date: 2022-07-27T14:30:35+02:00 New Revision: 1400a3cb8d53c8c10e23ecdd4f241ea9cff404b5 URL: https://github.com/llvm/llvm-project/commit/1400a3cb8d53c8c10e23ecdd4f241ea9cff404b5 DIFF: https://github.com/llvm/llvm-project/commit/1400a3cb8d53c8c10e23ecdd4f241ea9cff404b5.diff

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

This revision was automatically updated to reflect the committed changes. Closed by commit rG1400a3cb8d53: [lldb] Always use APFloat for FP dumping (authored by labath). Changed prior to commit: https://reviews.llvm.org/D129750?vs=444586&id=448010#toc Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

labath added a comment. In D129750#3681676 , @DavidSpickett wrote: > @labath Did you forget about this? Yeah, pretty much that. Committed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129750/new/ ht

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

labath added a comment. Sorry for dropping off. Using the mangled name helped, but I am still moderately worried about that the name that's going to be matched here is different from the "real" name that gets computed later

[Lldb-commits] [PATCH] D130341: [lldb] [gdb-remote] Use vKill packet if multiprocess & available

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:4268 +if (response.IsOKResponse()) + return SIGKILL; + This is a host signal number (and not really available on windows). Maybe we should

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

labath added a comment. Sorry about the delay. I've been putting this off because it's complicated, although that's a lousy excuse. The gist of it is that I don't think that the existing setup of the "async threads" and "continue locks" is going to work in this new world. The reason it has work

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

labath added inline comments. Comment at: lldb/test/API/lang/c/fpeval/main.c:3-4 +{ +double a = 42.0; +double b = 2.0; +return 0; Set break point at this line. kpdev42 wrote: > clayborg wrote: > > We should be testing "float" and "long double" as

[Lldb-commits] [PATCH] D130341: [lldb] [gdb-remote] Use vKill packet if multiprocess & available

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:4268 +if (response.IsOKResponse()) + return SIGKILL; + labath wrote: > This is a host signal number (and not really available on windows).

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 closed this revision. Michael137 added a comment. Missed the differential link in the commits. This patch has been merged to main in following commits: 8184b252cdab2fbe44f766d6de28b29ebe4c8753 fcf4e252f4d992cade4bdfe5aed10ff96fa40202 317c8bf84d185c6b4a51a415c0deb7f8af661cb6 Re

[Lldb-commits] [PATCH] D130602: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130602/new/ https://reviews.llvm.org/D130602 ___

[Lldb-commits] [lldb] 2430156 - [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3

Author: Slava Gurevich Date: 2022-07-27T10:39:49-07:00 New Revision: 24301569f080d60f644d7a69496596cbd65079ce URL: https://github.com/llvm/llvm-project/commit/24301569f080d60f644d7a69496596cbd65079ce DIFF: https://github.com/llvm/llvm-project/commit/24301569f080d60f644d7a69496596cbd65079ce.diff

[Lldb-commits] [PATCH] D130602: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG24301569f080: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3 (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] a8c3d98 - [DebugInfo] Teach LLVM and LLDB about ptrauth in DWARF

Author: Jonas Devlieghere Date: 2022-07-27T11:48:35-07:00 New Revision: a8c3d9815e0443bacf5315536ad356e4acb184f2 URL: https://github.com/llvm/llvm-project/commit/a8c3d9815e0443bacf5315536ad356e4acb184f2 DIFF: https://github.com/llvm/llvm-project/commit/a8c3d9815e0443bacf5315536ad356e4acb184f2.d

[Lldb-commits] [PATCH] D130215: [DebugInfo] Teach dwarfdump and lldb about ptrauth DWARF tags and attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGa8c3d9815e04: [DebugInfo] Teach LLVM and LLDB about ptrauth in DWARF (authored by JDevlieghere). Heral

[Lldb-commits] [PATCH] D130655: [LLDB][NFC] Fix possible resource leak

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, alvinhochun. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SymbolVendorPECOFF object is leaked on early return at line 110

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, labath. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Seems like a typo in the function that never returns a significant valu

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg added a comment. There must be a test for this, obviously we don't have one, but check the blame log and ask the original author how this should be tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] 2cfcbe2 - [LLDB][NFC] Fix possible resource leak

Author: Slava Gurevich Date: 2022-07-27T13:19:13-07:00 New Revision: 2cfcbe295a313846222ac9b35b14a261e77a89a8 URL: https://github.com/llvm/llvm-project/commit/2cfcbe295a313846222ac9b35b14a261e77a89a8 DIFF: https://github.com/llvm/llvm-project/commit/2cfcbe295a313846222ac9b35b14a261e77a89a8.diff

[Lldb-commits] [PATCH] D130655: [LLDB][NFC] Fix possible resource leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cfcbe295a31: [LLDB][NFC] Fix possible resource leak (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130655/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 492245d - [lldb][NFC] Pass ParsedDWARFTypeAttributes as const reference into ParseArrayType()

Author: Arthur Eubanks Date: 2022-07-27T13:39:46-07:00 New Revision: 492245d9596dfb85ce2b9bd8b6d7061865b8a384 URL: https://github.com/llvm/llvm-project/commit/492245d9596dfb85ce2b9bd8b6d7061865b8a384 DIFF: https://github.com/llvm/llvm-project/commit/492245d9596dfb85ce2b9bd8b6d7061865b8a384.diff

[Lldb-commits] [PATCH] D130504: [lldb][NFC] Pass ParsedDWARFTypeAttributes as const reference into ParseArrayType()

This revision was automatically updated to reflect the committed changes. Closed by commit rG492245d9596d: [lldb][NFC] Pass ParsedDWARFTypeAttributes as const reference into… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13050

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

clayborg added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:219-224 + /// Get the path separator for the current path style. + /// + /// \return + /// A path separator character for this path. + char GetPathSeparator() const; + labat

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. Ping. This was accepted before but I had Buildbot issues. Those should all be resolved in this updated patch after a revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130549/new/ https://reviews.llvm.org/D130549

Re: [Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

So far as I can tell, we don't have any significant tests for the "queue specific breakpoint or breakpoint location" feature. There's a pretty extensive test for identifying queues & getting more detail from them in test/API/macosx/queues/TestQueues.py, but it doesn't test the breakpoint featu

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg added a comment. Thanks for the info! Should be easy to test this function at least like you mentioned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 ___

[Lldb-commits] [lldb] 27893ff - Call WatchpointList::RemoveAll in Target::Destroy.

Author: Jim Ingham Date: 2022-07-27T15:15:05-07:00 New Revision: 27893ff1ad750d9828ca3a774ba9f0029c16149f URL: https://github.com/llvm/llvm-project/commit/27893ff1ad750d9828ca3a774ba9f0029c16149f DIFF: https://github.com/llvm/llvm-project/commit/27893ff1ad750d9828ca3a774ba9f0029c16149f.diff LO

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

smeenai added a comment. In D130549#3683423 , @clayborg wrote: > Ping. This was accepted before but I had Buildbot issues. Those should all be > resolved in this updated patch after a revert. Sorry for the delay. I can confirm this builds correctly for

[Lldb-commits] [lldb] ecda408 - [lldb] Read from the Rosetta shared cache with Xcode 14

Author: Jonas Devlieghere Date: 2022-07-27T15:26:46-07:00 New Revision: ecda408178fc6486ea568263cdda6624f5bcb8c7 URL: https://github.com/llvm/llvm-project/commit/ecda408178fc6486ea568263cdda6624f5bcb8c7 DIFF: https://github.com/llvm/llvm-project/commit/ecda408178fc6486ea568263cdda6624f5bcb8c7.d

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGecda408178fc: [lldb] Read from the Rosetta shared cache with Xcode 14 (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: ht

[Lldb-commits] [PATCH] D130674: Accurate watchpoint hit counts redux

jingham created this revision. jingham added reviewers: labath, clayborg, jasonmolenda, JDevlieghere. Herald added a subscriber: kristof.beyls. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a r

[Lldb-commits] [PATCH] D130674: Accurate watchpoint hit counts redux

jingham added a comment. Note, just so it isn't confusing, there are some other bits of the ThreadPlan machinery where a ThreadPlan or the Thread itself can say "Even though the thread plan computation says I should stop, I'm going to force a run". However, those controls were all just about t

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon planned changes to this revision. fixathon added a comment. Working on adding unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 ___ lldb-commi