[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

jasonmolenda added inline comments. Comment at: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:707-713 + if (second_byte_sans_reg == 0x24) +return true; + + // use SIB byte + // ff 24 fe jmpq *(%rsi,%rdi,8) + if (second_byte_sans_reg == 0

[Lldb-commits] [lldb] 768e59d - [LLDB][RISCV] Add riscv register enums

Author: Emmmer Date: 2022-08-02T11:55:33+08:00 New Revision: 768e59d959c7e23e98cda1b08c5b6b68dbc1d2a7 URL: https://github.com/llvm/llvm-project/commit/768e59d959c7e23e98cda1b08c5b6b68dbc1d2a7 DIFF: https://github.com/llvm/llvm-project/commit/768e59d959c7e23e98cda1b08c5b6b68dbc1d2a7.diff LOG: [

[Lldb-commits] [PATCH] D130899: [LLDB][RISCV] Add riscv register enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG768e59d959c7: [LLDB][RISCV] Add riscv register enums (authored by Emmmer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130899/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

fixathon added inline comments. Comment at: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:707-713 + if (second_byte_sans_reg == 0x24) +return true; + + // use SIB byte + // ff 24 fe jmpq *(%rsi,%rdi,8) + if (second_byte_sans_reg == 0x24)

[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

jasonmolenda added inline comments. Comment at: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:707-713 + if (second_byte_sans_reg == 0x24) +return true; + + // use SIB byte + // ff 24 fe jmpq *(%rsi,%rdi,8) + if (second_byte_sans_reg == 0

[Lldb-commits] [PATCH] D130813: Add ability for lldb to load binaries in a process/corefile given only a load address & no dynamic loader

jasonmolenda updated this revision to Diff 449159. jasonmolenda added a comment. I was using an obsoleted linker flag to seg the vmaddrs of two dylibs and laying them out there in the corefile. This won't work long-term, and I really wanted to make sure lldb will slide binaries correctly, so I

[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

fixathon added a comment. Herald added subscribers: JDevlieghere, pengfei. Herald added a project: All. flagging suspicious duplicate code Comment at: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:707-713 + if (second_byte_sans_reg == 0x24) +

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. In D130796#3691227 , @zequanwu wrote: >> If you find yourself needing to do extra work to work its limitations, we >> should fix that algorithm instead. > > That makes sense. I'll work on fixing `RangeVectorData`. After thinkin

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Core/Module.cpp:740 + bool user_provided_name_is_mangled = + Mangled::GetManglingScheme(m_name.GetStringRef()) != + Mangled::eManglingSchemeNone; labat

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added a comment. This looks sensible to me, although it might be good if someone else more familiar with this code has a look too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130942/new/ https://reviews.llvm.org/D130942 ___

[Lldb-commits] [PATCH] D130937: [LLDB][NFC][Correctness] Fix bad null check

This revision was automatically updated to reflect the committed changes. Closed by commit rG30b391119737: [LLDB][NFC][Correctness] Fix bad null check (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130937/new/ https://reviews.

[Lldb-commits] [lldb] 30b3911 - [LLDB][NFC][Correctness] Fix bad null check

Author: Slava Gurevich Date: 2022-08-01T14:45:26-07:00 New Revision: 30b39111973798451397a1360dc7abc3e2490c84 URL: https://github.com/llvm/llvm-project/commit/30b39111973798451397a1360dc7abc3e2490c84 DIFF: https://github.com/llvm/llvm-project/commit/30b39111973798451397a1360dc7abc3e2490c84.diff

[Lldb-commits] [PATCH] D130937: [LLDB][NFC][Correctness] Fix bad null check

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130937/new/ https://reviews.llvm.org/D130937 ___

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a reviewer: shafik. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is needed for object files with MS ABI and de

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon created this revision. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130939 Files: lldb/source/Plugins/Process/gdb-remote/G

[Lldb-commits] [PATCH] D130925: [trace] Replace TraceCursorUP with TraceCursorSP

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bec33b16db1: [trace] Replace TraceCursorUP with TraceCursorSP (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130925/new/ https://revi

[Lldb-commits] [lldb] 3bec33b - [trace] Replace TraceCursorUP with TraceCursorSP

Author: Jakob Johnson Date: 2022-08-01T13:53:53-07:00 New Revision: 3bec33b16db11c67d43bda134520a2132ff606c9 URL: https://github.com/llvm/llvm-project/commit/3bec33b16db11c67d43bda134520a2132ff606c9 DIFF: https://github.com/llvm/llvm-project/commit/3bec33b16db11c67d43bda134520a2132ff606c9.diff

[Lldb-commits] [PATCH] D130937: [LLDB][NFC][Correctness] Fix bad null check

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a subscriber: emaste. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix incorrect null-ch

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty nice!! Just some few minor changes and good to go Comment at: lldb/bindings/interface/SBTraceCursor.i:1-7 +//===-- SWIG Interface for SBTraceCursor.h -

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBTraceCursor.h:1-2 +//===-- SBTraceCursor.h ---*- C++ +//-*-===// +// Broken ASCII art Comment at: lldb/source/API/SBTrace.cpp:47

[Lldb-commits] [PATCH] D130930: [trace] Add SBTraceCursor bindings

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a subscriber: mgorny. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add bindings for the `TraceCursor` to allo

[Lldb-commits] [PATCH] D130929: [LLDB][Reliability] Remove dead code.

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove redundant code that can never execute due to prec

[Lldb-commits] [PATCH] D130925: [trace] Replace TraceCursorUP with TraceCursorSP

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great! that will make all the bindings very easy to handle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130925/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Are the files in `lldb/test/API/commands/trace/intelpt-kernel-trace/cores/` actual kernel traces? If not, just use some trace files that are already present in the repo. You can us

[Lldb-commits] [PATCH] D130924: [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bab358e3922: [trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API… (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] 9bab358 - [trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes

Author: Jakob Johnson Date: 2022-08-01T11:52:15-07:00 New Revision: 9bab358e39225a657be829962d7f9532b492ca93 URL: https://github.com/llvm/llvm-project/commit/9bab358e39225a657be829962d7f9532b492ca93 DIFF: https://github.com/llvm/llvm-project/commit/9bab358e39225a657be829962d7f9532b492ca93.diff

[Lldb-commits] [PATCH] D130925: [trace] Replace TraceCursorUP with TraceCursorSP

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The use of `std::unique_ptr` with `TraceCursor` adds unnecessary complexity t

[Lldb-commits] [PATCH] D130924: [NFC][trace] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130924/new/ https://reviews.llvm.org/D130924 __

[Lldb-commits] [PATCH] D130924: [trace][intelpt] Update TraceIntelPTBundleSaver.cpp to accommodate FileSpec API changes

jj10306 created this revision. jj10306 added reviewers: clayborg, wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D130309 introduced changes to th

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 added a comment. In D130803#3690754 , @labath wrote: > Who sets this flag? How do you intend to use it? I need this change downstream to search for certain swift mangled names by querying `Module::FindSymbolsMatchingRegExAndType`. It seemed

[Lldb-commits] [PATCH] D128989: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGf8603c1f6d9e: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop (authored by mgorny). H

[Lldb-commits] [lldb] f8603c1 - [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

Author: Michał Górny Date: 2022-08-01T18:52:47+02:00 New Revision: f8603c1f6d9eb90bc6a674111bd3441458006601 URL: https://github.com/llvm/llvm-project/commit/f8603c1f6d9eb90bc6a674111bd3441458006601 DIFF: https://github.com/llvm/llvm-project/commit/f8603c1f6d9eb90bc6a674111bd3441458006601.diff

[Lldb-commits] [lldb] 0806927 - [lldb] [test] Fix test_c_both_nonstop flakiness

Author: Michał Górny Date: 2022-08-01T18:52:47+02:00 New Revision: 080692797724eefd15de00500d8d802e98230622 URL: https://github.com/llvm/llvm-project/commit/080692797724eefd15de00500d8d802e98230622 DIFF: https://github.com/llvm/llvm-project/commit/080692797724eefd15de00500d8d802e98230622.diff

[Lldb-commits] [PATCH] D128989: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

mgorny marked 2 inline comments as done. mgorny added a comment. Thanks! Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1786 +if (pid == StringExtractorGDBRemote::AllProcesses) { + for (auto &process_it : m_debugged_processes)

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. > If you find yourself needing to do extra work to work its limitations, we > should fix that algorithm instead. That makes sense. I'll work on fixing `RangeVectorData`. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:37-39 + if (m_exprs.

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny added a comment. In D128932#3690798 , @labath wrote: > Flake here: https://lab.llvm.org/buildbot/#/builders/68/builds/36967. > > Presumably the same problem that cd18e2ea3f4e87f8804a7d6661d5596ef1f07b81 >

[Lldb-commits] [lldb] b53641c - [lldb] Fix flakyness in TestProcessList

Author: Pavel Labath Date: 2022-08-01T16:05:01+02:00 New Revision: b53641cb72acae8973a16c4f5567885bd3fe85c0 URL: https://github.com/llvm/llvm-project/commit/b53641cb72acae8973a16c4f5567885bd3fe85c0 DIFF: https://github.com/llvm/llvm-project/commit/b53641cb72acae8973a16c4f5567885bd3fe85c0.diff

[Lldb-commits] [PATCH] D130899: [LLDB][RISCV] Add riscv register enums

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. As I understand it, these registers are the same across riscv32 and riscv64. So LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D130899: [LLDB][RISCV] Add riscv register enums

Emmmer created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, n

[Lldb-commits] [PATCH] D128989: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good modulo the comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1786 +if (pid == StringExtractorGDBRemote::AllPro

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

labath added inline comments. Comment at: lldb/source/Core/Module.cpp:740 + bool user_provided_name_is_mangled = + Mangled::GetManglingScheme(m_name.GetStringRef()) != + Mangled::eManglingSchemeNone; labath wrote: > I think this is overly aggressive. `

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

labath added a comment. I like how you've extracted the name construction functionality. Just one (inline) comment about the filtering. Comment at: lldb/source/Core/Module.cpp:740 + bool user_provided_name_is_mangled = + Mangled::GetManglingScheme(m_name.GetStringRef())

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

labath added a comment. Herald added a subscriber: JDevlieghere. Flake here: https://lab.llvm.org/buildbot/#/builders/68/builds/36967. Presumably the same problem that cd18e2ea3f4e87f8804a7d6661d5596ef1f07b81 fixed for TestNo

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

labath added a comment. Who sets this flag? How do you intend to use it? Comment at: lldb/include/lldb/Core/Module.h:267 + SymbolContextList &sc_list, + bool match_against_demangled = false);

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

labath added a comment. The general idea makes sense to me, although I haven't tried to understand the pdb parsing code. > (otherwise internal binary search may fail) The current search algorithm is buggy, but I think the `RangeDataVector` class has always intended to support overlapping range

[Lldb-commits] [PATCH] D130674: Accurate watchpoint hit counts redux

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This makes sense to me. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130674/new/ https://reviews.llvm.org/D130674 _

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3690274 , @nikic wrote: > Given > https://github.com/llvm/llvm-project/blob/2bb7c54621f31a957302a4deb3d25b752acb07bd/llvm/include/llvm/Support/RWMutex.h#L22-L27, > it seems like this is supposed to be supported. This i

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

nikic added a comment. In D130689#3690258 , @thieta wrote: > In D130689#3689157 , @thakis wrote: > >> Is it expected and intentional that this increases the mac deployment target >> to 10.12? > > I wasn't aware o

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3689157 , @thakis wrote: > Is it expected and intentional that this increases the mac deployment target > to 10.12? I wasn't aware of that - but I think it's expected since the check in RWMutex checks for the C++ stan