[Lldb-commits] [lldb] 7542e72 - Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-08-07T00:16:17-07:00 New Revision: 7542e72188cb05b22523cc58ea4223951399520d URL: https://github.com/llvm/llvm-project/commit/7542e72188cb05b22523cc58ea4223951399520d DIFF: https://github.com/llvm/llvm-project/commit/7542e72188cb05b22523cc58ea4223951399520d.diff L

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. This seems to have been more disruptive than expected, since an existing CMakeCache.txt can make LLVM compile in previous C++14 configuration. This seems to make some of the bots fail in a way that makes the patches making use of C++17 features seem at fault. See:

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705131 , @royjacobson wrote: > This seems to have been more disruptive than expected, since an existing > CMakeCache.txt can make LLVM compile in previous C++14 configuration. This > seems to make some of the bots fa

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

jasonmolenda added a comment. I wonder if it might be interesting to target this a bit - only start background downloading the dSYM for a Module once it has appeared in a backtrace, for instance. Any UI application on macOS etc has around 500 libraries loaded, but I believe only a few dozen of

[Lldb-commits] [lldb] e49c156 - [lldb] Dynamically generate enum names in lldbutil

Author: Dave Lee Date: 2022-08-07T12:15:51-06:00 New Revision: e49c1568b6160f9a02da3295ac0d5c684fb64201 URL: https://github.com/llvm/llvm-project/commit/e49c1568b6160f9a02da3295ac0d5c684fb64201 DIFF: https://github.com/llvm/llvm-project/commit/e49c1568b6160f9a02da3295ac0d5c684fb64201.diff LOG:

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe49c1568b616: [lldb] Dynamically generate enum names in lldbutil (

[Lldb-commits] [lldb] 87990fd - [lldb] Fix formatting in python-reference.rst

Author: Dave Lee Date: 2022-08-07T12:17:36-06:00 New Revision: 87990fd8f4ba0e87ae21c69ae0cff4921c0e2cdf URL: https://github.com/llvm/llvm-project/commit/87990fd8f4ba0e87ae21c69ae0cff4921c0e2cdf DIFF: https://github.com/llvm/llvm-project/commit/87990fd8f4ba0e87ae21c69ae0cff4921c0e2cdf.diff LOG:

[Lldb-commits] [lldb] c615e46 - [lldb] Hoist TraceOn check out of loop (NFC)

Author: Dave Lee Date: 2022-08-07T12:19:47-06:00 New Revision: c615e467dbaf5240e4f48f3536d4857ff58c7531 URL: https://github.com/llvm/llvm-project/commit/c615e467dbaf5240e4f48f3536d4857ff58c7531 DIFF: https://github.com/llvm/llvm-project/commit/c615e467dbaf5240e4f48f3536d4857ff58c7531.diff LOG:

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. In D131328#3704791 , @jasonmolenda wrote: > Interesting idea, it seems worth trying out and seeing how it works in > practice. > > My read of the llvm::ThreadPool is that this won't create an unbounded number > of threads

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 450659. JDevlieghere added a comment. Implement Jason's suggestion of delaying this until we need the unwind table for a module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/include/

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. In D130689#3705145 , @thieta wrote: > In D130689#3705131 , @royjacobson > wrote: > >> This seems to have been more disruptive than expected, since an existing >> CMakeCache.txt can m

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705236 , @royjacobson wrote: > This affects people on their work branches as well, and it's not obvious that > it's a configuration error and not a broken master. > > The CMake approach sounds cleaner to me, but I don

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 450668. kastiglione added a comment. Missed a restore of `str` variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files: lldb/bindings/interface/SBDa

[Lldb-commits] [lldb] d446d91 - [lldb] Use single-argument static_assert where applicable (NFC)

Author: Jonas Devlieghere Date: 2022-08-07T14:26:08-07:00 New Revision: d446d91aa39da6b616aacb3e036d4ff0d8905337 URL: https://github.com/llvm/llvm-project/commit/d446d91aa39da6b616aacb3e036d4ff0d8905337 DIFF: https://github.com/llvm/llvm-project/commit/d446d91aa39da6b616aacb3e036d4ff0d8905337.d

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

dyung added a comment. We are seeing an additional failure on an internal linux bot due to the change to using C++17 by default when using GNU ld: [3/7] Generating GwpAsan-x86_64-Test FAILED: projects/compiler-rt/lib/gwp_asan/tests/GwpAsan-x86_64-Test cd /home/jenkins/j/w/workspace/opens

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib updated this revision to Diff 450694. mib marked 2 inline comments as done. mib added a comment. Address @kastiglione comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 Files: lldb/examples/python/crashlog.py lldb/examples/python/

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

Jake-Egan added a comment. There is a failure on the AIX bot also: 152.827 [4302/10/270] Linking CXX executable bin/llvm-tblgen FAILED: bin/llvm-tblgen : && /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r -mcmodel=large -fPIC -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705474 , @dyung wrote: > We are seeing an additional failure on an internal linux bot due to the > change to using C++17 by default when using GNU ld: > ... > Switching between BFD ld and gold still fails (although gol

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705579 , @Jake-Egan wrote: > There is a failure on the AIX bot also: > ... > https://lab.llvm.org/buildbot/#/builders/214/builds/2707/steps/5/logs/stdio Filed an issue here: https://github.com/llvm/llvm-project/issues/