[Lldb-commits] [lldb] c38bc42 - [lldb] Use Optional::value instead of Optional::getValue (NFC)

Author: Kazu Hirata Date: 2022-08-19T21:40:48-07:00 New Revision: c38bc421b1268ca371cdbb54e470d758968ce67a URL: https://github.com/llvm/llvm-project/commit/c38bc421b1268ca371cdbb54e470d758968ce67a DIFF: https://github.com/llvm/llvm-project/commit/c38bc421b1268ca371cdbb54e470d758968ce67a.diff

[Lldb-commits] [lldb] 2b46625 - [lldb] Use Optional::transform instead of Optional::map (NFC)

Author: Kazu Hirata Date: 2022-08-19T21:40:47-07:00 New Revision: 2b4662551603d59e1d425494cd13452c42e5c366 URL: https://github.com/llvm/llvm-project/commit/2b4662551603d59e1d425494cd13452c42e5c366 DIFF: https://github.com/llvm/llvm-project/commit/2b4662551603d59e1d425494cd13452c42e5c366.diff

[Lldb-commits] [PATCH] D132271: [lldb][Test] Replace expect() with expect_expr() in TestNamespaceLookup.py

Michael137 updated this revision to Diff 454145. Michael137 added a comment. - Don't need replacement on one of the assertions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132271/new/ https://reviews.llvm.org/D132271 Files:

[Lldb-commits] [PATCH] D132271: [lldb][Test] Replace expect() with expect_expr() in TestNamespaceLookup.py

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This will be useful in preparation for some reshuffling of assertions in this

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc0b5ebf7fc8: [lldb] Support specifying a custom libcxx for the API tests (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] cc0b5eb - [lldb] Support specifying a custom libcxx for the API tests

Author: Jonas Devlieghere Date: 2022-08-19T15:20:41-07:00 New Revision: cc0b5ebf7fc8beb8fa907730e2d8f52d4c31bdc7 URL: https://github.com/llvm/llvm-project/commit/cc0b5ebf7fc8beb8fa907730e2d8f52d4c31bdc7 DIFF:

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve abandoned this revision. fdeazeve added a comment. Abandoning in favour of D132263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132257/new/ https://reviews.llvm.org/D132257

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Thanks for merging the two patches! This LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132263/new/ https://reviews.llvm.org/D132263

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

JDevlieghere created this revision. JDevlieghere added reviewers: fdeazeve, aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. D129166 was an attempt to ensure that by default we use the libc++ from the build dir

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + aprantl wrote: > JDevlieghere wrote: > > aprantl wrote: > > > JDevlieghere

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + JDevlieghere wrote: > aprantl wrote: > > JDevlieghere wrote: > > > Please

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + aprantl wrote: > JDevlieghere wrote: > > Please don't rely on

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + JDevlieghere wrote: > Please don't rely on environment variables to pass

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] =

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That looks nice and clean! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132257/new/ https://reviews.llvm.org/D132257

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve updated this revision to Diff 454073. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Fixed typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132257/new/ https://reviews.llvm.org/D132257 Files:

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When running LLDB tests with a separately built copy of libcxx, it may be necessary

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 accepted this revision. Michael137 added a comment. In D131758#3735763 , @mgorny wrote: > @aprantl, @Michael137, could you confirm that this version works correctly? `ninja check-lldb-api` runs fine with your patch CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1dc8fcf - Revert "[lldb] [gdb-remote] Include PID in vCont packets if multiprocess" - Part 2

Author: Michael Buch Date: 2022-08-19T19:31:14+01:00 New Revision: 1dc8fcff0e957ee137f59f94859a983425c1ba83 URL: https://github.com/llvm/llvm-project/commit/1dc8fcff0e957ee137f59f94859a983425c1ba83 DIFF: https://github.com/llvm/llvm-project/commit/1dc8fcff0e957ee137f59f94859a983425c1ba83.diff

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny updated this revision to Diff 454058. mgorny added a comment. @aprantl, @Michael137, could you confirm that this version works correctly? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131758/new/ https://reviews.llvm.org/D131758 Files:

[Lldb-commits] [PATCH] D132250: Revert "[lldb] [gdb-remote] Include PID in vCont packets if multiprocess"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5517401f936a: Revert [lldb] [gdb-remote] Include PID in vCont

[Lldb-commits] [lldb] 5517401 - Revert "[lldb] [gdb-remote] Include PID in vCont packets if multiprocess"

Author: Michael Buch Date: 2022-08-19T18:05:41+01:00 New Revision: 5517401f936ab5cb9db001030f027293d44aac92 URL: https://github.com/llvm/llvm-project/commit/5517401f936ab5cb9db001030f027293d44aac92 DIFF: https://github.com/llvm/llvm-project/commit/5517401f936ab5cb9db001030f027293d44aac92.diff

[Lldb-commits] [PATCH] D132250: Revert "[lldb] [gdb-remote] Include PID in vCont packets if multiprocess"

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit ccb9d4d4addc2fb2aa94cf776d43d8be35365272

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. In D131758#3735670 , @mgorny wrote: > In D131758#3735628 , @aprantl wrote: > >> In D131758#3735621 , @Michael137 >> wrote: >> >>> This seems

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. In D131758#3735670 , @mgorny wrote: > In D131758#3735628 , @aprantl wrote: > >> In D131758#3735621 , @Michael137 >> wrote: >> >>> This seems

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham added a comment. Remember, all this patch does is make a universal rule that "All zero UUID's are placeholders and not meant to be matched against." The only platforms/ObjectFile readers that weren't already following that rule were Darwin - where this was definitely just historical

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny added a comment. In D131758#3735628 , @aprantl wrote: > In D131758#3735621 , @Michael137 > wrote: > >> This seems to cause all API tests to time out. >> >> See LLDB Incremental buildbot: >>

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham added a comment. In D132191#3734014 , @clayborg wrote: > Minidump files have UUID values that are zeroed out. We will need to do > something for these that can sense all zeroes and return a default > constructed one. I'm confused. The

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

aprantl added a comment. In D131758#3735621 , @Michael137 wrote: > This seems to cause all API tests to time out. > > See LLDB Incremental buildbot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46215/execution/node/70/log/ > > Can we

[Lldb-commits] [lldb] 00c4852 - Revert "[lldb] [test] Disable new CommunicationTests on Windows"

Author: Adrian Prantl Date: 2022-08-19T09:23:17-07:00 New Revision: 00c4852561a7ea51e0514759efd745ff01137b4c URL: https://github.com/llvm/llvm-project/commit/00c4852561a7ea51e0514759efd745ff01137b4c DIFF: https://github.com/llvm/llvm-project/commit/00c4852561a7ea51e0514759efd745ff01137b4c.diff

[Lldb-commits] [lldb] fe0f72d - Revert "[lldb] [test] Add synchronization to TestContinue"

Author: Adrian Prantl Date: 2022-08-19T09:23:18-07:00 New Revision: fe0f72d5c55a9b95c5564089e946e8f08112e995 URL: https://github.com/llvm/llvm-project/commit/fe0f72d5c55a9b95c5564089e946e8f08112e995 DIFF: https://github.com/llvm/llvm-project/commit/fe0f72d5c55a9b95c5564089e946e8f08112e995.diff

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. Herald added a subscriber: JDevlieghere. This seems to cause all API tests to time out. See LLDB Incremental buildbot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46215/execution/node/70/log/ Can we revert this until we know what the root cause is?

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. @labath, what do you think of this? Also I'm wondering about error handling. Should we introduce fallible constructor for this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny updated this revision to Diff 454015. mgorny added a comment. Rebase. Replace "events" with triggering pending callbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160 Files: lldb/include/lldb/Host/MainLoopBase.h

[Lldb-commits] [lldb] d38985a - [lldb] [test] Disable new CommunicationTests on Windows

Author: Michał Górny Date: 2022-08-19T16:23:39+02:00 New Revision: d38985a36be8b0165787f8893b3d2b0f831d1e83 URL: https://github.com/llvm/llvm-project/commit/d38985a36be8b0165787f8893b3d2b0f831d1e83 DIFF: https://github.com/llvm/llvm-project/commit/d38985a36be8b0165787f8893b3d2b0f831d1e83.diff

[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

mgorny added a comment. Herald added a subscriber: JDevlieghere. @labath, any chance you could take a look at the failures on Windows? I'm wondering if this is because "pipes don't work like that on Windows" or if there's a way to make them work. For now I'm just going to skip these tests on

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 added a comment. https://reviews.llvm.org/D132231 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131974/new/ https://reviews.llvm.org/D131974 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D132231: [lldb][ClangExpression] Remove storage-class check when creating AsmLabel

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py:212 # Evaluate func() - should call static ns2.cpp:func() -# FIXME: This test fails because lldb doesn't know about

[Lldb-commits] [PATCH] D132231: [lldb][ClangExpression] Remove storage-class check when creating AsmLabel

Michael137 created this revision. Michael137 added a reviewer: labath. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This check was put in place to prevent static

[Lldb-commits] [lldb] 7aadeca - [lldb] [test] Add synchronization to TestContinue

Author: Michał Górny Date: 2022-08-19T15:49:35+02:00 New Revision: 7aadecae404b8d47aabdd874e9018a76fd4d1ffa URL: https://github.com/llvm/llvm-project/commit/7aadecae404b8d47aabdd874e9018a76fd4d1ffa DIFF: https://github.com/llvm/llvm-project/commit/7aadecae404b8d47aabdd874e9018a76fd4d1ffa.diff

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath added a comment. In D131160#3735024 , @mgorny wrote: > Ok, so I'm going to give it a shot today. Could you clarify one thing though? > >> All it would take is to add some locking around the PendingCallback >> manipulations > > Are you thinking of

[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6e1e01da949: [lldb] [Core] Harmonize Communication::Read() returns w/ thread (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d6e1e01 - [lldb] [Core] Harmonize Communication::Read() returns w/ thread

Author: Michał Górny Date: 2022-08-19T15:36:03+02:00 New Revision: d6e1e01da949c8cb4b869cee1953cf19a6d072c0 URL: https://github.com/llvm/llvm-project/commit/d6e1e01da949c8cb4b869cee1953cf19a6d072c0 DIFF: https://github.com/llvm/llvm-project/commit/d6e1e01da949c8cb4b869cee1953cf19a6d072c0.diff

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 added a comment. In D131974#3734849 , @labath wrote: > In D131974#3733024 , @Michael137 > wrote: > >> In D131974#3732727 , @labath wrote: >> >>> Any

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny marked an inline comment as done. mgorny added a comment. Ok, so I'm going to give it a shot today. Could you clarify one thing though? > All it would take is to add some locking around the PendingCallback > manipulations Are you thinking of locking directly in `MainLoop` classes, or in

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

labath added a comment. In D131437#3710203 , @clayborg wrote: > In D131437#3709921 , @labath wrote: > >> Seems reasonable, but could use a test case, though I'm not sure what would >> be the best way to approach

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

labath added a comment. In D131974#3733024 , @Michael137 wrote: > In D131974#3732727 , @labath wrote: > >> Any particular reason for not removing the `SC_Extern` check? I'm pretty >> sure I could create a test

[Lldb-commits] [PATCH] D131335: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

labath added a comment. In D131335#3733117 , @Michael137 wrote: > In D131335#3732877 , @labath wrote: > >> FWIW, I would be all for attaching the abi tags to the clang declarations if >> they would be in some

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGc74c17f37aa9: [lldb] Use WSAEventSelect for MainLoop polling on windows (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131159/new/

[Lldb-commits] [lldb] c74c17f - [lldb] Use WSAEventSelect for MainLoop polling on windows

Author: Pavel Labath Date: 2022-08-19T13:25:25+02:00 New Revision: c74c17f37aa9360492675e2aae3de99539eaf465 URL: https://github.com/llvm/llvm-project/commit/c74c17f37aa9360492675e2aae3de99539eaf465 DIFF: https://github.com/llvm/llvm-project/commit/c74c17f37aa9360492675e2aae3de99539eaf465.diff

[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

mgorny updated this revision to Diff 453950. mgorny added a comment. Use a common test function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132217/new/ https://reviews.llvm.org/D132217 Files: lldb/source/Core/Communication.cpp lldb/unittests/Core/CommunicationTest.cpp Index:

[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

mgorny added a comment. In D132217#3734749 , @labath wrote: > Cool stuff. Would it be possible to test for the two paths into a single > function (with some `if`s, if necessary)? That would make it clearer what (if > any) are the differences between

[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

labath added a comment. Cool stuff. Would it be possible to test for the two paths into a single function (with some `if`s, if necessary)? That would make it clearer what (if any) are the differences between the two modes of operation. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added subscribers: kristof.beyls, arichardson. Herald added a project: All. mgorny requested review of this revision. Harmonize the status and error values of Communication::Read() when running with

[Lldb-commits] [PATCH] D131837: [lldb] [gdb-remote] Initial support for multiple ContinueDelegates

labath added a comment. In D131837#3734204 , @mgorny wrote: > In D131837#3732971 , @labath wrote: > >> This sort of makes sense to me, but it's not clear to me how is this >> selection logic going to apply to

Re: [Lldb-commits] [lldb] 5815708 - [lldb] [test] Skip step packet test on non-amd64

On 19/08/2022 09:48, Michał Górny via lldb-commits wrote: Author: Michał Górny Date: 2022-08-19T09:48:13+02:00 New Revision: 58157087b0a4fefeabd4cf6e4ee356d6152fd5a6 URL: https://github.com/llvm/llvm-project/commit/58157087b0a4fefeabd4cf6e4ee356d6152fd5a6 DIFF:

[Lldb-commits] [lldb] 8b50ffe - [lldb] [test] Remove test_step_multiprocess, it's unreliable

Author: Michał Górny Date: 2022-08-19T10:08:11+02:00 New Revision: 8b50ffe9fdc3cd457796857d3661e34490ef0490 URL: https://github.com/llvm/llvm-project/commit/8b50ffe9fdc3cd457796857d3661e34490ef0490 DIFF: https://github.com/llvm/llvm-project/commit/8b50ffe9fdc3cd457796857d3661e34490ef0490.diff

[Lldb-commits] [lldb] 5815708 - [lldb] [test] Skip step packet test on non-amd64

Author: Michał Górny Date: 2022-08-19T09:48:13+02:00 New Revision: 58157087b0a4fefeabd4cf6e4ee356d6152fd5a6 URL: https://github.com/llvm/llvm-project/commit/58157087b0a4fefeabd4cf6e4ee356d6152fd5a6 DIFF: https://github.com/llvm/llvm-project/commit/58157087b0a4fefeabd4cf6e4ee356d6152fd5a6.diff

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

This revision was automatically updated to reflect the committed changes. mgorny marked 2 inline comments as done. Closed by commit rGccb9d4d4addc: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] ccb9d4d - [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Author: Michał Górny Date: 2022-08-19T09:02:20+02:00 New Revision: ccb9d4d4addc2fb2aa94cf776d43d8be35365272 URL: https://github.com/llvm/llvm-project/commit/ccb9d4d4addc2fb2aa94cf776d43d8be35365272 DIFF: https://github.com/llvm/llvm-project/commit/ccb9d4d4addc2fb2aa94cf776d43d8be35365272.diff

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1189-1192 + std::string pid_prefix; + if (GetID() != LLDB_INVALID_PROCESS_ID && +

[Lldb-commits] [PATCH] D131837: [lldb] [gdb-remote] Initial support for multiple ContinueDelegates

mgorny added a comment. In D131837#3732971 , @labath wrote: > This sort of makes sense to me, but it's not clear to me how is this > selection logic going to apply to packets other than stop-replies. All of the > forked processes are going to share the