[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

Michael137 added a comment. In D131758#3736793 , @mgorny wrote: > @aprantl, why did you revert d38985a36be8b0165787f8893b3d2b0f831d1e83 > ? This > change had nothing to do with this pa

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Use MainLoop to implement Communication::ReadThread() instead of blocking reads. Most importan

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

mgorny planned changes to this revision. mgorny added a comment. Unfortunately, many tests are failing or timing out, so need to investigate more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132283/new/ https://reviews.llvm.org/D132283 ___

[Lldb-commits] [lldb] 347c462 - [lldb] Use Any::has_value instead of ANy::hasValue (NFC)

Author: Kazu Hirata Date: 2022-08-20T07:28:06-07:00 New Revision: 347c462e97bbb22ef9d95ef2f161e2eb82843f8e URL: https://github.com/llvm/llvm-project/commit/347c462e97bbb22ef9d95ef2f161e2eb82843f8e DIFF: https://github.com/llvm/llvm-project/commit/347c462e97bbb22ef9d95ef2f161e2eb82843f8e.diff L

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 created this revision. Ericson2314 added a reviewer: sebastian-ne. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, MaskRay. Herald added projects: clang, LLD

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3adda398cef7: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASEN

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. `D130586` was approved; this is a subset; this had no test failures, so I just went ahead and landed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 _

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. I fixed up the gn build after this in 804d4594cbe217ae817b6786b0e9965283f78aa2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. (ie if you revert that, it'd be appreciated if you could revert that in the same commit) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 __

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, jingham, mib, aprantl. Herald added a subscriber: mgorny. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use `std::regex

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione added inline comments. Comment at: lldb/source/Utility/CMakeLists.txt:29 + PROPERTIES COMPILE_OPTIONS + "-fcxx-exceptions" +) the `std::regex` constructor throws `std::regex_error` if the pattern is invalid. For this reason, exceptions are enabled

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. OK Thanks @thakis --- I was confused why the last GN fixup added but didn't remove lines. That clears it up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 _

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/RegularExpression.h:92 + std::regex m_regex; + std::optional m_regex_error; }; There's an ongoing discussion on the forums [1] to replace `llvm::Optional` with `std::optional`. Until th

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione added inline comments. Comment at: lldb/include/lldb/Utility/RegularExpression.h:92 + std::regex m_regex; + std::optional m_regex_error; }; JDevlieghere wrote: > There's an ongoing discussion on the forums [1] to replace `llvm::Optional` > with `s

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione updated this revision to Diff 454247. kastiglione added a comment. Switch to llvm::Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132307/new/ https://reviews.llvm.org/D132307 Files: lldb/include/lldb/Utility/RegularExpression

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione added inline comments. Comment at: lldb/source/Utility/CMakeLists.txt:29 + PROPERTIES COMPILE_OPTIONS + "-fcxx-exceptions" +) kastiglione wrote: > JDevlieghere wrote: > > kastiglione wrote: > > > the `std::regex` constructor throws `std::regex_error

[Lldb-commits] [lldb] ce377df - Ensure newlines at the end of files (NFC)

Author: Kazu Hirata Date: 2022-08-20T21:18:23-07:00 New Revision: ce377df57ee5c72f05f2d60d4850de01a5456685 URL: https://github.com/llvm/llvm-project/commit/ce377df57ee5c72f05f2d60d4850de01a5456685 DIFF: https://github.com/llvm/llvm-project/commit/ce377df57ee5c72f05f2d60d4850de01a5456685.diff L