[Lldb-commits] [lldb] 118038e - [lldb] Use the NativeSock type instead of plain 'int'

2022-08-30 Thread Martin Storsjö via lldb-commits
Author: Martin Storsjö Date: 2022-08-30T10:07:44+03:00 New Revision: 118038e878cf7c169c74cdf31de019913775e881 URL: https://github.com/llvm/llvm-project/commit/118038e878cf7c169c74cdf31de019913775e881 DIFF: https://github.com/llvm/llvm-project/commit/118038e878cf7c169c74cdf31de019913775e881.diff

[Lldb-commits] [PATCH] D132841: [lldb] Use the NativeSock type instead of plain 'int'

2022-08-30 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG118038e878cf: [lldb] Use the NativeSock type instead of plain 'int' (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132841/new/ https:

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

2022-08-30 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit improves upon cc0b5ebf7fc8 , which adde

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

2022-08-30 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve updated this revision to Diff 456652. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Improved error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 Files: lldb/packa

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

2022-08-30 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
fdeazeve added a comment. This patch should finally enable us to fix the LLDB bots using older versions of Clang: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://r

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

2022-08-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I don't think this will work in general, as the modules feature requires all your dependencies to be modularized, and linux systems generally don't have that. You might be able to do a feature like "build no_debug_info tests with modules if the platform supports it" and

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

2022-08-30 Thread David M. Lary via Phabricator via lldb-commits
dmlary created this revision. dmlary added a reviewer: LLDB. dmlary added a project: LLDB. Herald added subscribers: JDevlieghere, emaste. Herald added a project: All. dmlary requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. I encountered an issue where `p &variab

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

2022-08-30 Thread David M. Lary via Phabricator via lldb-commits
dmlary added a comment. I'm looking for any suggestions of how to test this. I can create a simple object file with the needed relocation types, but I don't see an easy way to get lldb to apply those relocations (in .`.text` for example). I wanted to see if that was possible before making a fa

[Lldb-commits] [lldb] 5ad6ed0 - Change the meaning of a UUID with all zeros for data.

2022-08-30 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2022-08-30T10:17:58-07:00 New Revision: 5ad6ed0e5519ed26442cd0a21cdb07f5c53b854e URL: https://github.com/llvm/llvm-project/commit/5ad6ed0e5519ed26442cd0a21cdb07f5c53b854e DIFF: https://github.com/llvm/llvm-project/commit/5ad6ed0e5519ed26442cd0a21cdb07f5c53b854e.diff LO

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

2022-08-30 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad6ed0e5519: Change the meaning of a UUID with all zeros for data. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132191/new/ https:/

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

2022-08-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 ___

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

2022-08-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D132868#3758826 , @labath wrote: > I don't think this will work in general, as the modules feature requires all > your dependencies to be modularized, and linux systems generally don't have > that. You might be able to d

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

2022-08-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a reviewer: ributzka. Herald added a project: All. JDevlieghere requested review of this revision. Jason caught two issues in the memory part of ObjectContainerMachOFileset which I didn't hook up and the

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

2022-08-30 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132973/new/ https://reviews.llvm.org/D132973 ___ lldb-commits mai

[Lldb-commits] [lldb] 0044cb4 - [lldb] Fix two bugs in ObjectContainerMachOFileset

2022-08-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-08-30T14:07:20-07:00 New Revision: 0044cb4b2037827dd9a9318c7333eb40062c4ac3 URL: https://github.com/llvm/llvm-project/commit/0044cb4b2037827dd9a9318c7333eb40062c4ac3 DIFF: https://github.com/llvm/llvm-project/commit/0044cb4b2037827dd9a9318c7333eb40062c4ac3.d

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

2022-08-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0044cb4b2037: [lldb] Fix two bugs in ObjectContainerMachOFileset (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

2022-08-30 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. There are a number of Makefiles that use `MANDATORY_MODULE_BUILD_CFLAGS` unconditionally. Given the points made here, how do those test work on linux? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://r