[Lldb-commits] [PATCH] D134518: [lldb][COFF] Skip forwarder export symbols in symtab

alvinhochun created this revision. alvinhochun added reviewers: labath, DavidSpickett, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Forwarder exports do not point to a real function or v

[Lldb-commits] [PATCH] D134517: [lldb][COFF] Load absolute symbols from COFF symbol table

alvinhochun created this revision. alvinhochun added reviewers: labath, DavidSpickett, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D134426

[Lldb-commits] [PATCH] D134516: [lldb] Improve display of absolute symbol lookup

alvinhochun created this revision. alvinhochun added reviewers: labath, clayborg. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When running `target module lookup` command, show the name of absolut

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

kastiglione created this revision. kastiglione added reviewers: mib, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some time ago, a refactor (1153dc960) broke completion for assigning

[Lldb-commits] [PATCH] D134509: [LLDB][NativePDB] Let native pdb use class layout in debug info.

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Before, class layout in native pdb is not hooked up in here

[Lldb-commits] [PATCH] D134508: Track which modules have debug info variable errors.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Now that we display an error when users try to get variables,

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

Michael137 added a comment. Wasn't sure how to properly test this since the original reproducer technically relies on implementation-defined behaviour (i.e., initialising a bitfield with an out-of-range value). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The motivating issue was the following: $ cat main.cpp enum class E

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seems fine if Pavel is happy with it. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:249 def __init__(self, name=None, value=None, type=None, summary=None

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5073ed5f929: Add auto source map deduce count statistics (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134483/new/ https://review

[Lldb-commits] [lldb] c5073ed - Add auto source map deduce count statistics

Author: Jeffrey Tan Date: 2022-09-22T14:52:58-07:00 New Revision: c5073ed5f92900bbbe9f6a30bbfc9507df54749d URL: https://github.com/llvm/llvm-project/commit/c5073ed5f92900bbbe9f6a30bbfc9507df54749d DIFF: https://github.com/llvm/llvm-project/commit/c5073ed5f92900bbbe9f6a30bbfc9507df54749d.diff L

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

yinghuitan updated this revision to Diff 462298. yinghuitan added a comment. rebase and trigger linter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134483/new/ https://reviews.llvm.org/D134483 Files: lldb/include/lldb/Target/PathMappingList.h

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds auto

[Lldb-commits] [lldb] ccb47b4 - Track .dwo/.dwp loading errors and notify user when viewing variables.

Author: Greg Clayton Date: 2022-09-22T11:35:20-07:00 New Revision: ccb47b41e4936d1d44dfbaf5aac028280c216932 URL: https://github.com/llvm/llvm-project/commit/ccb47b41e4936d1d44dfbaf5aac028280c216932 DIFF: https://github.com/llvm/llvm-project/commit/ccb47b41e4936d1d44dfbaf5aac028280c216932.diff

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccb47b41e493: Track .dwo/.dwp loading errors and notify user when viewing variables. (authored by clayborg). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. I'd like to block this on `-fsanitize-memory-param-retval` (aka msan eager checks) being enabled by default. It seems pretty clear that there is a *lot* of UB due to uninitialized para

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 462249. aeubanks added a comment. extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 Files: clang/test/CodeGenOpenCL/overload.cl lldb/test/API/function

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 462247. aeubanks added a comment. add flag to disable (to be removed in the future) "fix" lldb test skip on msan instrumented functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 462245. aeubanks added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. "fix" lldb test (hopefully) skip when msan add flag to disable (to be removed in the future) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

alvinhochun added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1551-1556 + strm.Indent("Value: "); + strm.Printf("0x%16.16" PRIx64 "\n", symbol->GetRawValue()); + if (symbol->GetByteSizeIsValid()) { +strm.Ind

[Lldb-commits] [PATCH] D134426: [lldb][COFF] Match symbols from COFF symbol table to export symbols

alvinhochun created this revision. alvinhochun added reviewers: labath, DavidSpickett, mstorsjo. Herald added a subscriber: mgrang. Herald added a project: All. alvinhochun published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If a symbol is the

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett added a comment. FWIW the intent of the change was always clear but writing a test for it is always going to be fiddly. My usual mindset is "what if this fails out of the blue", so I'm always asking for more comments :) . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Test is certainly clearer. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130534/new/ https://reviews.llvm.org/D130534 _