[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

labath added inline comments. Comment at: lldb/include/lldb/DataFormatters/TypeCategory.h:136 + void ForEach(std::function)> + callback) { did you want to add a reference here? A const by-value argument is not particularly useful. ==

[Lldb-commits] [PATCH] D134768: [NFCI] More TypeCategoryImpl refactoring.

labath added a comment. FWIW, phabricator allows you to create stacked patches. Just base your diff on top of the previous patch, and then list that patch as a "parent revision" for the new one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134768

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun updated this revision to Diff 463458. alvinhochun added a comment. Updated the patch to be standalone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134636/new/ https://reviews.llvm.org/D134636 Files: lldb/source/Plugins/Process/Wind

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun updated this revision to Diff 463459. alvinhochun edited the summary of this revision. alvinhochun added a comment. Actually update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134636/new/ https://reviews.llvm.org/D13463

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:6-9 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll \ +# RUN: %if windows-msvc %{-Wl,-implib:%t.shlib.lib%} \ +# RUN: %else %{

[Lldb-commits] [lldb] bf0cda9 - [lldb][COFF] Rewrite ParseSymtab to list both export and symbol tables

Author: Alvin Wong Date: 2022-09-28T12:57:10+03:00 New Revision: bf0cda9ed2783a34efed3fc9804d784f7d1df242 URL: https://github.com/llvm/llvm-project/commit/bf0cda9ed2783a34efed3fc9804d784f7d1df242 DIFF: https://github.com/llvm/llvm-project/commit/bf0cda9ed2783a34efed3fc9804d784f7d1df242.diff LO

[Lldb-commits] [lldb] 0870afc - [lldb][COFF] Improve info of symbols from export table

Author: Alvin Wong Date: 2022-09-28T12:57:10+03:00 New Revision: 0870afc68e1a1ec303af1d0dbf952dd2c41f478a URL: https://github.com/llvm/llvm-project/commit/0870afc68e1a1ec303af1d0dbf952dd2c41f478a DIFF: https://github.com/llvm/llvm-project/commit/0870afc68e1a1ec303af1d0dbf952dd2c41f478a.diff LO

[Lldb-commits] [lldb] 20c2f94 - [lldb][COFF] Match symbols from COFF symbol table to export symbols

Author: Alvin Wong Date: 2022-09-28T12:57:11+03:00 New Revision: 20c2f94c3cc10c41ab45e1be156540a06306cdf1 URL: https://github.com/llvm/llvm-project/commit/20c2f94c3cc10c41ab45e1be156540a06306cdf1 DIFF: https://github.com/llvm/llvm-project/commit/20c2f94c3cc10c41ab45e1be156540a06306cdf1.diff LO

[Lldb-commits] [lldb] 7ebff6a - [lldb][COFF] Load absolute symbols from COFF symbol table

Author: Alvin Wong Date: 2022-09-28T12:57:11+03:00 New Revision: 7ebff6ab26aa03423c61e0370377f11725184199 URL: https://github.com/llvm/llvm-project/commit/7ebff6ab26aa03423c61e0370377f11725184199 DIFF: https://github.com/llvm/llvm-project/commit/7ebff6ab26aa03423c61e0370377f11725184199.diff LO

[Lldb-commits] [lldb] acf7d08 - [lldb][COFF] Add note to forwarder export symbols in symtab

Author: Alvin Wong Date: 2022-09-28T12:57:11+03:00 New Revision: acf7d081198f380d6ad2a1b859930e50a9cf2dae URL: https://github.com/llvm/llvm-project/commit/acf7d081198f380d6ad2a1b859930e50a9cf2dae DIFF: https://github.com/llvm/llvm-project/commit/acf7d081198f380d6ad2a1b859930e50a9cf2dae.diff LO

[Lldb-commits] [lldb] 8a67a05 - [lldb][COFF] Map symbols without base+complex type as 'Data' type

Author: Alvin Wong Date: 2022-09-28T12:57:12+03:00 New Revision: 8a67a05e93349e341d1325f1a6428d1373f77177 URL: https://github.com/llvm/llvm-project/commit/8a67a05e93349e341d1325f1a6428d1373f77177 DIFF: https://github.com/llvm/llvm-project/commit/8a67a05e93349e341d1325f1a6428d1373f77177.diff LO

[Lldb-commits] [PATCH] D134196: [lldb][COFF] Rewrite ParseSymtab to list both export and symbol tables

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf0cda9ed278: [lldb][COFF] Rewrite ParseSymtab to list both export and symbol tables (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D134265: [lldb][COFF] Improve info of symbols from export table

This revision was automatically updated to reflect the committed changes. Closed by commit rG0870afc68e1a: [lldb][COFF] Improve info of symbols from export table (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D134426: [lldb][COFF] Match symbols from COFF symbol table to export symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG20c2f94c3cc1: [lldb][COFF] Match symbols from COFF symbol table to export symbols (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D134517: [lldb][COFF] Load absolute symbols from COFF symbol table

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ebff6ab26aa: [lldb][COFF] Load absolute symbols from COFF symbol table (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D134518: [lldb][COFF] Add note to forwarder export symbols in symtab

This revision was automatically updated to reflect the committed changes. Closed by commit rGacf7d081198f: [lldb][COFF] Add note to forwarder export symbols in symtab (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a67a05e9334: [lldb][COFF] Map symbols without base+complex type as 'Data' type (authored by alvinhochun, committed by mstorsjo). Repository: rG L

[Lldb-commits] [lldb] 247714f - [LLDB] Move MIPS64/PPC64 and misc. to optional GetRegisterInfo

Author: David Spickett Date: 2022-09-28T10:36:31Z New Revision: 247714f0a6307307ac9a972d4828cfb5f8b45f4b URL: https://github.com/llvm/llvm-project/commit/247714f0a6307307ac9a972d4828cfb5f8b45f4b DIFF: https://github.com/llvm/llvm-project/commit/247714f0a6307307ac9a972d4828cfb5f8b45f4b.diff LOG

[Lldb-commits] [PATCH] D134537: [LLDB] Move MIPS64/PPC64 and misc. to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG247714f0a630: [LLDB] Move MIPS64/PPC64 and misc. to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13453

[Lldb-commits] [PATCH] D134538: [LLDB][ARM] Move instruction emulation to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a339b3aeba7: [LLDB][ARM] Move instruction emulation to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] 0a339b3 - [LLDB][ARM] Move instruction emulation to optional GetRegisterInfo

Author: David Spickett Date: 2022-09-28T10:53:22Z New Revision: 0a339b3aeba77e94bc4ec8637df147e874a7e685 URL: https://github.com/llvm/llvm-project/commit/0a339b3aeba77e94bc4ec8637df147e874a7e685 DIFF: https://github.com/llvm/llvm-project/commit/0a339b3aeba77e94bc4ec8637df147e874a7e685.diff LOG

[Lldb-commits] [lldb] ebe7160 - [LLDB][MIPS] Move instruction emulation to optional GetRegisterInfo

Author: David Spickett Date: 2022-09-28T10:59:47Z New Revision: ebe71605fa8964e176a9c334d404e901fff6a5ed URL: https://github.com/llvm/llvm-project/commit/ebe71605fa8964e176a9c334d404e901fff6a5ed DIFF: https://github.com/llvm/llvm-project/commit/ebe71605fa8964e176a9c334d404e901fff6a5ed.diff LOG

[Lldb-commits] [PATCH] D134539: [LLDB][MIPS] Move instruction emulation to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGebe71605fa89: [LLDB][MIPS] Move instruction emulation to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] c87f1f5 - [LLDB][AArch64] Move instruction emulation to optional GetRegisterInfo

Author: David Spickett Date: 2022-09-28T12:26:50Z New Revision: c87f1f5bfbf68e41719130da84b47da48d71f50f URL: https://github.com/llvm/llvm-project/commit/c87f1f5bfbf68e41719130da84b47da48d71f50f DIFF: https://github.com/llvm/llvm-project/commit/c87f1f5bfbf68e41719130da84b47da48d71f50f.diff LOG

[Lldb-commits] [PATCH] D134540: [LLDB][AArch64] Move instruction emulation to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGc87f1f5bfbf6: [LLDB][AArch64] Move instruction emulation to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D134541: [LLDB] Remove the bool + RegisterInfo& version of GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c1a3da8ea1f: [LLDB] Remove the bool + RegisterInfo& version of GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [lldb] 0c1a3da - [LLDB] Remove the bool + RegisterInfo& version of GetRegisterInfo

Author: David Spickett Date: 2022-09-28T12:30:34Z New Revision: 0c1a3da8ea1f0e024ebfd85c7532926f26c6bde5 URL: https://github.com/llvm/llvm-project/commit/0c1a3da8ea1f0e024ebfd85c7532926f26c6bde5 DIFF: https://github.com/llvm/llvm-project/commit/0c1a3da8ea1f0e024ebfd85c7532926f26c6bde5.diff LOG

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

werat added a comment. In D134493#3819710 , @shafik wrote: > Note, in both C and C++ converting a `-1` to unsigned will always result in > the max unsigned value e.g.: When you convert to "unsigned" then yeah, but here the API is `uint64_t GetAsUnsig

[Lldb-commits] [lldb] c598396 - Speculatively fix the lldb build

Author: Aaron Ballman Date: 2022-09-28T13:39:48-04:00 New Revision: c5983963de7a6fb4dce0c7232905cc66c7b52030 URL: https://github.com/llvm/llvm-project/commit/c5983963de7a6fb4dce0c7232905cc66c7b52030 DIFF: https://github.com/llvm/llvm-project/commit/c5983963de7a6fb4dce0c7232905cc66c7b52030.diff

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

jgorbe updated this revision to Diff 463624. jgorbe added a comment. Fixed callback argument type (from `const std::shared_ptr` to `const std::shared_ptr &`) as suggested by reviewer. Also use a range-based for loop to loop over subcontainers in `TieredFormattercontainer::ForEach`. CHANGES SI

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/include/lldb/DataFormatters/TypeCategory.h:136 + void ForEach(std::function)> + callback) { labath wrote: > did you want to add a reference here? A const by

[Lldb-commits] [lldb] 15f83ab - When there are variable errors, display an error in VS Code's local variables view.

Author: Greg Clayton Date: 2022-09-28T15:38:02-07:00 New Revision: 15f83ab77502cb2bd405a091cf419536e1d41381 URL: https://github.com/llvm/llvm-project/commit/15f83ab77502cb2bd405a091cf419536e1d41381 DIFF: https://github.com/llvm/llvm-project/commit/15f83ab77502cb2bd405a091cf419536e1d41381.diff

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15f83ab77502: When there are variable errors, display an error in VS Code's local variables… (authored by clayborg). Changed prior to commit: https://reviews.llvm.org/D134333?vs=463102&id=463686#toc Re

[Lldb-commits] [lldb] 8f89351 - Track which modules have debug info variable errors.

Author: Greg Clayton Date: 2022-09-28T15:39:54-07:00 New Revision: 8f8935139adf44584634d4bacd35e3eee3f648a5 URL: https://github.com/llvm/llvm-project/commit/8f8935139adf44584634d4bacd35e3eee3f648a5 DIFF: https://github.com/llvm/llvm-project/commit/8f8935139adf44584634d4bacd35e3eee3f648a5.diff

[Lldb-commits] [PATCH] D134508: Track which modules have debug info variable errors.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f8935139adf: Track which modules have debug info variable errors. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134508/new/ https:/

[Lldb-commits] [PATCH] D134508: Track which modules have debug info variable errors.

clayborg added a comment. I can do a follow up patch that enumerates the errors in the statistics if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134508/new/ https://reviews.llvm.org/D134508 __

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

clayborg accepted this revision. clayborg added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

thakis added a comment. This breaks building everywhere: http://45.33.8.238/linux/87654/step_4.txt http://45.33.8.238/macm1/45381/step_4.txt http://45.33.8.238/win/67047/step_4.txt ../../lldb/tools/lldb-vscode/lldb-vscode.cpp(2963,7): error: unknown type name 'SBError'; did you mean 'lldb::SBE

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Prior to this fix, no shared libraries would be loaded for a c

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

clayborg added a comment. All current post mortem tests pass with this fix. Not sure how to test this stuff since if a core files have hard coded paths in the rendezvous structures in memory and it isn't possible to make a small core file that contains the right paths. Repository: rG LLVM G

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

thakis added a comment. Reverted in dcb94010eb8f0110c593a41e90b01365b45795e6 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333 ___ lldb-commits mailing l

[Lldb-commits] [lldb] dcb9401 - Revert "When there are variable errors, display an error in VS Code's local variables view."

Author: Nico Weber Date: 2022-09-28T20:07:14-04:00 New Revision: dcb94010eb8f0110c593a41e90b01365b45795e6 URL: https://github.com/llvm/llvm-project/commit/dcb94010eb8f0110c593a41e90b01365b45795e6 DIFF: https://github.com/llvm/llvm-project/commit/dcb94010eb8f0110c593a41e90b01365b45795e6.diff LO

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

clayborg reopened this revision. clayborg added a comment. This revision is now accepted and ready to land. reopening to fix simple namespace issue... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333 _

[Lldb-commits] [lldb] faaff2c - [lldb] Fix deprecation warnings for hasValue and getValue in mac-only code paths

Author: Nico Weber Date: 2022-09-28T20:12:32-04:00 New Revision: faaff2cdceac49d2e7c719fe994c5eee343ec818 URL: https://github.com/llvm/llvm-project/commit/faaff2cdceac49d2e7c719fe994c5eee343ec818 DIFF: https://github.com/llvm/llvm-project/commit/faaff2cdceac49d2e7c719fe994c5eee343ec818.diff LO

[Lldb-commits] [PATCH] D134844: [lldb] Fix deprecation warning for using std::iterator

thakis created this revision. thakis added a reviewer: labath. Herald added a project: All. thakis requested review of this revision. std::iterator was deprecated in C++17. https://reviews.llvm.org/D134844 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp Index: lldb/source/Plugins/S

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

clayborg updated this revision to Diff 463724. clayborg added a comment. Added needed lldb:: namespace on the SBError. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333 Files: lldb/test/API/tools/lldb-vsc

[Lldb-commits] [PATCH] D134846: [NFC] Add header documentation to the SBError::GetCString() to clarify ownwership of the returned string.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, yinghuitan. Herald added a subscriber: yaxunl. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Title says it all!

[Lldb-commits] [lldb] 34f3e57 - Include before using std::pow()

Author: Jason Molenda Date: 2022-09-28T17:35:35-07:00 New Revision: 34f3e576806bc91f7ebf3da43cf9c1cbc18c0ba2 URL: https://github.com/llvm/llvm-project/commit/34f3e576806bc91f7ebf3da43cf9c1cbc18c0ba2 DIFF: https://github.com/llvm/llvm-project/commit/34f3e576806bc91f7ebf3da43cf9c1cbc18c0ba2.diff

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously, lldb mistook fields in anonymous union in a struct as the direct field

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. I think @labath or anyone owns the ELF coredump debugging should take a look. I am surprised other major companies did not hit this issue. Otherwise, LGTM Repository: rG LLVM Githu