[Lldb-commits] [PATCH] D134877: [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

This revision was automatically updated to reflect the committed changes. Closed by commit rG81fc5f7909a4: [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] 81fc5f7 - [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

Author: serge-sans-paille Date: 2022-09-30T09:05:17+02:00 New Revision: 81fc5f7909a4ef5a8d4b5da2a10f77f7cb01ba63 URL: https://github.com/llvm/llvm-project/commit/81fc5f7909a4ef5a8d4b5da2a10f77f7cb01ba63 DIFF: https://github.com/llvm/llvm-project/commit/81fc5f7909a4ef5a8d4b5da2a10f77f7cb01ba63.d

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

DavidSpickett updated this revision to Diff 464185. DavidSpickett added a comment. - Add "frame select" and short "f" version on the lldb side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134873/new/ https://reviews.llvm.org/D134873 Files: lld

[Lldb-commits] [lldb] fe17e02 - [lldb][Windows] Always call SetExecutableModule on debugger connected

Author: Alvin Wong Date: 2022-09-30T13:51:56+03:00 New Revision: fe17e026959cc263c12fafa3a8e9e83503f9a18b URL: https://github.com/llvm/llvm-project/commit/fe17e026959cc263c12fafa3a8e9e83503f9a18b DIFF: https://github.com/llvm/llvm-project/commit/fe17e026959cc263c12fafa3a8e9e83503f9a18b.diff LO

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe17e026959c: [lldb][Windows] Always call SetExecutableModule on debugger connected (authored by alvinhochun, committed by mstorsjo). Repository:

[Lldb-commits] [PATCH] D134906: Have MemoryCache cache addresses that were unreadable, so duplicate read attempts can be suppressed

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Seems like a valid thing to do. Is it a problem that maybe you read from address N to N+100 and the problem address is actually at N+50, not N? I think you might be handling that already but I didn't read all the logi

[Lldb-commits] [PATCH] D134873: [LLDB] Add "frame select" as equivalent of GDB's "frame" command

DavidSpickett added a comment. Thanks for the suggestion @jingham , does this look good to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134873/new/ https://reviews.llvm.org/D134873 ___ lldb-commits

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG14642dc7405e: [lldb] Fix member access in GetExpressionPath (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/n

[Lldb-commits] [lldb] 14642dc - [lldb] Fix member access in GetExpressionPath

Author: Tonko Sabolčec Date: 2022-09-30T11:25:07Z New Revision: 14642dc7405ebd93a46dda1f2dba616395660715 URL: https://github.com/llvm/llvm-project/commit/14642dc7405ebd93a46dda1f2dba616395660715 DIFF: https://github.com/llvm/llvm-project/commit/14642dc7405ebd93a46dda1f2dba616395660715.diff LOG

[Lldb-commits] [lldb] f0a25fe - [lldb] Fix 'error: non-const lvalue...' caused by SWIG 4.1.0

Author: Jitka Plesnikova Date: 2022-09-30T14:37:29+02:00 New Revision: f0a25fe0b746f56295d5c02116ba28d2f965c175 URL: https://github.com/llvm/llvm-project/commit/f0a25fe0b746f56295d5c02116ba28d2f965c175 DIFF: https://github.com/llvm/llvm-project/commit/f0a25fe0b746f56295d5c02116ba28d2f965c175.di

[Lldb-commits] [PATCH] D134962: [LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ReadRegister and ReadRegisterAsUnsigned are always passed valid poi

[Lldb-commits] [PATCH] D134963: [LLDB] Switch to RegisterInfo& for EmulateInstruction::WriteRegister

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. WriteRegister and WriteRegisterUnsigned were never pased nullptr, a

[Lldb-commits] [lldb] a314a36 - [lldb] Fix deprecation warning for using std::iterator

Author: Nico Weber Date: 2022-09-30T10:19:08-04:00 New Revision: a314a36aaa1d3bb27a2102820ff636f7cd0940eb URL: https://github.com/llvm/llvm-project/commit/a314a36aaa1d3bb27a2102820ff636f7cd0940eb DIFF: https://github.com/llvm/llvm-project/commit/a314a36aaa1d3bb27a2102820ff636f7cd0940eb.diff LO

[Lldb-commits] [PATCH] D134844: [lldb] Fix deprecation warning for using std::iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa314a36aaa1d: [lldb] Fix deprecation warning for using std::iterator (authored by thakis). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

lldb-commits@lists.llvm.org

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27, kbarton, nemanjai, sdardis. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Most of the paths to this never passed

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

mib added a comment. Hi @tonkosi! I think your patch broke the macOS bot: https://green.lab.llvm.org/green/job/lldb-cmake/47258/console Failed Tests (5): lldb-api :: commands/frame/diagnose/array/TestArray.py lldb-api :: commands/frame/diagnose/bad-reference/TestBadReference.py lld

[Lldb-commits] [lldb] fb30324 - Revert "[lldb] Fix member access in GetExpressionPath"

Author: Andy Yankovsky Date: 2022-09-30T15:26:09Z New Revision: fb30324a5d535b911b41aa09b1429ca3a88c7fee URL: https://github.com/llvm/llvm-project/commit/fb30324a5d535b911b41aa09b1429ca3a88c7fee DIFF: https://github.com/llvm/llvm-project/commit/fb30324a5d535b911b41aa09b1429ca3a88c7fee.diff LOG

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat reopened this revision. werat added a comment. This revision is now accepted and ready to land. In D132734#3827245 , @mib wrote: > Let me know if you need help reproducing and fixing these issues, otherwise > I'll have to revert your patch. Sorry

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

mib added a comment. In D132734#3827361 , @werat wrote: > In D132734#3827245 , @mib wrote: > >> Let me know if you need help reproducing and fixing these issues, otherwise >> I'll have to revert your patch. > > S

[Lldb-commits] [PATCH] D134927: Make the sanitizer Notify callbacks asynchronous

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp:302-309 bool internal = true; bool hardware = false; Breakpoint *breakpoint = process_sp->GetTarge

[Lldb-commits] [PATCH] D134011: [lldb] Fix parentheses placement in GetExpressionPath

kastiglione abandoned this revision. kastiglione added a subscriber: tonkosi. kastiglione added a comment. This was already being worked on in D132734 by @tonkosi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1340

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CreateProcess

jingham added a comment. The WillXXX have the virtue that they are at least self-documenting "Before you do XXX this will be called." As it stands somebody working on Target could be forgiven for thinking Target::CreateProcess was just a convenience method, and redo it somewhere inline. If we

[Lldb-commits] [PATCH] D134906: Have MemoryCache cache addresses that were unreadable, so duplicate read attempts can be suppressed

jingham added a comment. LGTM I didn't see a more appropriate datatype than SmallSet in the llvm collection. I wondered about the same thing Dave asked - should the errors mention that this failed because we checked a negative cache - but I think that would be more confusing than helpful to ll

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, DavidSpickett, jingham, mib. Herald added a project: All. JDevlieghere requested review of this revision. Around this time last year, I said on the mailing list [1] that I wanted to to transform the reproducers in

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 464395. JDevlieghere added a comment. Fix baseline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Target/Statistics.h lldb/include/ll

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere updated this revision to Diff 464396. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Target/Statistics.h lldb/include/lldb/Utility/Diagnostics.h lldb/include/lldb/

[Lldb-commits] [PATCH] D134927: Make the sanitizer Notify callbacks asynchronous

jingham added a comment. I had to fix one other thing. I had arbitrarily made the decision that if an internal breakpoint was hit while running an expression we should stop before running its callbacks. At the time we only had internal breakpoints with sync callbacks (again mostly dynamic loa

[Lldb-commits] [PATCH] D134927: Make the sanitizer Notify callbacks asynchronous

jingham updated this revision to Diff 464442. jingham added a comment. Handled hitting the sanitizer breakpoint while calling a function in StopInfoBreakpoint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134927/new/ https://reviews.llvm.org/D134

[Lldb-commits] [PATCH] D134922: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Probably because it just queries `m_index`. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134922/new/ https://reviews.llvm.org/D13492

[Lldb-commits] [PATCH] D134920: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Yeah, it does not look like there would be a lot of time spent in here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134920/new/ https://revi