[Lldb-commits] [PATCH] D135482: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

2022-10-07 Thread Dave Lee via Phabricator via lldb-commits
kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. lgtm now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135482/new/ https://reviews.llvm.org/D135482 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D135482: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

2022-10-07 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 466213. mib added a comment. - Add test - Remove extra line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135482/new/ https://reviews.llvm.org/D135482 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D135482: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

2022-10-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Can we add a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135482/new/ https://reviews.llvm.org/D135482 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D135482: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

2022-10-07 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. `This patch updates the image_regex_uuid matcher to match null-UUID images in the

[Lldb-commits] [PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

2022-10-07 Thread Arthur Eubanks via Phabricator via lldb-commits
aeubanks created this revision. aeubanks added a reviewer: DavidSpickett. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Similar to D135170 .

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

2022-10-07 Thread Tonko Sabolčec via Phabricator via lldb-commits
tonkosi added a comment. Hi, I fixed the issue causing macOS tests to fail, but I don't have a macOS machine to verify it actually works. I'd be grateful if someone could check that part. I also decided to further reduce number of parenthesis in output (e.g. `(*(ptr)).member` isn't ideal),

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

2022-10-07 Thread Tonko Sabolčec via Phabricator via lldb-commits
tonkosi updated this revision to Diff 466043. tonkosi edited the summary of this revision. tonkosi added a comment. Fixed the issue of printing unnecessary parenthesis, which broke API tests on macOS. Improved use of parenthesis to produce outputs such as `(*ptr).member` instead of

[Lldb-commits] [lldb] 68ab7ac - [LLDB] Add "frame select" as equivalent of GDB's "frame" command

2022-10-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-10-07T09:30:05Z New Revision: 68ab7accc72bffe4d27a1b2ee50105c7ffda54cf URL: https://github.com/llvm/llvm-project/commit/68ab7accc72bffe4d27a1b2ee50105c7ffda54cf DIFF: https://github.com/llvm/llvm-project/commit/68ab7accc72bffe4d27a1b2ee50105c7ffda54cf.diff

[Lldb-commits] [PATCH] D134873: [LLDB] Add "frame select" as equivalent of GDB's "frame" command

2022-10-07 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG68ab7accc72b: [LLDB] Add frame select as equivalent of GDBs frame command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5a9e213 - [LLDB] Fix crash when printing a struct with a static signed char member

2022-10-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-10-07T09:11:15Z New Revision: 5a9e21305803336dc359f72014849845b1a7e173 URL: https://github.com/llvm/llvm-project/commit/5a9e21305803336dc359f72014849845b1a7e173 DIFF: https://github.com/llvm/llvm-project/commit/5a9e21305803336dc359f72014849845b1a7e173.diff

[Lldb-commits] [PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

2022-10-07 Thread David Spickett via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9e21305803: [LLDB] Fix crash when printing a struct with a static signed char member (authored by DavidSpickett). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

2022-10-07 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG02c1c939486f: [LLDB] Fix printing a static bool struct member when using image lookup -t (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 02c1c93 - [LLDB] Fix printing a static bool struct member when using "image lookup -t"

2022-10-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-10-07T09:02:59Z New Revision: 02c1c939486f247dc80866477eaab193c634d1e2 URL: https://github.com/llvm/llvm-project/commit/02c1c939486f247dc80866477eaab193c634d1e2 DIFF: https://github.com/llvm/llvm-project/commit/02c1c939486f247dc80866477eaab193c634d1e2.diff

[Lldb-commits] [lldb] 3c2275a - [LLDB] Add missing space in help for frame-format-unique setting

2022-10-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-10-07T08:42:35Z New Revision: 3c2275a6073cdab5ae883104527b974ec9c9fa6d URL: https://github.com/llvm/llvm-project/commit/3c2275a6073cdab5ae883104527b974ec9c9fa6d DIFF: https://github.com/llvm/llvm-project/commit/3c2275a6073cdab5ae883104527b974ec9c9fa6d.diff

[Lldb-commits] [PATCH] D135031: [lldb] [llgs] Move client-server communication into a separate thread (WIP)

2022-10-07 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. In D135031#3833661 , @labath wrote: > I think we should get some measurements (e.g. from the `process plugin packet > speed-test` cmd) of the overhead of this approach. The latency/RTT of the > connection is very important for