[Lldb-commits] [PATCH] D135577: Summary:

DavidSpickett added a comment. > Note: The reason the summary is so terse is that the ARC tool opens two > windows and I was very confused about where to write what. Certainly would confuse me, maybe I've learned to autopilot through this though. Can you describe them? We can certainly add a no

[Lldb-commits] [PATCH] D135577: Summary:

DavidSpickett added a comment. Oh and if you would like someone to land this on your behalf please provide a name and email address for the commit (of course waiting for access is fine too). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new

lldb-commits@lists.llvm.org

DavidSpickett updated this revision to Diff 467041. DavidSpickett added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135668/new/ https://reviews.llvm.org/D135668 Files: lldb/include/lldb/Utility/RegisterValue.h lldb/so

lldb-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG812ad2167bd2: [LLDB] Change RegisterValue::SetFromMemoryData to const RegisterInfo& (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

lldb-commits@lists.llvm.org

Author: David Spickett Date: 2022-10-12T08:10:24Z New Revision: 812ad2167bd2e27f5d0dee07bb03a5910616e0b6 URL: https://github.com/llvm/llvm-project/commit/812ad2167bd2e27f5d0dee07bb03a5910616e0b6 DIFF: https://github.com/llvm/llvm-project/commit/812ad2167bd2e27f5d0dee07bb03a5910616e0b6.diff LOG

[Lldb-commits] [PATCH] D135670: [LLDB] Pass const RegisterInfo& to RegisterValue::SetValueFromData

This revision was automatically updated to reflect the committed changes. Closed by commit rG6faa345da9d7: [LLDB] Pass const RegisterInfo& to RegisterValue::SetValueFromData (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] 6faa345 - [LLDB] Pass const RegisterInfo& to RegisterValue::SetValueFromData

Author: David Spickett Date: 2022-10-12T08:19:30Z New Revision: 6faa345da9d747c65c4d901c4ef26dfedf95da45 URL: https://github.com/llvm/llvm-project/commit/6faa345da9d747c65c4d901c4ef26dfedf95da45 DIFF: https://github.com/llvm/llvm-project/commit/6faa345da9d747c65c4d901c4ef26dfedf95da45.diff LOG

lldb-commits@lists.llvm.org

Author: David Spickett Date: 2022-10-12T08:25:14Z New Revision: 28e65a6a63ab39be97d1a88fe7b4d0fa2f532643 URL: https://github.com/llvm/llvm-project/commit/28e65a6a63ab39be97d1a88fe7b4d0fa2f532643 DIFF: https://github.com/llvm/llvm-project/commit/28e65a6a63ab39be97d1a88fe7b4d0fa2f532643.diff LOG

lldb-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG28e65a6a63ab: [LLDB] Change RegisterValue::SetType param to const RegisterInfo& (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D135672: [LLDB] Change EmulateInstriction::ReadRegister to return Optional

DavidSpickett updated this revision to Diff 467057. DavidSpickett added a comment. Fix some undeclared vars, somehow I forgot to actualy build this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135672/new/ https://reviews.llvm.org/D135672 Files:

[Lldb-commits] [PATCH] D135672: [LLDB] Change EmulateInstriction::ReadRegister to return Optional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0577a9f8d06b: [LLDB] Change EmulateInstriction::ReadRegister to return Optional (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 0577a9f - [LLDB] Change EmulateInstriction::ReadRegister to return Optional

Author: David Spickett Date: 2022-10-12T08:37:36Z New Revision: 0577a9f8d06b97bf8b4d9aa171096e0797e4f5d1 URL: https://github.com/llvm/llvm-project/commit/0577a9f8d06b97bf8b4d9aa171096e0797e4f5d1 DIFF: https://github.com/llvm/llvm-project/commit/0577a9f8d06b97bf8b4d9aa171096e0797e4f5d1.diff LOG

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory (RFC)

DavidSpickett added a comment. > Technically yes, but then we have two ad-hoc solutions that support half the > log handlers. I think if we care about that we might as well go with the > T-based log handler behind the scenes. Sure. More wondering whether the choice between circular buffer and f

[Lldb-commits] [lldb] d1b83b9 - [LLDB] Fix x86_64 build

Author: David Spickett Date: 2022-10-12T09:19:29Z New Revision: d1b83b984fc1715fb7540dbb03ac8d170775b395 URL: https://github.com/llvm/llvm-project/commit/d1b83b984fc1715fb7540dbb03ac8d170775b395 DIFF: https://github.com/llvm/llvm-project/commit/d1b83b984fc1715fb7540dbb03ac8d170775b395.diff LOG

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG0205aa4a0257: [lldb] Fix member access in GetExpressionPath (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/n

[Lldb-commits] [lldb] 0205aa4 - [lldb] Fix member access in GetExpressionPath

Author: Tonko Sabolčec Date: 2022-10-12T12:08:57Z New Revision: 0205aa4a02570dfeda5807f66756ebdbb102744b URL: https://github.com/llvm/llvm-project/commit/0205aa4a02570dfeda5807f66756ebdbb102744b DIFF: https://github.com/llvm/llvm-project/commit/0205aa4a02570dfeda5807f66756ebdbb102744b.diff LOG

[Lldb-commits] [PATCH] D135768: Counterexample for D134849

labath created this revision. labath added a reviewer: zequanwu. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135768 Files: lldb/unit

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:459 + uint64_t end_offset = offset + fields.back()->bit_size; + parent->fields.push_back(fields.back()); + end_offset_map[end_offset].push_back(parent); --

[Lldb-commits] [PATCH] D133530: [lldb] Add zstd support

treapster added a comment. It seems like the new code doesn't check zstd version, thus breaking the build if you have something below 1.4.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133530/new/ https://reviews.llvm.org/D133530 __

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3836840 , @aaron.ballman wrote: > Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in > from someone on the LLVM side of things; lldb would be nice as well). I'll be landing this later t

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Fix the comment as suggested and good to go. Also please test on both macOS and linux to ensure this works on both prior to pushing the diff, I often have issues on either side with lldb-v

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Woops, forgot, you will need to modify the package.json to document the new launch config options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Statistics.cpp:305 +std::error_code ec; +raw_fd_ostream stats_stream(stat_file.GetPath(), ec, sys::fs::OF_None); +if (ec) clayborg wrote:

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 467266. zequanwu added a comment. - Handle the case when anonymous struct inside an union. - Append labath's changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:459 + uint64_t end_offset = offset + fields.back()->bit_size; + parent->fields.push_back(fields.back()); + end_offset_map[end_offset].push_back(parent);

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

bulbazord created this revision. bulbazord added reviewers: labath, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's easy enough to disable the lldb-server build. The lldb-server unit

[Lldb-commits] [PATCH] D135826: [lldb] Start from end of previous substr when checking ordered substrs

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm trying to add a test which tests that the same substr occurs twice in a row, but it matches even if only one of the s

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Or else multiple entries end up overlapping on the same line. Repository: rG LLVM Github Monorepo https://reviews.llv

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

aeubanks added a comment. Herald added a subscriber: JDevlieghere. (depends on https://reviews.llvm.org/D135826 for the test to be meaningful) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135827/new/ https://reviews.llvm.org/D135827 _

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher updated this revision to Diff 467310. HenriqueBucher added a comment. Visual Studio code has different folders for plugins when used by local users and users remoting into the box. The current instructions show how to install the lldb-vscode plugin only for the local users and it

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher updated this revision to Diff 467313. HenriqueBucher retitled this revision from "Summary:" to "Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solves issue #58252.".

[Lldb-commits] [lldb] 5a52c5c - Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

Author: Henrique Bucher Date: 2022-10-12T19:29:36-05:00 New Revision: 5a52c5c42669b3e547c9ca69b59b560d0268b85c URL: https://github.com/llvm/llvm-project/commit/5a52c5c42669b3e547c9ca69b59b560d0268b85c DIFF: https://github.com/llvm/llvm-project/commit/5a52c5c42669b3e547c9ca69b59b560d0268b85c.dif

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a52c5c42669: Summary: This documentation patch adds information to allow remote users to… (authored by HenriqueBucher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher added a comment. Got a very nice email from Chris Lattner with the approval. Very nice. Dude I took the plunge and did it. I hope it went through right. Please let me know if I screwed it up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

jryans added a comment. Exciting, welcome to the LLVM community! 🙂 Overall your commit looks okay, but here are a few tips for the future... The "Summary:" prefix in the commit title is not needed. It's good to start the commit title with an active verb e.g. "Add foo to bar". You can optionally

[Lldb-commits] [lldb] 6eb40bf - [test] Fix a test that wasn't running

Author: Jordan Rupprecht Date: 2022-10-12T20:43:46-07:00 New Revision: 6eb40bf51b768672218539935f60ce55ae6ad750 URL: https://github.com/llvm/llvm-project/commit/6eb40bf51b768672218539935f60ce55ae6ad750 DIFF: https://github.com/llvm/llvm-project/commit/6eb40bf51b768672218539935f60ce55ae6ad750.di