[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

mstorsjo added a comment. Was the consensus that we'd drop this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134581/new/ https://reviews.llvm.org/D134581 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun abandoned this revision. alvinhochun added a comment. Since the original issue was fixed in a different patch I don't think I will follow up on this anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134581/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D136306: [lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

Michael137 updated this revision to Diff 469553. Michael137 added a comment. - Docs fixes - Add more test cases - Handle operator overloads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136306/new/ https://reviews.llvm.org/D136306 Files: lldb/so

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1413-1414 if (context.isTranslationUnit()) { -ParseAllNamespacesPlusChildrenOf(llvm::None); +ParseAllTypes(); +ParseAllFunctionsAndNo

[Lldb-commits] [lldb] 3cc9884 - [lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

Author: Michael Buch Date: 2022-10-21T14:00:50+01:00 New Revision: 3cc9884500ad53e878045bc1d119d8a6b326f274 URL: https://github.com/llvm/llvm-project/commit/3cc9884500ad53e878045bc1d119d8a6b326f274 DIFF: https://github.com/llvm/llvm-project/commit/3cc9884500ad53e878045bc1d119d8a6b326f274.diff

[Lldb-commits] [PATCH] D136306: [lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cc9884500ad: [lldb][CPlusPlus] Add abi_tag support to the CPlusPlusNameParser (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136306

[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

varunkumare99 created this revision. varunkumare99 added a reviewer: DavidSpickett. Herald added a project: All. varunkumare99 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. added support for colored output for the commands 1. image looku

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. mark2185 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The local ports for `platform connect` and `attach` were always random, this allow

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere updated this revision to Diff 469677. JDevlieghere added a comment. - Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135621/new/ https://reviews.llvm.org/D135621 Files: lldb/include/lldb/Utility/Diagnostics.h lldb/include/lldb/Utility/Log.h

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added a comment. In D135621#3850248 , @clayborg wrote: > I am also questioning if the these even belong in the LLDB logging stuff? > Seems like it would be just as easy to create a diagnostic message by calling > Diagnostics::Report(...). D

[Lldb-commits] [lldb] 9b809cc - [LLDB][NativePDB] Improve ParseDeclsForContext time.

Author: Zequan Wu Date: 2022-10-21T10:33:16-07:00 New Revision: 9b809cc5b69a45601910bf4c60a2ece2f5462a18 URL: https://github.com/llvm/llvm-project/commit/9b809cc5b69a45601910bf4c60a2ece2f5462a18 DIFF: https://github.com/llvm/llvm-project/commit/9b809cc5b69a45601910bf4c60a2ece2f5462a18.diff LOG

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b809cc5b69a: [LLDB][NativePDB] Improve ParseDeclsForContext time. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136006/new/ https:/

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. > I expect the majority of places where we want to log to the diagnostic log > channel to be places where we already log today. This is my expectation too. Some logs are helpful for

[Lldb-commits] [lldb] c9885f7 - [trace][intel pt][simple] Fix TestTraceSave

Author: Walter Erquinigo Date: 2022-10-21T11:00:55-07:00 New Revision: c9885f74f45510d287ceca034c761f1787a201d9 URL: https://github.com/llvm/llvm-project/commit/c9885f74f45510d287ceca034c761f1787a201d9 DIFF: https://github.com/llvm/llvm-project/commit/c9885f74f45510d287ceca034c761f1787a201d9.di

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Diagnostics.cpp:23 +static constexpr Log::Category g_categories[] = { +{{"lldb"}, {"diagnostics log for lldb"}, DiagnosticsLog::LLDB}, +}; kastiglione wrote: > To me, it's not ideal that ther

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

eaeltsin added a comment. Heads-up - I'm seeing the compilation failure that reduces to this commit. I didn't get a reproducer of the reasonable size yet :( The problem occurs when using modules only. The module has code like: template class A { public: T x; template frien