[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

2022-10-23 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 470047. wallace edited the summary of this revision. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136557/new/ https://reviews.llvm.org/D136557 Files:

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

2022-10-23 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, LLDB, clang-tools-extra. Herald added subscribers: cfe-commits, lldb-commits. This makes use of

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

2022-10-23 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov updated this revision to Diff 470011. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

2022-10-23 Thread Matheus Izvekov via Phabricator via lldb-commits
mizvekov retitled this revision from "[clang] Instiantiate early substituted entities with sugared template arguments" to "[clang] Implement sugared substitution changes to infrastructure". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470008. Herald added

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

2022-10-23 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The low-level decoder might fall into an infinite decoding loop for various

[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

2022-10-23 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/CMakeLists.txt:20 +option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS}) + To be honest, I don't exactly like moving this `option`. The alternative I can think of is

[Lldb-commits] [PATCH] D136552: [lldb] Add LLVM include dirs prior to gtest target in standalone build

2022-10-23 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 469984. mgorny added a comment. Rebase to make it independent of D136551 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136552/new/ https://reviews.llvm.org/D136552 Files: lldb/cmake/modules/LLDBStandalone.cmake

[Lldb-commits] [PATCH] D136552: [lldb] Add LLVM include dirs prior to gtest target in standalone build

2022-10-23 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, MaskRay, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Move include_directories() declaration before gtest targets are created in standalone build.

[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

2022-10-23 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, tstellar, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Build gtest targets when building standalone only if LLDB_INCLUDE_TESTS is true. Prior to

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

2022-10-23 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:1947 - // name ([%d]) to the expression path - if (m_flags.m_is_array_item_for_pointer && - epformat == eGetExpressionPathFormatHonorPointers) I am *absolutely* not an expert