[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/API/SBTraceCursor.cpp:127-131 +double SBTraceCursor::GetWallClockTime() const { + LLDB_INSTRUMENT_VA(this); + + const auto _wall_clock_time =

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. @aaron.ballman does this seem OK? (this was based on my suggestion in the related review linked in the description) It probably needs tests in clang too - not sure if there's an opportunity to use a unit test to simplify

[Lldb-commits] [PATCH] D137684: Make sure we are stopped before we try to install functions into the target

jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda, labath, clayborg. Herald added a subscriber: kristof.beyls. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's

[Lldb-commits] [PATCH] D137682: Change IRMemoryMap's last-resort magic address to an inaddressable address so it doesn't conflict

jasonmolenda added a comment. Probably the laziest bit is at the end of the test case where I want to test that the variable isn't '1', I didn't use a substring because it's uninitialized memory could come back as '10' or something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D137682: Change IRMemoryMap's last-resort magic address to an inaddressable address so it doesn't conflict

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: Michael137. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When the

[Lldb-commits] [lldb] 3b70e8b - Move the second instance of TestUniqueTypes.py to a unique file

Author: Jim Ingham Date: 2022-11-08T16:59:02-08:00 New Revision: 3b70e8b012f0f51eb0e2abeb38ee6c8914b90f9c URL: https://github.com/llvm/llvm-project/commit/3b70e8b012f0f51eb0e2abeb38ee6c8914b90f9c DIFF: https://github.com/llvm/llvm-project/commit/3b70e8b012f0f51eb0e2abeb38ee6c8914b90f9c.diff

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

jj10306 updated this revision to Diff 474092. jj10306 added a comment. update the way items with no timestamps are handled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137645/new/ https://reviews.llvm.org/D137645 Files:

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jingham added a comment. In D137000#3902217 , @labath wrote: > In D137000#3897878 , @jgorbe wrote: > >> I'm looking at the option of using a non-printable character for the short >> flag, and at the same time

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. It is a bit odd to follow the what the help summary says is a valid option set and then get an error. But this is a corner case, and since you say explicitly that you can't provide both

[Lldb-commits] [PATCH] D137662: Make aliases from a raw command that isn't a top-level command work

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione, clayborg. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When we went to

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

hawkinsw added inline comments. Comment at: lldb/source/API/SBTraceCursor.cpp:127-131 +double SBTraceCursor::GetWallClockTime() const { + LLDB_INSTRUMENT_VA(this); + + const auto _wall_clock_time = m_opaque_sp->GetWallClockTime(); + return maybe_wall_clock_time ?

[Lldb-commits] [PATCH] D137614: [trace] Add a new call graph reconstructor

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:296 std::vector m_item_data; + std::vector m_insn_extra_info; /// The TraceItemKind for each trace item encoded as uint8_t. We don't include jj10306 wrote: > do

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/API/SBTraceCursor.h:175 + /// if not available. + double GetWallClockTime() const; + /// \} mention

[Lldb-commits] [PATCH] D137614: [trace] Add a new call graph reconstructor

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:296 std::vector m_item_data; + std::vector m_insn_extra_info; /// The TraceItemKind for each trace item encoded as uint8_t. We don't include do we need to store

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

tstellar added a comment. @tbaeder That CI failure seems unrelated. Maybe just commit early in the day so you have time to deal with the bot failures (if any). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

hawkinsw added inline comments. Comment at: lldb/source/API/SBTraceCursor.cpp:131 + const auto _wall_clock_time = m_opaque_sp->GetWallClockTime(); + return maybe_wall_clock_time ? *maybe_wall_clock_time : -1.0; +} jj10306 wrote: > open to suggestions on the

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

jj10306 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/API/SBTraceCursor.cpp:131 + const auto _wall_clock_time = m_opaque_sp->GetWallClockTime(); + return maybe_wall_clock_time ? *maybe_wall_clock_time : -1.0; +} open

[Lldb-commits] [PATCH] D137645: [trace] Add `SBTraceCursor::GetWallClockTime` API

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Test Plan: Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf766fb65cc9: [NFC][intelpt] Improve IntelPT trace bundle documentation (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137509/new/

[Lldb-commits] [lldb] df766fb - [NFC][intelpt] Improve IntelPT trace bundle documentation

Author: Jakob Johnson Date: 2022-11-08T05:16:28-08:00 New Revision: df766fb65cc939bd88c25cb8e478b07f7b4ce123 URL: https://github.com/llvm/llvm-project/commit/df766fb65cc939bd88c25cb8e478b07f7b4ce123 DIFF: https://github.com/llvm/llvm-project/commit/df766fb65cc939bd88c25cb8e478b07f7b4ce123.diff

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

tbaeder added a comment. I'm worried that this is gonna break build bots. Has anyone seen the ThreadSanitizer timeout reported by the precommit-ci before? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. In D136565#3913932 , @mizvekov wrote: > @alexfh Thanks! > > While there is a huge increase in the amount of UsingTypes, it seems the > total amount is still reasonable and does not explain the perf hit. > > Perhaps this is a case

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 473951. tbaeder added a comment. Add a release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Version.inc.in