[Lldb-commits] [lldb] 2082188 - [lldb/test] Fix app_specific_backtrace_crashlog.test (NFC)

Author: Med Ismail Bennani Date: 2022-11-10T18:32:18-08:00 New Revision: 2082188406965fe35ef3d8b1f2057ab7f8e15a43 URL: https://github.com/llvm/llvm-project/commit/2082188406965fe35ef3d8b1f2057ab7f8e15a43 DIFF:

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

This revision was automatically updated to reflect the committed changes. Closed by commit rG97105e5bf70f: [libclang] Expose completion result kind in `CXCompletionResult` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 48321ee - Check m_dyld_up directly in LoadBinariesViaMetadata

Author: Jason Molenda Date: 2022-11-10T15:49:23-08:00 New Revision: 48321eea9679e1d8c5a30f4027e1aa49738aebf3 URL: https://github.com/llvm/llvm-project/commit/48321eea9679e1d8c5a30f4027e1aa49738aebf3 DIFF: https://github.com/llvm/llvm-project/commit/48321eea9679e1d8c5a30f4027e1aa49738aebf3.diff

[Lldb-commits] [PATCH] D137807: When scanning mach-o corefile, don't run all DynamicLoader plugins letting one of them Create when searching for binaries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48321eea9679: Check m_dyld_up directly in LoadBinariesViaMetadata (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D137807: When scanning mach-o corefile, don't run all DynamicLoader plugins letting one of them Create when searching for binaries

jasonmolenda updated this revision to Diff 474624. jasonmolenda added a comment. Jonas' feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137807/new/ https://reviews.llvm.org/D137807 Files:

[Lldb-commits] [PATCH] D137807: When scanning mach-o corefile, don't run all DynamicLoader plugins letting one of them Create when searching for binaries

jasonmolenda added a comment. Thanks Jonas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137807/new/ https://reviews.llvm.org/D137807 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D137807: When scanning mach-o corefile, don't run all DynamicLoader plugins letting one of them Create when searching for binaries

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp:334 + // un-set it later. + if (m_dyld_up.get()) m_dyld_plugin_name =

[Lldb-commits] [PATCH] D137807: When scanning mach-o corefile, don't run all DynamicLoader plugins letting one of them Create when searching for binaries

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In https://reviews.llvm.org/D133680 I changed a lot of how

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

arphaman accepted this revision. arphaman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 353f265 - Apparently I moved the wrong one to "2", then Jason moved the right

Author: Jim Ingham Date: 2022-11-10T15:23:51-08:00 New Revision: 353f265283e9ab209b544ab6818f3bd6ca071873 URL: https://github.com/llvm/llvm-project/commit/353f265283e9ab209b544ab6818f3bd6ca071873 DIFF: https://github.com/llvm/llvm-project/commit/353f265283e9ab209b544ab6818f3bd6ca071873.diff

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

Michael137 added a comment. In D137793#3920254 , @aeubanks wrote: > In D137793#3920253 , @Michael137 > wrote: > >> In D137793#3920209 , @aeubanks >> wrote: >> >>> add a

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Mechanically this looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132624/new/ https://reviews.llvm.org/D132624

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dcaca706841: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9,11,13} (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 9dcaca7 - [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

Author: Michael Buch Date: 2022-11-10T14:09:10-08:00 New Revision: 9dcaca706841fa38683eee341f24aafb58e6e3e9 URL: https://github.com/llvm/llvm-project/commit/9dcaca706841fa38683eee341f24aafb58e6e3e9 DIFF: https://github.com/llvm/llvm-project/commit/9dcaca706841fa38683eee341f24aafb58e6e3e9.diff

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

aeubanks added a comment. In D137793#3920253 , @Michael137 wrote: > In D137793#3920209 , @aeubanks > wrote: > >> add a FIXME? > > May be misunderstanding your suggestion, but the malformed DWARF got fixed >

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

Michael137 added a comment. In D137793#3920209 , @aeubanks wrote: > add a FIXME? May be misunderstanding your suggestion, but the malformed DWARF got fixed somewhere between clang-14/clang-15. This is only an issue with older clang versions

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. add a FIXME? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137793/new/ https://reviews.llvm.org/D137793

[Lldb-commits] [PATCH] D137793: [lldb][test] TestConstStaticIntegralMember.py: fix for clang-{9, 11, 13}

Michael137 created this revision. Michael137 added a reviewer: aeubanks. Herald added a subscriber: kristof.beyls. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** The public lldb matrix

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG868186cf6cb7: [lldb] Make callback-based formatter matching available from the CLI. (authored by jgorbe). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 868186c - [lldb] Make callback-based formatter matching available from the CLI.

Author: Jorge Gorbe Moya Date: 2022-11-10T10:29:38-08:00 New Revision: 868186cf6cb7edba08c916f98f5f87a942bf50ba URL: https://github.com/llvm/llvm-project/commit/868186cf6cb7edba08c916f98f5f87a942bf50ba DIFF:

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 474573. jgorbe added a comment. - Clarified help text for `--recognizer-function` as suggested by reviewer. Instead of "Incompatible with --regex (-x)." now it says "Cannot be specified at the same time as --regex (-x)." - Rebased on top of current HEAD.

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. In D137000#3915943 , @jingham wrote: > It is a bit odd to follow the what the help summary says is a valid option > set and then get an error. But this is a corner case, and since you say > explicitly that you can't provide

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1b88c8a09be: [clang] Only use major version in resource dir (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] e1b88c8 - [clang] Only use major version in resource dir

Author: Timm Bäder Date: 2022-11-10T15:02:03+01:00 New Revision: e1b88c8a09be25b86b13f98755a9bd744b4dbf14 URL: https://github.com/llvm/llvm-project/commit/e1b88c8a09be25b86b13f98755a9bd744b4dbf14 DIFF: https://github.com/llvm/llvm-project/commit/e1b88c8a09be25b86b13f98755a9bd744b4dbf14.diff

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aaron.ballman added a comment. In D137583#3917735 , @dblaikie wrote: > In D137583#3917706 , @aaron.ballman > wrote: > >>> ...we expect template params to be fully qualified when comparing them for >>> simple