[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

labath added a comment. Looks good, but I think you missed one comment. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h:90 void Dump(Stream ); + static void RequireCompleteType(CompilerType type); labath wrote: > I forgot about this

[Lldb-commits] [lldb] 15cd237 - [lldb] Re-phase comments in `ScriptedProcess.get_loaded_images` method (NFC)

Author: Med Ismail Bennani Date: 2022-11-14T23:25:52-08:00 New Revision: 15cd237cc2afc07074c69ff4bd6c63dd3d6e0ebd URL: https://github.com/llvm/llvm-project/commit/15cd237cc2afc07074c69ff4bd6c63dd3d6e0ebd DIFF:

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson added a comment. @MaskRay wondering if this is a good change to make for ELF as well, wdyt? Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104 - auto AddStream = [&](size_t Task) { + auto AddStream = [&](size_t Task, Twine File) { return

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang added a comment. @aprantl I still had to adjust the code slightly to copy the type from the `ASTContext for '.../a.out'` to the `scratch ASTContext` (without this, my code was triggering an assert). See https://reviews.llvm.org/D132624?vs=474793=475327 for the related changes.

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang updated this revision to Diff 475327. avogelsgesang added a comment. Fix ownership of CompilerType between "scratch typesystem" and "module type system" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132624/new/

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104 - auto AddStream = [&](size_t Task) { + auto AddStream = [&](size_t Task, Twine File) { return std::make_unique(std::move(OS), tejohnson wrote: > I think you might need

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475296. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. also I'm don't understand how this code doesn't infinite recurse on ObjC and can't trace it because I don't have a mac if anybody has an actual way of fixing this I'd be happy with that too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. Herald added a subscriber: JDevlieghere. lldb crash repro $ cat /tmp/a.cc #include void f(std::vector& v) { *(volatile int*) nullptr = 0; } $ cat /tmp/main.cc #include void f(std::vector& v); int main() { std::vector v ;

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After D134378 , we started seeing crashes with incomplete types (in the context of

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

clayborg added a comment. I just got time to run a quick comparison to see how much more efficient this patch is over what we currently have when doing lookups. Since we only resolve types whose context matches now, we parse many orders of magnitude fewer types. I added the following log line

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

clayborg added a comment. In D137900#3925775 , @aprantl wrote: > Thanks for looking into this. I'm not sure I like how `TypeMatch` is both > input and output of the type search. What do you think about making an > immutable "TypeQuery" object that

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson added a comment. The naming convention used here for COFF is actually very similar to what is done for other ThinLTO save-temps output files, which are placed at the input module locations. We may want to just do this across the board. @MaskRay wdyt? A few other questions/comments

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

aprantl added a comment. Thanks for looking into this. I'm not sure I like how `TypeMatch` is both input and output of the type search. What do you think about making an immutable "TypeQuery" object that describes the search characteristics and have the API return a TypeMap? Apart from making

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. I'll hold off on submitting this until that bug is figured out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 ___ lldb-commits

[Lldb-commits] [PATCH] D137682: Change IRMemoryMap's last-resort magic address to an inaddressable address so it doesn't conflict

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53c45df5ed1b: Change last-ditch magic address in IRMemoryMap::FindSpace (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 53c45df - Change last-ditch magic address in IRMemoryMap::FindSpace

Author: Jason Molenda Date: 2022-11-14T09:54:05-08:00 New Revision: 53c45df5ed1b8ac606f7388cec025aaba0dee9ba URL: https://github.com/llvm/llvm-project/commit/53c45df5ed1b8ac606f7388cec025aaba0dee9ba DIFF: https://github.com/llvm/llvm-project/commit/53c45df5ed1b8ac606f7388cec025aaba0dee9ba.diff

[Lldb-commits] [PATCH] D137682: Change IRMemoryMap's last-resort magic address to an inaddressable address so it doesn't conflict

jasonmolenda updated this revision to Diff 475184. jasonmolenda added a comment. Update for Jim's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137682/new/ https://reviews.llvm.org/D137682 Files:

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory

JDevlieghere added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135631/new/ https://reviews.llvm.org/D135631 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Hi this broke https://lab.llvm.org/buildbot/#/builders/245/builds/761 I have reverted the change to make the buildbot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST