[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

teemperor created this revision. teemperor added a reviewer: Michael137. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. GCC emits macro definitions into

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. @dblaikie ping? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

aeubanks updated this revision to Diff 481711. aeubanks added a comment. revert one change to make this nfc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139649/new/ https://reviews.llvm.org/D139649 Files:

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[Lldb-commits] [lldb] 3b7ac5b - Fix GetAddressOf for children of pointer ValueObjectConstResult* variables.

Author: Jim Ingham Date: 2022-12-09T11:16:10-08:00 New Revision: 3b7ac5b295df7381cee277342085f52fe468e633 URL: https://github.com/llvm/llvm-project/commit/3b7ac5b295df7381cee277342085f52fe468e633 DIFF: https://github.com/llvm/llvm-project/commit/3b7ac5b295df7381cee277342085f52fe468e633.diff

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3984855 , @arphaman wrote: > Ping @mizvekov. > > Unfortunately I'm unable to revert this commit now so we won't be able to get > the bot back to green until it's fixed. Hello, sorry for the long time to respond.

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:307-308 + +int addr_size = +process->GetTarget().GetArchitecture().GetAddressByteSize(); for (uint64_t i = 0; i <

[Lldb-commits] [lldb] 9c5877f - Switch the "command script add" interactive input to use the new command form.

Author: Jim Ingham Date: 2022-12-09T10:58:15-08:00 New Revision: 9c5877f33d9f7fd317c07920fd24a041ad69077a URL: https://github.com/llvm/llvm-project/commit/9c5877f33d9f7fd317c07920fd24a041ad69077a DIFF: https://github.com/llvm/llvm-project/commit/9c5877f33d9f7fd317c07920fd24a041ad69077a.diff

[Lldb-commits] [PATCH] D139684: Switch the "command script add" interactive editor to use the exe_ctx interface

jingham added a comment. In D139684#3984997 , @JDevlieghere wrote: > Just to make sure I understand: this works because we already supported both > variants, and Python picks up the correct one based on the function > signature? If so then this LGTM.

[Lldb-commits] [PATCH] D139684: Switch the "command script add" interactive editor to use the exe_ctx interface

JDevlieghere added a comment. Just to make sure I understand: this works because we already supported both variants, and Python picks up the correct one based on the function signature? If so then this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139684: Switch the "command script add" interactive editor to use the exe_ctx interface

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139684/new/ https://reviews.llvm.org/D139684

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

arphaman added a comment. Ping @mizvekov. Unfortunately I'm unable to revert this commit now so we won't be able to get the bot back to green until it's fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251 + if (has_template_params && + ParseTemplateParameterInfos(die, template_param_infos)) { +template_function_decl =

[Lldb-commits] [PATCH] D139674: Fix ValueObject::GetAddressOf for subclasses using ValueObjectConstResultImpl backends

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139674/new/ https://reviews.llvm.org/D139674

[Lldb-commits] [lldb] 12a877a - Adapt lldb to use StringRef for option storage

Author: serge-sans-paille Date: 2022-12-09T11:25:26+01:00 New Revision: 12a877a32c73e5364ace453dad0ab7cb63a6506c URL: https://github.com/llvm/llvm-project/commit/12a877a32c73e5364ace453dad0ab7cb63a6506c DIFF:

[Lldb-commits] [lldb] d881fdf - Revert "Recommit of 8ae18303f97d5dcfaecc90b4d87effb2011ed82e - part 2"

Author: serge-sans-paille Date: 2022-12-09T10:15:41+01:00 New Revision: d881fdf72047fd18b88c6a65d0966cad542c95cd URL: https://github.com/llvm/llvm-project/commit/d881fdf72047fd18b88c6a65d0966cad542c95cd DIFF:

[Lldb-commits] [lldb] 4faf000 - Recommit of 8ae18303f97d5dcfaecc90b4d87effb2011ed82e - part 2

Author: serge-sans-paille Date: 2022-12-09T10:07:02+01:00 New Revision: 4faf6cf989f3ae212912994022c0486a2dc4 URL: https://github.com/llvm/llvm-project/commit/4faf6cf989f3ae212912994022c0486a2dc4 DIFF: