[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne created this revision. sebastian-ne added reviewers: jloser, MaskRay, dblaikie, jsilvanus. Herald added subscribers: ormris, StephenFan, wenlei, hiraditya. Herald added a project: All. sebastian-ne requested review of this revision. Herald added projects: clang, LLDB, LLVM. Herald adde

[Lldb-commits] [lldb] ad10b3d - Skip TestEarlyProcessLaunch.py w/ system debugserver

Author: Jason Molenda Date: 2022-12-13T14:52:46-08:00 New Revision: ad10b3dc3053fbbdea4b4b3c3e2b913fe2224647 URL: https://github.com/llvm/llvm-project/commit/ad10b3dc3053fbbdea4b4b3c3e2b913fe2224647 DIFF: https://github.com/llvm/llvm-project/commit/ad10b3dc3053fbbdea4b4b3c3e2b913fe2224647.diff

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

bulbazord added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:33 + +processes = { +420: { JDevlieghere wrote: > Why is this method implemented and not a `pass` like the others? This method is not imple

[Lldb-commits] [PATCH] D139969: Add a json dumper for call graph reconstructor

wallace added a comment. I'll take a look at this later tonight or tomorrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139969/new/ https://reviews.llvm.org/D139969 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:25-28 void ScriptedThread::CheckInterpreterAndScriptObject() const { - lldbassert(m_script_object_sp && "Invalid Script Object."); - lldbassert(GetInterface() && "Invalid Sc

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

JDevlieghere added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:317 +PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform( +const char *python_class_name, const char *session_dictionary_name, This looks pretty similar to

[Lldb-commits] [PATCH] D139969: Add a json dumper for call graph reconstructor

persona0220 created this revision. persona0220 added reviewers: jj10306, wallace. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff is created on top of D137614

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This looks like what I had in mind. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139853/new/ https://reviews.llvm.org/D139853 _

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/main.cpp:25-26 void call_and_wait(int &n) { - std::cout << "waiting for computation!" << std::endl; - while (baz(n) != 42) + while (baz(n, mutex, cv) != 42) { ; + } --

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM, small nit Comment at: lldb/test/API/functionalities/scripted_process/main.cpp:21 + // returns + lock.lock(); +} nit: no need t

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory patern

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:419-426 +def CrashLogParserFactory(debugger, path, verbose): +data = JSONCrashLogParser.is_valid_json(path) +if data: +parser = JSONCrashLogParser(debugger, path, verbose) +pa

[Lldb-commits] [lldb] adfb23c - [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

Author: Vasileios Porpodas Date: 2022-12-13T11:46:29-08:00 New Revision: adfb23c607ce35f090cf3e29fba9d382b22c3a50 URL: https://github.com/llvm/llvm-project/commit/adfb23c607ce35f090cf3e29fba9d382b22c3a50 DIFF: https://github.com/llvm/llvm-project/commit/adfb23c607ce35f090cf3e29fba9d382b22c3a50.

[Lldb-commits] [PATCH] D139910: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadfb23c607ce: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required. (authored by vporpo). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

This revision was automatically updated to reflect the committed changes. Closed by commit rGee11ef6dc0b2: Launch state discoverable in Darwin, use for SafeToCallFunctions (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D139054?vs=480277&id=482575#toc Repository:

[Lldb-commits] [lldb] ee11ef6 - Launch state discoverable in Darwin, use for SafeToCallFunctions

Author: Jason Molenda Date: 2022-12-13T11:42:56-08:00 New Revision: ee11ef6dc0b293161dd916b64581eb37a231709b URL: https://github.com/llvm/llvm-project/commit/ee11ef6dc0b293161dd916b64581eb37a231709b DIFF: https://github.com/llvm/llvm-project/commit/ee11ef6dc0b293161dd916b64581eb37a231709b.diff

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I don't really understand the motivation. Can you elaborate on why "enabling 64 bit support" requires this change? I definitely prefer the `formatv` approach, but wouldn'

[Lldb-commits] [lldb] f54497f - [lldb] Remove basestring references in examples (NFC)

Author: Dave Lee Date: 2022-12-13T11:10:11-08:00 New Revision: f54497f114b9b5acaa8ebff296594b2cd7e437dd URL: https://github.com/llvm/llvm-project/commit/f54497f114b9b5acaa8ebff296594b2cd7e437dd DIFF: https://github.com/llvm/llvm-project/commit/f54497f114b9b5acaa8ebff296594b2cd7e437dd.diff LOG:

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Following example of DWO changing it to use DIERef. Depends on D138618

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 482550. ayermolo added a comment. Herald added a subscriber: Michael137. Separated format patch, and oso patch. Although without OSO changes a lot of tests fail on mac. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei, arphaman. Herald added a reviewer: shafik. Herald added a project: All. ayermolo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a pro

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory patern

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix an undefined behaviour that's happening when parsing a crash repo

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + mib wrote: > mib wrote: > > labath wrote: > > > I am surpri

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib created this revision. mib added reviewers: jingham, labath, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch does several things: First, it refactors the `CommandObject{,Platform}P

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. In D138724#3988715 , @Michael137 wrote: > In D138724#3988318 , @labath wrote: > >> I just found out that this test (the non-shared-library version) fails on >> linux if the executable

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

steakhal added a comment. The `StaticAnalyzer` portion looks good to me AFAICT. Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39 ento::CallDescription::CallDescription(CallDescriptionFlags Flags, - ArrayRef QualifiedName, +

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib updated this revision to Diff 482495. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139853/new/ https://reviews.llvm.org/D139853 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process/scripted/ScriptedProce

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib added a comment. In D139853#3992058 , @labath wrote: > That definitely looks much better. As I understand it, the scripted thread > interface is more high-level that our internal thread interface, and that > means it is computing its queue by itself

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

labath added a comment. That definitely looks much better. As I understand it, the scripted thread interface is more high-level that our internal thread interface, and that means it is computing its queue by itself, instead of delegating the work to a separate plugin. That makes sense to me.

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib updated this revision to Diff 482486. mib marked an inline comment as done. mib added a comment. Make use of the process plugin model to avoid adding a special case on the system runtime plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139853/new/ https://reviews.llvm.org/D139

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib added inline comments. Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp:757 + bool is_scripted_process = m_process->GetPluginName() == "ScriptedProcess"; for (ThreadSP thread_sp : m_process->Threads()) { labath wrote: > mib w

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

labath added inline comments. Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp:757 + bool is_scripted_process = m_process->GetPluginName() == "ScriptedProcess"; for (ThreadSP thread_sp : m_process->Threads()) { mib wrote: > JDevl

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 482433. mib added a comment. Update test program and test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/functionalities/script

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470 const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) static constexpr llv

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 482413. mib marked 7 inline comments as done. mib added a comment. Address @JDevlieghere comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/so

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470 const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) static cons

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470 const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) static constexpr llv