[Lldb-commits] [lldb] 617ed4f - Remove the dependency between lib/DebugInfoDWARF and MC.

Author: Shubham Sandeep Rastogi Date: 2022-12-15T18:23:27-08:00 New Revision: 617ed4f061999025287b424c39fd99c5fe1e5126 URL: https://github.com/llvm/llvm-project/commit/617ed4f061999025287b424c39fd99c5fe1e5126 DIFF:

[Lldb-commits] [PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

rastogishubham updated this revision to Diff 483403. rastogishubham added a comment. Fix the lldb test failures: lldb-shell :: SymbolFile/DWARF/x86/DW_AT_loclists_base.s lldb-shell :: SymbolFile/DWARF/x86/debug_loc.s lldb-shell :: SymbolFile/DWARF/x86/debug_loc_and_loclists.s lldb-shell

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I like the new test! LGTM if @mib is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140056/new/ https://reviews.llvm.org/D140056

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione updated this revision to Diff 483379. kastiglione added a comment. Optimized test by using a minimal clang module; Addressed review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140056/new/ https://reviews.llvm.org/D140056

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 added a comment. In D140030#3999199 , @labath wrote: > I think that test should just be rewritten to not modify the object in such a > way. Instead of cumulatively modifying a single object, it could just create > a fresh one each time. That

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 updated this revision to Diff 483378. Michael137 added a comment. - No need for manipulator wrapper. Add constructors instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140030/new/ https://reviews.llvm.org/D140030 Files:

[Lldb-commits] [PATCH] D140112: [lldb][Test] Propagate llvm::yaml error message in TestFile::fromYaml

This revision was automatically updated to reflect the committed changes. Closed by commit rGc46587bb8323: [lldb][Test] Propagate llvm::yaml error message in TestFile::fromYaml (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c46587b - [lldb][Test] Propagate llvm::yaml error message in TestFile::fromYaml

Author: Michael Buch Date: 2022-12-15T22:45:46Z New Revision: c46587bb83232bd639c1e6ba6bce2f290941675d URL: https://github.com/llvm/llvm-project/commit/c46587bb83232bd639c1e6ba6bce2f290941675d DIFF: https://github.com/llvm/llvm-project/commit/c46587bb83232bd639c1e6ba6bce2f290941675d.diff LOG:

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. In D139955#3999521 , @labath wrote: > In D139955#3999381 , @ayermolo > wrote: > >> I tried to modify all the places wehre getOffset() is used. Which will later >> return 64bit instead

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

labath added a comment. In D139955#3999381 , @ayermolo wrote: > I tried to modify all the places wehre getOffset() is used. Which will later > return 64bit instead of 32 bit. > > Sorry I guess there was miss communication. > I am not quite clear in what

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h:105 +Status error; +Dispatch(method_name, error, args...); + `std::forward(args)...` maybe? Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

labath added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:73 bool m_include_platform_option; + OptionGroupPythonClassWithDict m_class_options; }; labath wrote: > These nested groups are fairly unusual? Couldn't

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

labath added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:73 bool m_include_platform_option; + OptionGroupPythonClassWithDict m_class_options; }; These nested groups are fairly unusual? Couldn't

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

labath added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + mib wrote: > mib wrote: > > mib wrote: > > > labath

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. I tried to modify all the places wehre getOffset() is used. Which will later return 64bit instead of 32 bit. Sorry I guess there was miss communication. I am not quite clear in what you are suggesting. The way I did it we now have two distinct interfaces. One for old

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

labath added a comment. For a "plugin", the scripted process is sure getting a lot of special handling in generic code. (I know this isn't being introduced here, but I wasn't involved in the previous review -- and I'm not actually sure I want to be involved here). I don't think that's

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

labath added a comment. I think that test should just be rewritten to not modify the object in such a way. Instead of cumulatively modifying a single object, it could just create a fresh one each time. That will also make it clearer what is being tested. And I think it's fair game to add some

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I think a switch case is easier to read (and spot things like missing cases) but this is code you own so go with the approach you like best. LGTM. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D140092: [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV

labath added a comment. In D140092#3998835 , @Emmmer wrote: > @labath Fixed in rGd850b340a9dd91fdb3c4dddc8328524c721576be > Thanks! Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:2026-2037 +if (reg == gpr_pc) + value->value.uint64 = clear_pac_bits( + reinterpret_cast(m_state.context.gpr.__opaque_pc)); +

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. Thanks for splitting this up. We still need to figure out what to do with the first patch, but these two are looking very good now. At least, in the sense that one can clearly see what is happening -- I'd still like to have to discussion about the DIERef->user_id

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

labath added a comment. Yeah, I'm afraid this is all my fault. I suggested going in this direction, but this isn't exactly how I thought it would turn out. I was expecting that the inferface would be something along the lines of what Jonas posted in his comment. And I was not expecting that

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:198 +// End the previous event before starting a new event. +m_current_progress_up.reset(nullptr); +m_current_progress_up.reset(new Progress(

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82 Log *m_log; + std::unique_ptr m_current_progress_up; + std::vector m_module_build_stack; aprantl wrote: > kastiglione wrote: > > mib

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

aprantl added a comment. Nice! I have a suggestion to speed up the test and make it a little more robust. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82 Log *m_log; + std::unique_ptr m_current_progress_up; + std::vector

[Lldb-commits] [PATCH] D140092: [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV

Emmmer added a comment. @labath Fixed in rGd850b340a9dd91fdb3c4dddc8328524c721576be Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140092/new/ https://reviews.llvm.org/D140092

[Lldb-commits] [lldb] d850b34 - Fix: use "using namespace" in a header file.

Author: Emmmer Date: 2022-12-16T03:31:10+08:00 New Revision: d850b340a9dd91fdb3c4dddc8328524c721576be URL: https://github.com/llvm/llvm-project/commit/d850b340a9dd91fdb3c4dddc8328524c721576be DIFF: https://github.com/llvm/llvm-project/commit/d850b340a9dd91fdb3c4dddc8328524c721576be.diff LOG:

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

aprantl added a comment. @DavidSpickett Is it possible to configure LLVM to not build with libLTO? Which CMake flag controls this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://reviews.llvm.org/D140051

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

labath added inline comments. Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.cpp:75 + Status error; + ScriptedPlatform *scripted_platform = + new ScriptedPlatform(const_cast(debugger), metadata, error); Use a shared_ptr directly here.

[Lldb-commits] [PATCH] D140092: [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV

labath added inline comments. Comment at: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.h:21-22 namespace lldb_private { +using namespace llvm; +using namespace lldb; You cannot use `using namespace` in a header file. That pollutes the

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

aprantl added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:2026-2037 +if (reg == gpr_pc) + value->value.uint64 = clear_pac_bits( + reinterpret_cast(m_state.context.gpr.__opaque_pc)); +else if

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:2026-2037 +if (reg == gpr_pc) + value->value.uint64 = clear_pac_bits( + reinterpret_cast(m_state.context.gpr.__opaque_pc)); +

[Lldb-commits] [lldb] 5aed2ef - Fix buildbot out of memory

Author: Emmmer Date: 2022-12-16T02:20:19+08:00 New Revision: 5aed2eff43c075b54be81095fdc5917bc32b530a URL: https://github.com/llvm/llvm-project/commit/5aed2eff43c075b54be81095fdc5917bc32b530a DIFF: https://github.com/llvm/llvm-project/commit/5aed2eff43c075b54be81095fdc5917bc32b530a.diff LOG:

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett added a comment. Sorry I should have been specific. With this change applied, when you don't have LTO, we'll just skip the individual test, or we'll not do testing at all? Wondering if this is an all or nothing situation, which would be unfortunate for a single test.

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere added a comment. In D138176#3997559 , @avl wrote: > In D138176#3995675 , @JDevlieghere > wrote: > >> Last week I debugged this further. Here's what I believe is going on. >> Consider the following

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory patern

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:419-426 +def CrashLogParserFactory(debugger, path, verbose): +data = JSONCrashLogParser.is_valid_json(path) +if data: +parser = JSONCrashLogParser(debugger, path, verbose) +

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 added a comment. @DavidSpickett right now if you don't have LTO the test will run but fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://reviews.llvm.org/D140051 ___

[Lldb-commits] [lldb] c12c90d - [lldb] Fix a warning

Author: Kazu Hirata Date: 2022-12-15T09:18:55-08:00 New Revision: c12c90d8f599dbbe423459d2b0f08b95fc7428be URL: https://github.com/llvm/llvm-project/commit/c12c90d8f599dbbe423459d2b0f08b95fc7428be DIFF: https://github.com/llvm/llvm-project/commit/c12c90d8f599dbbe423459d2b0f08b95fc7428be.diff

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rG6493fc4bccd2: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV (authored by Emmmer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 6493fc4 - [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Author: Emmmer Date: 2022-12-16T00:58:26+08:00 New Revision: 6493fc4bccd2a5365f3f3a4f205acb8c1409bd0d URL: https://github.com/llvm/llvm-project/commit/6493fc4bccd2a5365f3f3a4f205acb8c1409bd0d DIFF: https://github.com/llvm/llvm-project/commit/6493fc4bccd2a5365f3f3a4f205acb8c1409bd0d.diff LOG:

[Lldb-commits] [PATCH] D140113: [lldb] Force override when adding crashlog command

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. When using interactive crashlog from an IDE, it can happen that the user already have

[Lldb-commits] [PATCH] D140112: [lldb][Test] Propagate llvm::yaml error message in TestFile::fromYaml

Michael137 created this revision. Michael137 added reviewers: aprantl, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently the test-suite would swallow the error message on

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82 Log *m_log; + std::unique_ptr m_current_progress_up; + std::vector m_module_build_stack; mib wrote: > `Progress` makes use of RAII to

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. > Good point, it would be c++20. C++17 rather. People have been testing building with 20 but 17 is the standard for llvm right now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140032/new/ https://reviews.llvm.org/D140032

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140032/new/ https://reviews.llvm.org/D140032 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Emmmer updated this revision to Diff 483166. Emmmer marked an inline comment as done. Emmmer added a comment. address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140032/new/ https://reviews.llvm.org/D140032 Files:

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Emmmer marked an inline comment as done. Emmmer added inline comments. Comment at: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp:1452 [&](auto &) { - APFloat apf(APFloat::IEEEsingle(), rs1); +

[Lldb-commits] [PATCH] D140102: [lldb] Explain memory history provider in mem hist command description

Michael137 updated this revision to Diff 483160. Michael137 added a comment. - Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140102/new/ https://reviews.llvm.org/D140102 Files: lldb/source/Commands/CommandObjectMemory.cpp

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp:1452 [&](auto &) { - APFloat apf(APFloat::IEEEsingle(), rs1); + APFloat

[Lldb-commits] [PATCH] D140102: [lldb] Explain memory history provider in mem hist command description

Michael137 created this revision. Michael137 added reviewers: jingham, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. eviously, using `memory history` command on an executable which

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Emmmer updated this revision to Diff 483154. Emmmer added a comment. address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140032/new/ https://reviews.llvm.org/D140032 Files: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp

[Lldb-commits] [PATCH] D140092: [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rG260ba2f22422: [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV (authored by Emmmer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140092/new/

[Lldb-commits] [lldb] 260ba2f - [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV

Author: Emmmer Date: 2022-12-15T21:32:20+08:00 New Revision: 260ba2f2242253a1e9f5eada5a14ebb25ba689cf URL: https://github.com/llvm/llvm-project/commit/260ba2f2242253a1e9f5eada5a14ebb25ba689cf DIFF: https://github.com/llvm/llvm-project/commit/260ba2f2242253a1e9f5eada5a14ebb25ba689cf.diff LOG:

[Lldb-commits] [PATCH] D140092: [NFC][LLDB] Using namespace llvm in EmulateInstructionRISCV

Emmmer updated this revision to Diff 483142. Emmmer added a comment. rebase main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140092/new/ https://reviews.llvm.org/D140092 Files: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl accepted this revision. avl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl added a comment. In D138176#3995675 , @JDevlieghere wrote: > Last week I debugged this further. Here's what I believe is going on. > Consider the following simplified example with two CUs and a type `Foo`. > > 0x01: DW_TAG_compile_unit > >

[Lldb-commits] [PATCH] D140092: [NFC] Using namespace llvm in EmulateInstructionRISCV

DavidSpickett added a comment. Please tag [LLDB] in the commit title. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140092/new/ https://reviews.llvm.org/D140092 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D140092: [NFC] Using namespace llvm in EmulateInstructionRISCV

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140092/new/ https://reviews.llvm.org/D140092

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:25-28 void ScriptedThread::CheckInterpreterAndScriptObject() const { - lldbassert(m_script_object_sp && "Invalid Script Object."); -

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

mib added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82 Log *m_log; + std::unique_ptr m_current_progress_up; + std::vector m_module_build_stack; `Progress` makes use of RAII to complete the progress

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 added a comment. In D139833#3997386 , @DavidSpickett wrote: > Is the further work in the commit message work you intended to include in > this patch? I appreciate the status update might be useful for some but > commit messages are for

[Lldb-commits] [PATCH] D140092: [NFC] Using namespace llvm in EmulateInstructionRISCV

Emmmer updated this revision to Diff 483117. Emmmer added a comment. Herald added a subscriber: lldb-commits. Updating D140092 : [NFC] Using namespace llvm in EmulateInstructionRISCV Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Emmmer added a comment. In D140032#3997459 , @DavidSpickett wrote: >> Are we going to use C++20 or something else? But I see the function >> transform() we need was introduced in C++23. > > Good point, it would be c++20. If you want to look into the

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. > Are we going to use C++20 or something else? But I see the function > transform() we need was introduced in C++23. Good point, it would be c++20. If you want to look into the status of the switchover feel free, but you can leave them as llvm::Optional for now.

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Emmmer added a comment. In D140032#3997384 , @DavidSpickett wrote: > Before I look closely, I see you added namespace llvm. This is fine, neatens > things up but can we get that in its own change? Sure, I will organize these into a separate patch. >

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

SixWeining accepted this revision. SixWeining added a comment. LGTM from the LoongArch side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139833/new/ https://reviews.llvm.org/D139833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:287 + uint32_t rj = Bits32(inst, 9, 5); + uint64_t rj_val; + uint64_t pc = ReadPC(); I would declare this where it is assigned. The

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This is all very repetitive, but that's to be expected. Whatever you can do to reduce boilerplate in future patches would be great. For example, can 32 and 64 bit variants of

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett added a comment. Is the further work in the commit message work you intended to include in this patch? I appreciate the status update might be useful for some but commit messages are for describing what's in a commit (among other things). If you think people might wrongly assume

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. Further work: RV32DC and RV64DC instructions support. Also I don't think we need this in the commit message. Unless someone might assume it was included. In which case I'd be explicit "this does not include ". Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. Before I look closely, I see you added namespace llvm. This is fine, neatens things up but can we get that in its own change? Also, llvm is moving to std::optional, can you do that and make it its own patch too? Of course add me to review both, should be pretty

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett added a comment. If you don't have LTO, does this mean that only that one test won't run, or will the whole suite not run? Perhaps I misunderstand the purpose of add_lldb_test_dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION