[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

JDevlieghere added a comment. In D139945#3999351 , @labath wrote: > For a "plugin", the scripted process is sure getting a lot of special > handling in generic code. (I know this isn't being introduced here, but I > wasn't involved in the previous

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

JDevlieghere added a comment. I'm happy with the launching/attaching discussion resolved. Similar to the deduplication I think it makes more sense to tackle that first instead of landing this "as is" and then fixing it after the fact. Comment at:

[Lldb-commits] [PATCH] D140385: [lldb] Add lldb-server targets to build docs

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140385/new/ https://reviews.llvm.org/D140385

[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

kazu added a comment. Thank you for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484382. ayermolo added a comment. missed couple of Status uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4004866 , @labath wrote: > You, if I understand correctly, see the ID of a symbol file as a special case > of an all-encompassing user id -- essentially a user_id (or a DIERef) > pointing to the first byte of the

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9cbe6937b1f: [dsymutil] Track uncloned references in the DIEInfo. (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D138176?vs=483018=484357#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4008605 , @lenary wrote: > I'm working on a follow-up, which should make the split a bit clearer, but > I'm also not a modulemap expert and the `-DLLVM_ENABLE_MODULES=On` > configuration is broken on my linux dev box.

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. Sorry for the delay here; this patch LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. I'm working on a follow-up, which should make the split a bit clearer, but I'm also not a modulemap expert and the `-DLLVM_ENABLE_MODULES=On` configuration is broken on my linux dev box. I'll post it for review if those two patches have at least made the build greener.

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

steven_wu added a comment. Also needed a follow up fix to completely fix module `9cd6fbee7ed8` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___ lldb-commits

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd483d488ca5d: [lldb] Prevent false positives with simple template names in SymbolFileDWARF… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d483d48 - [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

Author: Arthur Eubanks Date: 2022-12-20T10:10:07-08:00 New Revision: d483d488ca5d04534105b67d83f3c16d142e7a05 URL: https://github.com/llvm/llvm-project/commit/d483d488ca5d04534105b67d83f3c16d142e7a05 DIFF:

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. Sorry, I pasted in the wrong hash: 6bdf378dcd349d97152846bb687c1d1de511d138 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2521 +if (name_bracket_index == llvm::StringRef::npos && +matching_type->IsTemplateType()) + return true; Michael137 wrote: > You could consider

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. I think I fixed it in a685bb8e333e , but please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4008443 , @aprantl wrote: > Can you please update `llvm/include/llvm/module.modulemap` for this change or > revert the patch? This is breaking all bots that build with > `-DLLVM_ENABLE_MODULES=On`. > > For example: >

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + labath wrote: > mib wrote: > > labath wrote: > > > mib

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. Can you please update `llvm/include/llvm/module.modulemap` for this change or revert the patch? This is breaking all bots that build with `-DLLVM_ENABLE_MODULES=On`. For example:

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4007920 , @thakis wrote: > Thanks for the heads-up. I updated the GN build in > 4ac51dd53d93b8dd18c58093766483c657fe3a08 > and >

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2521 +if (name_bracket_index == llvm::StringRef::npos && +matching_type->IsTemplateType()) + return true; You could consider using

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" barannikov88 wrote: > The prefix must

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" The prefix must remain LLVM_* In other

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

thakis added a comment. Thanks for the heads-up. I updated the GN build in 4ac51dd53d93b8dd18c58093766483c657fe3a08 and 2aa998d22fe09191cd6c1b697e373266c1131502

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484261. ayermolo added a comment. removed include that snuck in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484259. ayermolo added a comment. Herald added subscribers: MaskRay, emaste. pulled a trigger and changed all the call sites. I think less confusing then having two sets of APIs. One with printf symantics another with formatv. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

DavidSpickett added a comment. Please split this patch into 2: - the cleanup of the existing branch instructions - the addition of the new ones The changes look good but let's keep each commit to doing 1 thing. You are missing tests though, and this is my mistake for not asking for them in

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. And a fixup for the compiler-rt symbolizer: https://reviews.llvm.org/rGecaab107e4d0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary marked an inline comment as done. lenary added a comment. Another fixup for the llvm examples was required, landed in https://reviews.llvm.org/rG16c4c4e04c14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/

[Lldb-commits] [lldb] bb7940e - [llvm] Make llvm::Any similar to std::any

Author: Sebastian Neubauer Date: 2022-12-20T13:28:30+01:00 New Revision: bb7940e25f6ca201ca57943544016390f1d2e504 URL: https://github.com/llvm/llvm-project/commit/bb7940e25f6ca201ca57943544016390f1d2e504 DIFF:

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb7940e25f6c: [llvm] Make llvm::Any similar to std::any (authored by sebastian-ne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary marked an inline comment as done. lenary added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:11 +/// This header is deprecated in favour of +/// `llvm/TargetParser/AArch64TargetParser.h`. /// barannikov88 wrote: > Invalid comment. Fixed in

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

lh03061238 created this revision. lh03061238 added reviewers: SixWeining, wangleiat, xen0n, xry111, MaskRay, DavidSpickett, seehearfeel. Herald added a subscriber: StephenFan. Herald added a project: All. lh03061238 requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

barannikov88 added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:11 +/// This header is deprecated in favour of +/// `llvm/TargetParser/AArch64TargetParser.h`. /// Invalid comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140385: [lldb] Add lldb-server targets to build docs

DavidSpickett added a reviewer: JDevlieghere. DavidSpickett added a comment. Current page: https://lldb.llvm.org/resources/build.html Github issue: https://github.com/llvm/llvm-project/issues/59575 This works for Linux but I don't know what happens on Mac OS. Would the equivalent be `ninja lldb

[Lldb-commits] [PATCH] D140385: [lldb] Add lldb-server targets to build docs

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current doc has people just do "ninja lldb" which is not incorrect, it does build lldb. However it does not

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. This caused an issue in the libc benchmarks, fix here: 2a261a7b5764 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. That's how it currently looks like: F25758029: image.png I plan on adding support for disassembly in multi-threaded applications (now I only track the stack frame for the main thread in `g_curr_frame`). Repository: rG LLVM

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

DavidSpickett added a reviewer: jingham. DavidSpickett added a subscriber: jingham. DavidSpickett added a comment. The intent makes sense. We should stop and report user breakpoints triggered while trying to execute some internal stepping plan, even if they overlap what lldb was planning to do