[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 added a comment. In D140368#4007234 , @DavidSpickett wrote: > The intent makes sense. We should stop and report user breakpoints triggered > while trying to execute some internal stepping plan, even if they overlap > what lldb was planning to

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 updated this revision to Diff 484745. kpdev42 added a comment. Renamed the test, added more tests for unconditional (enabled/disabled) breakpoints and breakpoints with callbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/

[Lldb-commits] [PATCH] D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

rupprecht added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138344/new/ https://reviews.llvm.org/D138344 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4010987 , @dblaikie wrote: > This has introduced a circular dependency due to the forwarding header > (forwarding header depends on new lib, new lib depends on support, where the > forwarding header is). Generally

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

labath added a comment. This is looking much better -- and focused. I still have comments though. :) Comment at: lldb/include/lldb/Core/Module.h:833 - void LogMessageVerboseBacktrace(Log *log, const char *format, ...) - __attribute__((format(printf, 3, 4))); + void

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

labath added a comment. In D139945#4009427 , @JDevlieghere wrote: > In D139945#3999351 , @labath wrote: > >> For a "plugin", the scripted process is sure getting a lot of special >> handling in generic code. (I

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

labath added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + mib wrote: > labath wrote: > > mib wrote: > > > labath

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

fpetrogalli added a comment. In D137838#4010987 , @dblaikie wrote: > This has introduced a circular dependency due to the forwarding header > (forwarding header depends on new lib, new lib depends on support, where the > forwarding header is).

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

dblaikie added a comment. This has introduced a circular dependency due to the forwarding header (forwarding header depends on new lib, new lib depends on support, where the forwarding header is). Generally this wouldn't be acceptable (& I'd suggest the patch be reverted on that basis) though

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. @JDevlieghere let me know if there's anything I can do to make the review easier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 ___

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 484579. eloparco added a comment. Avoid tracking stack frame boundaries. It is unnecessary and makes the disassembler functionality not work in multi-threaded programs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

mib updated this revision to Diff 484527. mib marked an inline comment as done. mib added a comment. Use `std::forward` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 Files: