[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

2022-12-29 Thread Lu Weining via Phabricator via lldb-commits
SixWeining added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:42 "bnez rj, offs21"}, + {0xfc00, 0x4800, ::EmulateBCXXZ, + "bceqz/bcnez cj, offs21"}, It should be 0xfc000300.

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

2022-12-29 Thread Hui Li via Phabricator via lldb-commits
lh03061238 created this revision. lh03061238 added reviewers: SixWeining, wangleiat, xen0n, xry111, MaskRay, seehearfeel, DavidSpickett. Herald added a subscriber: StephenFan. Herald added a project: All. lh03061238 requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

2022-12-29 Thread Lu Weining via Phabricator via lldb-commits
SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140615/new/ https://reviews.llvm.org/D140615

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

2022-12-29 Thread Hui Li via Phabricator via lldb-commits
lh03061238 added inline comments. Comment at: lldb/unittests/Instruction/LoongArch/TestLoongArchEmulator.cpp:1-2 +//===-- TestLoongArchEmulator.cpp +//-===// +// SixWeining wrote: > Merge these lines into one. It has

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

2022-12-29 Thread Hui Li via Phabricator via lldb-commits
lh03061238 updated this revision to Diff 485586. lh03061238 added a comment. Modify the first two lines in TestLoongArchEmulator.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140386/new/ https://reviews.llvm.org/D140386 Files: