[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-01-04 Thread Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
bolshakov-a created this revision. bolshakov-a added reviewers: aaron.ballman, rsmith, mizvekov. Herald added subscribers: kadircet, arphaman, martong, kristof.beyls. Herald added a reviewer: shafik. Herald added a project: All. bolshakov-a requested review of this revision. Herald added projects:

[Lldb-commits] [PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

2023-01-04 Thread Sam Elliott via Phabricator via lldb-commits
lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, MaskRay. Herald added projects: clang, LLDB, LLVM. This deprecates, but does n

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

2023-01-04 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. This looks good to me if we drop the explicit `+` for right alignment: it's the default and other places in LLDB (and LLVM, at least as far as I'm aware) don't include this unless there's ambiguity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

2023-01-04 Thread Sam Elliott via Phabricator via lldb-commits
lenary added reviewers: tmatheson, pratlucas, MaskRay. lenary added a comment. Herald added subscribers: StephenFan, JDevlieghere. Adding some relevant reviewers. My plan is to land the other patches like this directly onto `main`, as they are NFC and a cleanup. I hope this is uncontroversial, b

[Lldb-commits] [PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

2023-01-04 Thread Sam Elliott via Phabricator via lldb-commits
lenary edited the summary of this revision. lenary updated this revision to Diff 486324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/ https://reviews.llvm.org/D140999 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Target

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

2023-01-04 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda updated this revision to Diff 486385. jasonmolenda added a comment. Update the patch to use a case statement for fp/sp/lr/pc instead of conditionals; both Adrian and Jonas preferred it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140

[Lldb-commits] [lldb] da4e827 - Don't read off end of GPR register array to access fp/sp/lr/pc

2023-01-04 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2023-01-04T13:51:26-08:00 New Revision: da4e82753f3130ca2ff973ad90092ad1c035038a URL: https://github.com/llvm/llvm-project/commit/da4e82753f3130ca2ff973ad90092ad1c035038a DIFF: https://github.com/llvm/llvm-project/commit/da4e82753f3130ca2ff973ad90092ad1c035038a.diff

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

2023-01-04 Thread Jason Molenda via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGda4e82753f31: Don't read off end of GPR register array to access fp/sp/lr/pc (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140067

[Lldb-commits] [lldb] 0dc7ecb - Fix typeo in LoadBinariesViaExhaustiveSearch when looking for kernel

2023-01-04 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2023-01-04T16:11:51-08:00 New Revision: 0dc7ecb1a70ec9f6eb41ebb4d1edf5d2acdfb4ce URL: https://github.com/llvm/llvm-project/commit/0dc7ecb1a70ec9f6eb41ebb4d1edf5d2acdfb4ce DIFF: https://github.com/llvm/llvm-project/commit/0dc7ecb1a70ec9f6eb41ebb4d1edf5d2acdfb4ce.diff

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

2023-01-04 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, mib. Herald added a project: All. JDevlieghere requested review of this revision. CMake supports building Framework bundles for Apple platforms. We rely on this functionality to create LLDB.framework. From CMake's perspec

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

2023-01-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Jim Ingham really should chime in on this if possible as the thread plans and stop info are his area of expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https://reviews.llvm.org/D140368 __

[Lldb-commits] [PATCH] D140623: [LLDB] Fix for libc++ atomic allowing modification of contained value

2023-01-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sorry for delay, I was on recharge for all of December. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140623/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

2023-01-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Sorry for delay, I was on recharge for all of December. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

2023-01-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Sorry for delay, I was on recharge for all of December. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto bytes_offset = -instruction_offset

[Lldb-commits] [lldb] 4215a84 - [lldb] Remove unneeded .get() NFC

2023-01-04 Thread Fangrui Song via lldb-commits
Author: Fangrui Song Date: 2023-01-04T22:05:40-08:00 New Revision: 4215a84559bb872363eaa4ac724be8ef86c2e683 URL: https://github.com/llvm/llvm-project/commit/4215a84559bb872363eaa4ac724be8ef86c2e683 DIFF: https://github.com/llvm/llvm-project/commit/4215a84559bb872363eaa4ac724be8ef86c2e683.diff