[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Gotcha, makes sense now. Thanks for the extra info. We do need to make sure the m_symbol_file values match and return an empty TypeSP if they don't. Once that is done, this is

[Lldb-commits] [lldb] 6083410 - [lldb] Re-enable xmm/ymm/zmm tests with the system debugserver

Author: Jonas Devlieghere Date: 2023-01-19T17:07:55-08:00 New Revision: 60834105d85cba27e1e1b2b4ecf4cd658019d867 URL: https://github.com/llvm/llvm-project/commit/60834105d85cba27e1e1b2b4ecf4cd658019d867 DIFF:

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 added a comment. @clayborg we have one instance downstream where we need to keep two types around. One for the original type and one for a slightly modified one (here

[Lldb-commits] [PATCH] D141629: Run address expression argument values through ABI::FixCodeAddress to strip TBI/pointer auth bytes on AArch64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Someday I'd like to have a decorator that's a bit smarter and allows us to run these tests if the test compiler has ptrauth/PAC support and the host can run it. At least then

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint_data/TestVSCode_setDataBreakpoints.py:73 +num_a = array_find(locals, lambda x: x['name'] ==

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

clayborg added a comment. In D142052#4067177 , @augusto2112 wrote: > @clayborg the intended usage here is to create a copy of the type in the same > symbol file. I could add a sanity check that makes sure we're not creating a > copy of something that

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 added a comment. @clayborg the intended usage here is to create a copy of the type in the same symbol file. I could add a sanity check that makes sure we're not creating a copy of something that isn't in the symbol file's type list in debug mode. Would that be enough? Repository:

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

clayborg added a comment. We don't allow types to be copied into another SymbolFile. There is a strict rule in LLDB that SymbolFile objects only create types from their own data. There are many reasons we don't want this: - Type objects have a m_symbol_file which points to the SymbolFile that

[Lldb-commits] [PATCH] D141637: [lldb-vscode] Fix an issue where lldb-vscode tries to display a source file for generated code

clayborg added a comment. Change looks good. It would be nice to test this if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141637/new/ https://reviews.llvm.org/D141637 ___ lldb-commits

[Lldb-commits] [PATCH] D142141: [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. seems reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142141/new/ https://reviews.llvm.org/D142141

[Lldb-commits] [PATCH] D142067: Remove the "help" subcommand - its undocumented, undiscoverable and doesn't work....

This revision was automatically updated to reflect the committed changes. Closed by commit rG887240faf769: Remove the undocumented `help` subcommand. (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D142067?vs=490340=490622#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 887240f - Remove the undocumented `help` subcommand.

Author: Jim Ingham Date: 2023-01-19T12:03:06-08:00 New Revision: 887240faf769395511d1568b4e50aafc6fe3b696 URL: https://github.com/llvm/llvm-project/commit/887240faf769395511d1568b4e50aafc6fe3b696 DIFF: https://github.com/llvm/llvm-project/commit/887240faf769395511d1568b4e50aafc6fe3b696.diff

[Lldb-commits] [PATCH] D142067: Remove the "help" subcommand - its undocumented, undiscoverable and doesn't work....

jingham added a comment. I wouldn't be opposed to adding a --help option (with no short option) that every command would inherit. Doing it as a command option alone can't suffice for lldb, since that offers no way to list all the commands. git gets around this because you can say `git` on

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

jingham added a comment. In D141425#4044280 , @kastiglione wrote: > @jingham The brief answer is that decisions have been based on compatibility > with the behavior of `p`. > > 1. `expression` (also `p`) and `frame variable`, only support the the

[Lldb-commits] [PATCH] D141605: [lldb] Detach the child process when stepping over a fork

jingham added a comment. The part of handling the fork where we decide we're going to follow the child and so we need to switch the process PID & TID does have to happen on event receipt. The point there is that until the client pulls an event from the public event queue, it doesn't know that

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The SBModule copy constructor has fast execution, and is high firing. Fast

[Lldb-commits] [PATCH] D142067: Remove the "help" subcommand - its undocumented, undiscoverable and doesn't work....

jasonmolenda added a comment. Yeah this is a good cleanup, but fwiw maybe because using git, but I sometimes expect `break set --help` etc to work, forgetting which style lldb uses. just throwing it out there as something I get tripped up by once in a while, not really related to this change,

[Lldb-commits] [PATCH] D142141: [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04

kastiglione created this revision. kastiglione added a reviewer: Michael137. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Disable this test on Ubuntu 18.04, where it fails for yet to be

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

clayborg added a comment. Update: There are some new failures after someone recently added new tests that involve simple template types. I need to fix my new lookup routine to do the right thing in light of these new tests. The main issue is currently if you have a "foo", the accelerator

[Lldb-commits] [PATCH] D142140: [lldb] Remove legacy six module for py2->py3

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142140/new/ https://reviews.llvm.org/D142140

[Lldb-commits] [PATCH] D142140: [lldb] Remove legacy six module for py2->py3

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB only supports Python3 now, so the `six` shim for Python2 is no longer necessary. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D142067: Remove the "help" subcommand - its undocumented, undiscoverable and doesn't work....

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. +1 to everything Jim said in the commit message. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142067/new/