[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63c77bf71d80: [lldb] Make persisting result variables configurable (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 63c77bf - [lldb] Make persisting result variables configurable

Author: Dave Lee Date: 2023-02-17T17:50:43-08:00 New Revision: 63c77bf71d80b24df377fc45c80bfa1904ee849e URL: https://github.com/llvm/llvm-project/commit/63c77bf71d80b24df377fc45c80bfa1904ee849e DIFF: https://github.com/llvm/llvm-project/commit/63c77bf71d80b24df377fc45c80bfa1904ee849e.diff

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

This revision was automatically updated to reflect the committed changes. Closed by commit rG920b46e108b2: [lldb] Add expression command options in dwim-print (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/

[Lldb-commits] [lldb] 920b46e - [lldb] Add expression command options in dwim-print

Author: Dave Lee Date: 2023-02-17T17:50:08-08:00 New Revision: 920b46e108b23454e6827ed0fa5e0a69fcb4a6e6 URL: https://github.com/llvm/llvm-project/commit/920b46e108b23454e6827ed0fa5e0a69fcb4a6e6 DIFF: https://github.com/llvm/llvm-project/commit/920b46e108b23454e6827ed0fa5e0a69fcb4a6e6.diff

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498536. kastiglione added a comment. Fix composition of --persistent-result and -O/-v Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files:

[Lldb-commits] [PATCH] D144311: [debugserver] Add one additional sleep before attaching after waiting

bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's possible for debugserver to attach to a process during the handoff

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib added inline comments. Comment at: lldb/source/API/SBAttachInfo.cpp:273-278 + ScriptedMetadataSP metadata_sp = m_opaque_sp->GetScriptedMetadata(); - m_opaque_sp->SetScriptedProcessClassName(class_name); + if (!metadata_sp) +metadata_sp = std::make_shared(class_name,

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

bulbazord added a comment. I'm not sure how much this matters but the fact that `ScriptedMetadata::IsValid` (and the bool operator overload) relies on the class name being empty is a little strange to me. I feel like you could get yourself into a strange situation where you set the

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f88c07cf820: [lldb] StructuredData should not truncate uint64_t values (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 2f88c07 - [lldb] StructuredData should not truncate uint64_t values

Author: Alex Langford Date: 2023-02-17T12:39:49-08:00 New Revision: 2f88c07cf820cff829dec5906d298fc7147af8dd URL: https://github.com/llvm/llvm-project/commit/2f88c07cf820cff829dec5906d298fc7147af8dd DIFF: https://github.com/llvm/llvm-project/commit/2f88c07cf820cff829dec5906d298fc7147af8dd.diff

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

bulbazord updated this revision to Diff 498479. bulbazord added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144238/new/ https://reviews.llvm.org/D144238 Files: lldb/source/Utility/StructuredData.cpp

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/Options.td:389 "not supported by the interpreter (defaults to true).">; + def persistent_result : Option<"persistent-result",

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498462. kastiglione added a comment. Improve handling of `po` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files:

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119 } + +llvm::ArrayRef jingham wrote: > jingham wrote: > > There's a version of Append that lets you exclude and remap option sets. > > This seems like a

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:389 "not supported by the interpreter (defaults to true).">; + def persistent_result : Option<"persistent-result", "\\x01">, Groups<[1,2]>, +Arg<"Boolean">, aprantl wrote: >

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119 } + +llvm::ArrayRef jingham wrote: > There's a version of Append that lets you

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

aprantl added inline comments. Comment at: lldb/source/Commands/Options.td:389 "not supported by the interpreter (defaults to true).">; + def persistent_result : Option<"persistent-result", "\\x01">, Groups<[1,2]>, +Arg<"Boolean">, Is that the approved

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4133717 , @mib wrote: > Hi @ayermolo! > > This patch is causing some failure on the macOS lldb bot: > https://green.lab.llvm.org/green/job/lldb-cmake/51257/ > > Could you take a look ? If you don't have the time, we

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:225 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); kastiglione wrote: > Michael137 wrote: > > Michael137 wrote: > > > Michael137 wrote:

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498394. kastiglione added a comment. Remove short option -C, leaving only --persistent-result Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files:

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498390. kastiglione added a comment. fix Makefile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files: lldb/source/Commands/CommandObjectDWIMPrint.cpp

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectExpression.cpp:149 + case 'C': { +// 'C' for "caching", since both 'P' and 'p' for persist are taken. Both 'R' aprantl wrote: > Do we expect people to actually use this flag

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498387. kastiglione added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files: lldb/source/Commands/CommandObjectDWIMPrint.cpp

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSSet.cpp:673-675 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); by the way, these changes are missing `{}` around the `if` body. Repository: rG

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:225 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); Michael137 wrote: > Michael137 wrote: > > Michael137 wrote: > > > this won't