[Lldb-commits] [lldb] e85e5ab - [LLDB] XFAIL TestRunLocker.py for windows

2023-03-01 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2023-03-02T11:51:35+04:00 New Revision: e85e5abdceff6983a7ca1b647a97d0e0aaf6bf38 URL: https://github.com/llvm/llvm-project/commit/e85e5abdceff6983a7ca1b647a97d0e0aaf6bf38 DIFF: https://github.com/llvm/llvm-project/commit/e85e5abdceff6983a7ca1b647a97d0e0aaf6bf

[Lldb-commits] [lldb] 588da01 - Revert "[LLDB] XFAIL TestRunLocker.py on Windows"

2023-03-01 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2023-03-02T11:22:25+04:00 New Revision: 588da01621a1f8efd139e677526b64c1e5ecf303 URL: https://github.com/llvm/llvm-project/commit/588da01621a1f8efd139e677526b64c1e5ecf303 DIFF: https://github.com/llvm/llvm-project/commit/588da01621a1f8efd139e677526b64c1e5ecf3

[Lldb-commits] [lldb] 9d28e00 - [LLDB] XFAIL TestRunLocker.py on Windows

2023-03-01 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2023-03-02T11:05:23+04:00 New Revision: 9d28e00e741cb19684111656803434aceef4c2a0 URL: https://github.com/llvm/llvm-project/commit/9d28e00e741cb19684111656803434aceef4c2a0 DIFF: https://github.com/llvm/llvm-project/commit/9d28e00e741cb19684111656803434aceef4c2

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

2023-03-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. jingham added reviewers: labath, JDevlieghere, clayborg, jasonmolenda, bulbazord. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I put up an RFC for debugger interruption

[Lldb-commits] [PATCH] D145124: [lldb] Add variable completion to dwim-print

2023-03-01 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Enable completion of variables for `dwim-print` command. Repository: rG L

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

2023-03-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham added inline comments. Comment at: lldb/test/API/python_api/watchpoint/TestSetWatchpoint.py:66 +if variable_watchpoint: +# FIXME: There should probably be an API to create a variable watchpoint +self.runCmd('watchpoint set variable -w read

[Lldb-commits] [PATCH] D145115: [LLDB][NativePDB] Check string table in PDB files.

2023-03-01 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a subscriber: arphaman. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Usually PDB files have a string table (aka: Named

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

2023-03-01 Thread Dan Liew via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG55a363fea18b: [LLDB] Expose several methods in SBWatchpoint (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://revie

[Lldb-commits] [lldb] 55a363f - [LLDB] Expose several methods in SBWatchpoint

2023-03-01 Thread Dan Liew via lldb-commits
Author: Dan Liew Date: 2023-03-01T11:15:05-08:00 New Revision: 55a363fea18b20a81e8ebb9518997a3bda602f32 URL: https://github.com/llvm/llvm-project/commit/55a363fea18b20a81e8ebb9518997a3bda602f32 DIFF: https://github.com/llvm/llvm-project/commit/55a363fea18b20a81e8ebb9518997a3bda602f32.diff LOG:

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

2023-03-01 Thread Dan Liew via Phabricator via lldb-commits
delcypher marked 2 inline comments as done. delcypher added a comment. Thanks for the review and approval. I've the fixed the nits so I'm going to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937 __

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

2023-03-01 Thread Dan Liew via Phabricator via lldb-commits
delcypher updated this revision to Diff 501582. delcypher edited the summary of this revision. delcypher added a comment. - Fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937 Files: lldb/bindings/

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

2023-03-01 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda updated this revision to Diff 501574. jasonmolenda added a comment. Clean up the test case - the C file and python file - to address David's feedback and test it more thoroughly. Fix `ValueObjectPrinter::PrintValueAndSummaryIfNeeded()` to only add the `actual=hex` if this is a poi

[Lldb-commits] [PATCH] D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop

2023-03-01 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. Looks like the new test is failing on the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29680. The buildbot was already red because of `TestCommandScript.py`, so you might have missed this. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] fad6010 - [lldb/test] Update error message in debug-types-signature-loop.s

2023-03-01 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2023-03-01T13:51:58+01:00 New Revision: fad60105ace546deb219adb14e0eef01a2b6c9d6 URL: https://github.com/llvm/llvm-project/commit/fad60105ace546deb219adb14e0eef01a2b6c9d6 DIFF: https://github.com/llvm/llvm-project/commit/fad60105ace546deb219adb14e0eef01a2b6c9d6.diff

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

2023-03-01 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:235 +std::error_code(errno, std::generic_category()), +"The current va