[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

2023-03-25 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. In D146668#4221223 , @thakis wrote: > Hello, > https://github.com/llvm/llvm-project/commit/5fb4147f74ad90095f08f243e5f19877d09d11b9 > broke the windows build (http://45.33.8.238/win/76494/step_4.txt) because > it's now includ

[Lldb-commits] [PATCH] D146779: Fix handling of backticks in CommandObjectParsed commands

2023-03-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere closed this revision. JDevlieghere added a comment. https://reviews.llvm.org/rG75ca15fcbb2e1b3671e41f971a000c6d59f5e5ae Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146779/new/ https://reviews.llvm.org/D146779 ___

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-03-25 Thread Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
bolshakov-a updated this revision to Diff 508311. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/docs/Releas

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-03-25 Thread Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
bolshakov-a updated this revision to Diff 508305. bolshakov-a added a comment. Add type to USR so as not to get confused with template struct S {}; struct { int n; } s; template<> struct S<(void*)&s.n> {}; template<> struct S<&s.n> {}; Add test on structural type NTTP USR. Jus

[Lldb-commits] [lldb] 9c6b690 - [lldb] Move #include out of namespace lldb. NFC.

2023-03-25 Thread Benjamin Kramer via lldb-commits
Author: Benjamin Kramer Date: 2023-03-25T13:36:49+01:00 New Revision: 9c6b69000d9307a36745004ee9300f70a5415160 URL: https://github.com/llvm/llvm-project/commit/9c6b69000d9307a36745004ee9300f70a5415160 DIFF: https://github.com/llvm/llvm-project/commit/9c6b69000d9307a36745004ee9300f70a5415160.dif

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

2023-03-25 Thread Nico Weber via Phabricator via lldb-commits
thakis added a comment. Hello, https://github.com/llvm/llvm-project/commit/5fb4147f74ad90095f08f243e5f19877d09d11b9 broke the windows build (http://45.33.8.238/win/76494/step_4.txt) because it's now including system headers within namespace lldb. Please take a look and revert for now if it tak