[Lldb-commits] [PATCH] D146919: Fix Issue #61706

2023-03-26 Thread LU Hongyi via Phabricator via lldb-commits
jwnhy added a comment. It seems this is more complicated than I originally thought. My fix is also flawed when it comes the following program. Let `overhang_bytes = 0` will overflow the otherside by 1 bit and thus output a wrong value. But changing everything to signed does not resolve this issu

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

2023-03-26 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + probinson wrote: > This doesn't become `Foo` ? The name stays as `Foo>` but the type of the template parameter becomes `BarInt`. So the dwarf would lo

[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

2023-03-26 Thread LU Hongyi via Phabricator via lldb-commits
jwnhy added a comment. Hi, guys, I have met this issue #61706 . The case I provided shows that even without DWARF v2, this problem still exists. I wonder if such modification is really needed or not. Also, I am not sure changing all these to `

[Lldb-commits] [PATCH] D146919: Fix Issue #61706

2023-03-26 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added a comment. You might be interested in taking over/pinging the following patch instead, which makes the offset signed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146919/new/ https://reviews.llvm.org/D146919 _

[Lldb-commits] [PATCH] D146919: Fix Issue #61706

2023-03-26 Thread LU Hongyi via Phabricator via lldb-commits
jwnhy created this revision. jwnhy added reviewers: clayborg, jingham. Herald added a project: All. jwnhy requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As described in #61706 , the `Valu