[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

brooks created this revision. brooks added reviewers: DavidSpickett, emaste, arichardson, dim. Herald added a subscriber: krytarowski. Herald added a project: All. brooks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Commit 392d9eb03af5a1

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jingham, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support fo

[Lldb-commits] [lldb] b24e290 - [lldb] Fix macos build after e64cc756819d (2/2)

Author: Jonas Devlieghere Date: 2023-03-30T14:50:45-07:00 New Revision: b24e2900fa743e0abab7f4fa9747e5cbbfc2567a URL: https://github.com/llvm/llvm-project/commit/b24e2900fa743e0abab7f4fa9747e5cbbfc2567a DIFF: https://github.com/llvm/llvm-project/commit/b24e2900fa743e0abab7f4fa9747e5cbbfc2567a.d

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

fdeazeve added a comment. Jonas fixed the build failures in c8522cadf7331bedd548ad5e2c6ef100c9166259 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146977/new/ https://reviews.ll

[Lldb-commits] [lldb] f03f811 - [lldb] Only run TestUniversal64 on macOS 11 and later

Author: Jonas Devlieghere Date: 2023-03-30T14:12:32-07:00 New Revision: f03f8111d2af41561c2be918f56ac348bf228dc7 URL: https://github.com/llvm/llvm-project/commit/f03f8111d2af41561c2be918f56ac348bf228dc7 DIFF: https://github.com/llvm/llvm-project/commit/f03f8111d2af41561c2be918f56ac348bf228dc7.d

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

This revision was automatically updated to reflect the committed changes. Closed by commit rG7edff3c1b298: [lldb] Use one Progress event per root module build (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147248/new/ https

[Lldb-commits] [lldb] 7edff3c - [lldb] Use one Progress event per root module build

Author: Dave Lee Date: 2023-03-30T13:59:02-07:00 New Revision: 7edff3c1b298f696c632625fa863acbc7d68d446 URL: https://github.com/llvm/llvm-project/commit/7edff3c1b298f696c632625fa863acbc7d68d446 DIFF: https://github.com/llvm/llvm-project/commit/7edff3c1b298f696c632625fa863acbc7d68d446.diff LOG:

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147248/new/ https://reviews.llvm.org/D147248 ___

[Lldb-commits] [lldb] c8522ca - [lldb] Fix macos build after e64cc756819d

Author: Jonas Devlieghere Date: 2023-03-30T13:54:24-07:00 New Revision: c8522cadf7331bedd548ad5e2c6ef100c9166259 URL: https://github.com/llvm/llvm-project/commit/c8522cadf7331bedd548ad5e2c6ef100c9166259 DIFF: https://github.com/llvm/llvm-project/commit/c8522cadf7331bedd548ad5e2c6ef100c9166259.d

[Lldb-commits] [PATCH] D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3252d1a2c56: [lldb][NFC] Move various constructor definitions from .h to .cpp (authored by rriddle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147252/ne

[Lldb-commits] [lldb] a3252d1 - [lldb][NFC] Move various constructor definitions from .h to .cpp

Author: River Riddle Date: 2023-03-30T13:25:30-07:00 New Revision: a3252d1a2c568792974a4bc7413b0c61a43053e9 URL: https://github.com/llvm/llvm-project/commit/a3252d1a2c568792974a4bc7413b0c61a43053e9 DIFF: https://github.com/llvm/llvm-project/commit/a3252d1a2c568792974a4bc7413b0c61a43053e9.diff

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( int3 wrote: > Any reason why this doesn't instead store the module n

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione updated this revision to Diff 509790. kastiglione added a comment. Use std::string argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147248/new/ https://reviews.llvm.org/D147248 Files: lldb/source/Plugins/ExpressionParser/Clang/

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:227-234 void StoringDiagnosticConsumer::SetCurrentModuleProgress( -llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the ex

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:228 void StoringDiagnosticConsumer::SetCurrentModuleProgress( -llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the existin

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:228 void StoringDiagnosticConsumer::SetCurrentModuleProgress( -llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the existi

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03d98b71d03: [lldb] Replace sprintf with snprintf (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147246/new/ https://review

[Lldb-commits] [lldb] d03d98b - [lldb] Replace sprintf with snprintf (NFC)

Author: Dave Lee Date: 2023-03-30T12:29:05-07:00 New Revision: d03d98b71d03eaf2a84e62e461b4fc87940866f1 URL: https://github.com/llvm/llvm-project/commit/d03d98b71d03eaf2a84e62e461b4fc87940866f1 DIFF: https://github.com/llvm/llvm-project/commit/d03d98b71d03eaf2a84e62e461b4fc87940866f1.diff LOG:

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:228 void StoringDiagnosticConsumer::SetCurrentModuleProgress( -llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the existin

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147246/new/ https://reviews.llvm.org/D147246

[Lldb-commits] [PATCH] D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147252/new/ https://reviews.llvm.org/D147252 _

[Lldb-commits] [PATCH] D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp

rriddle created this revision. Herald added a subscriber: bollu. Herald added a project: All. rriddle requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I ran into issues with linking downstream language plugin to liblldb in debug builds, hitt

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:228 void StoringDiagnosticConsumer::SetCurrentModuleProgress( -llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the existi

[Lldb-commits] [PATCH] D147249: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG80b476a902a8: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147249/new

[Lldb-commits] [lldb] 80b476a - [lldb] Replace deprecated CFPropertyListWriteToStream (NFC)

Author: Dave Lee Date: 2023-03-30T11:21:09-07:00 New Revision: 80b476a902a8e2ab662b2e2a38e2afc55ce85c37 URL: https://github.com/llvm/llvm-project/commit/80b476a902a8e2ab662b2e2a38e2afc55ce85c37 DIFF: https://github.com/llvm/llvm-project/commit/80b476a902a8e2ab662b2e2a38e2afc55ce85c37.diff LOG:

[Lldb-commits] [PATCH] D147249: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147249/new/ https://reviews.llvm.org/D147249 ___

[Lldb-commits] [PATCH] D147249: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replace `CFPropertyListWriteToStream` with its recommended replacement,

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Following the work done by @jdevlieghere in D143690

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

kastiglione added a comment. That may be better, I don't really know. I would prefer to merge this as is (and leave a printf->formatv migration for another time). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147246/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

JDevlieghere added a comment. This looks fine, but I wonder if using `llvm::formatv` wouldn't make this a whole lot easier? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147246/new/ https://reviews.llvm.org/D147246 ___

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On macOS, `sprintf` is deprecated, using `snprintf` is recommended inste

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1482 +if (prev_base) { + clang::CXXRecordDecl *prev_base_decl = + prev_base->getType()->getAsCXXRecordDecl(); Should we add a comment desc

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

thakis added a comment. Looks like this breaks building on Mac: http://45.33.8.238/macm1/57676/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146977/new/ https://reviews.

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

fdeazeve added a comment. @labath I believe this broke the lldb bots, because the declaration of some virtual functions had the const qualifier removed, but not the definition: /Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/lldb/tools/lldb-server/lldb-gdbserver.cpp:79:36: erro

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64cc756819d: [lldb-server/linux] Use waitpid(-1) to collect inferior events (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146977/new/

[Lldb-commits] [lldb] e64cc75 - [lldb-server/linux] Use waitpid(-1) to collect inferior events

Author: Pavel Labath Date: 2023-03-30T12:48:36+02:00 New Revision: e64cc756819d567f453467bf7cc16599ad296fdd URL: https://github.com/llvm/llvm-project/commit/e64cc756819d567f453467bf7cc16599ad296fdd DIFF: https://github.com/llvm/llvm-project/commit/e64cc756819d567f453467bf7cc16599ad296fdd.diff

[Lldb-commits] [lldb] 42ae055 - [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Author: Mariya Podchishchaeva Date: 2023-03-30T06:44:23-04:00 New Revision: 42ae055b4c9282050636dd11198cad500424adf2 URL: https://github.com/llvm/llvm-project/commit/42ae055b4c9282050636dd11198cad500424adf2 DIFF: https://github.com/llvm/llvm-project/commit/42ae055b4c9282050636dd11198cad500424ad

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42ae055b4c92: [NFC] Fix potential for use-after-free in DumpModuleInfoAction (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon added a comment. The test fail is unrelated, seem to be broken by https://reviews.llvm.org/D146811 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Fznamznon updated this revision to Diff 509580. Fznamznon added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412 Files: clang/include/clang/Frontend/FrontendActions.h clang/lib/Front

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c