[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

jwnhy updated this revision to Diff 510285. jwnhy added a comment. Update the patch to include a small regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 Files: lldb/source/Expression/DWAR

[Lldb-commits] [PATCH] D147385: [lldb] Add fixits for "frame variable"

kastiglione updated this revision to Diff 510280. kastiglione added a comment. Change --apply-fixits take an argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147385/new/ https://reviews.llvm.org/D147385 Files: lldb/include/lldb/Interpreter

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 abandoned this revision. augusto2112 added a comment. Abandoning in favor of https://reviews.llvm.org/D147292/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146679/new/ https://reviews.llvm.org/D146679

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 added a comment. In D147292#4238820 , @JDevlieghere wrote: > There seems to be overlap in the code added in this patch and D146679 > . Does one supersede the other or is there > a dependency? If it's the la

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

JDevlieghere added a comment. There seems to be overlap in the code added in this patch and D146679 . Does one supersede the other or is there a dependency? If it's the latter you should extract that into a separate patch and make it a parent revision of this a

[Lldb-commits] [PATCH] D147385: [lldb] Add fixits for "frame variable"

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, JDevlieghere, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `frame variable` command can handle mi

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

JDevlieghere added a comment. The change looks good: it matches what the DWARFv5 standard says: > The DW_OP_div operation pops the top two stack values, divides the former > second entry by the former top of the stack using signed division, and pushes > the result. Can you please add a regress

[Lldb-commits] [PATCH] D147362: [lldb] Add Clang module import logging

kastiglione updated this revision to Diff 510234. kastiglione added a comment. Add -Rmodule-import flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147362/new/ https://reviews.llvm.org/D147362 Files: lldb/source/Plugins/ExpressionParser/Clang/

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

jwnhy created this revision. jwnhy added reviewers: Michael137, DavidSpickett. Herald added a project: All. jwnhy requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch resolves an issue where a value is incorrectly displayed if it is