[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe marked 2 inline comments as done. jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:146 + // arguments if we get a RestartRequest. + llvm::json::Object last_launch_or_attach_request; lldb::tid_t focus_tid; rupprecht wrote: >

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe updated this revision to Diff 512305. jgorbe added a comment. Addressed review comments. - Changed `last_launch_or_attach_request` to be a `std::optional` so we can check if it has been set. Also check for `nullopt` in request_restart. - Made `request_attach` also set

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53aa22cd9ac4: [lldb-vscode] Fix two issues with runInTerminal test. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147805/new/

[Lldb-commits] [lldb] 53aa22c - [lldb-vscode] Fix two issues with runInTerminal test.

Author: Jorge Gorbe Moya Date: 2023-04-10T18:18:05-07:00 New Revision: 53aa22cd9ac4a779208cf9907354cc6d4211e783 URL: https://github.com/llvm/llvm-project/commit/53aa22cd9ac4a779208cf9907354cc6d4211e783 DIFF:

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147805/new/ https://reviews.llvm.org/D147805 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:1120 debug_adaptor_path.str(), "--comm-file", comm_file.str(), + "--debugger-pid", std::to_string(debugger_pid), "--launch-target", GetString(launch_request_arguments,

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe updated this revision to Diff 512272. jgorbe marked 3 inline comments as done. jgorbe added a comment. Addressed review comments. - Use `lldb::pid_t` instead of unsigned long, and `LLDB_INVALID_PROCESS_ID` instead of `0` in the cases where the PID is missing. - Only pass the

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:439 /// The section offset based address for this function. + /// \param[in] generic_trampoline + /// If this function is a generic trampoline. A generic trampoline Is

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachException.cpp:162-169 + if (exc_type == EXC_BREAKPOINT && exc_data[0] == EXC_ARM_DA_DEBUG && + exc_data.size() > 1) { +stop_info->reason = eStopTypeWatchpoint; +

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

jasonmolenda added a comment. Thanks for the review. Will update the patch. Comment at: lldb/tools/debugserver/source/MacOSX/MachException.cpp:162-169 + if (exc_type == EXC_BREAKPOINT && exc_data[0] == EXC_ARM_DA_DEBUG && + exc_data.size() > 1) { +stop_info->reason

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I didn't double check the spec so I'm assuming those bitfield indexes are correct. Everything else makes sense to me. LGTM. Comment at:

[Lldb-commits] [PATCH] D147841: [lldb][NFC] Update syntax description for language cplusplus demangle

This revision was automatically updated to reflect the committed changes. Closed by commit rG469bdbd62ce2: [lldb][NFC] Update syntax description for language cplusplus demangle (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 469bdbd - [lldb][NFC] Update syntax description for language cplusplus demangle

Author: Alex Langford Date: 2023-04-10T13:59:44-07:00 New Revision: 469bdbd62ce2d1dcaef15a8209130547eb614ca6 URL: https://github.com/llvm/llvm-project/commit/469bdbd62ce2d1dcaef15a8209130547eb614ca6 DIFF: https://github.com/llvm/llvm-project/commit/469bdbd62ce2d1dcaef15a8209130547eb614ca6.diff

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

rupprecht added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:146 + // arguments if we get a RestartRequest. + llvm::json::Object last_launch_or_attach_request; lldb::tid_t focus_tid; std::optional? And then we can raise an error if the

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG19d969e340c9: [lldb] Implement SymbolFile::GetCompileOptions (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147748/new/

[Lldb-commits] [lldb] 19d969e - [lldb] Implement SymbolFile::GetCompileOptions

Author: Augusto Noronha Date: 2023-04-10T10:13:06-07:00 New Revision: 19d969e340c9e1b5a83ad5220ba0875393df71e2 URL: https://github.com/llvm/llvm-project/commit/19d969e340c9e1b5a83ad5220ba0875393df71e2 DIFF:

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a subscriber: Jake-Egan. Michael137 added a comment. Oh looks like @Jake-Egan already did Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Looks like `gmodules` isn't supported on AIX (based on other tests that use `-dwarf-ext-refs`. So I'll just disable the new tests Thanks for notifying @aaron.ballman , email notifications got lost in the inbox Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

aaron.ballman added a comment. The changes in this patch seem to have caused https://lab.llvm.org/buildbot/#/builders/clang-ppc64-aix to go down for the past 4 days -- can you revert and investigate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION