[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

JDevlieghere updated this revision to Diff 513047. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address @mib's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148172/new/ https://reviews.llvm.org/D148172 Files:

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

JDevlieghere marked 7 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:460-464 +def __init__(self, debugger, path, verbose): +super().__init__(debugger, path, verbose) +# List of DarwinImages sorted by

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere updated this revision to Diff 513045. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address @mib's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 Files:

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Core/Section.cpp:683-684 + llvm::json::ObjectMapper o(value, path); + return o && o.map("name", section.name) && o.map("type", section.type) && + o.map("size",

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

MaskRay added a comment. Herald added subscribers: bviyer, ekilmer, jplehr, thopre. @Ericson2314 @phosek What's the state of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608

[Lldb-commits] [lldb] e76cfac - AArch64 debugserver parse ESR register for watchpoints

Author: Jason Molenda Date: 2023-04-12T18:36:17-07:00 New Revision: e76cfaca70be0b45e62149e52f68d8352fa8ea2f URL: https://github.com/llvm/llvm-project/commit/e76cfaca70be0b45e62149e52f68d8352fa8ea2f DIFF: https://github.com/llvm/llvm-project/commit/e76cfaca70be0b45e62149e52f68d8352fa8ea2f.diff

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGe76cfaca70be: AArch64 debugserver parse ESR register for watchpoints (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D147820?vs=512577=513036#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

mib added inline comments. Comment at: lldb/lldb/test/API/macosx/symbols/TestObjectFileJSON.py:12 + +class TestObjectFileJSOn(TestBase): +TRIPLE = "arm64-apple-macosx13.0.0" nit Comment at: lldb/source/Core/Section.cpp:683-684 +

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

mib added inline comments. Comment at: lldb/examples/python/symbolication.py:399 +'name' : section.name, +'address': 0, +'size': section.end_addr - section.start_addr Since this

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:460-464 +def __init__(self, debugger, path, verbose): +super().__init__(debugger, path, verbose) +# List of DarwinImages sorted by their index. +self.images = list() +

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rGe38b0fa83a93: Remove AArch64 out of MIPS watchpoint-skip, doc wp description (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e38b0fa - Remove AArch64 out of MIPS watchpoint-skip, doc wp description

Author: Jason Molenda Date: 2023-04-12T17:57:21-07:00 New Revision: e38b0fa83a933a6b20064a37b8d8ebd9ec1de499 URL: https://github.com/llvm/llvm-project/commit/e38b0fa83a933a6b20064a37b8d8ebd9ec1de499 DIFF: https://github.com/llvm/llvm-project/commit/e38b0fa83a933a6b20064a37b8d8ebd9ec1de499.diff

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

JDevlieghere updated this revision to Diff 513027. JDevlieghere added a comment. Add missing `CHECK` line in `skipped_status_interactive_crashlog.test`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148172/new/ https://reviews.llvm.org/D148172 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

JDevlieghere updated this revision to Diff 513025. JDevlieghere retitled this revision from "[lldb] Use ObjectFileJSON to create modules for interactive crashlogs (WIP)" to "[lldb] Use ObjectFileJSON to create modules for interactive crashlogs". JDevlieghere edited the summary of this revision.

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

jasonmolenda added a comment. FWIW to show the motivation for this patch (which, again comes down to removing `core >= ArchSpec::eCore_arm_generic && core <= ArchSpec::eCore_arm_aarch64` when creating the StopInfo from the watchpoint description), the test case I wrote in

[Lldb-commits] [lldb] 9cbdfcd - [lldb] Fix assertion when ScriptedProcess have no pid after launch

Author: Med Ismail Bennani Date: 2023-04-12T16:04:22-07:00 New Revision: 9cbdfcdb4cf75bdb4f7061276ff89929c2b157a1 URL: https://github.com/llvm/llvm-project/commit/9cbdfcdb4cf75bdb4f7061276ff89929c2b157a1 DIFF:

[Lldb-commits] [PATCH] D148153: [lldb] Fix assertion when ScriptedProcess have no pid after launch

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cbdfcdb4cf7: [lldb] Fix assertion when ScriptedProcess have no pid after launch (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

aprantl added a comment. I understand that the opposite direction is explicit because actual work is being done. In this direction, it shouldn't affect memory management (since ConstStrings live forever) or performance, so I think this is good (and very convenient!). Does anyone else see a

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a `StringRef` conversion function to

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs (WIP)

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. se ObjectFileJSON to create modules for interactive crashlogs. Currently still WIP as I need to update the textual and non-interactive variants.

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere updated this revision to Diff 512963. JDevlieghere added a comment. Fix bug in ObjectFileJSON where we wouldn't read the rest of the file and fail parsing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 Files:

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 512945. kpdev42 added a comment. Thanks for pointing out the bug @Michael137 . It seems that clang assigns arbitrary offsets for non_unique_address so analyzing them brings me nowhere. In this patch I tried assigning no_unique_address to every empty

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere updated this revision to Diff 512946. JDevlieghere added a comment. - Improve error reporting - Fix bug CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148062/new/ https://reviews.llvm.org/D148062 Files: lldb/include/lldb/Core/Section.h

[Lldb-commits] [PATCH] D148153: [lldb] Fix assertion when ScriptedProcess have no pid after launch

mib updated this revision to Diff 512927. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148153/new/ https://reviews.llvm.org/D148153 Files: lldb/examples/python/scripted_process/crashlog_scripted_process.py lldb/examples/python/scripted_process/scripted_process.py

[Lldb-commits] [PATCH] D148153: [lldb] Fix assertion when ScriptedProcess have no pid after launch

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix an assertion that causes some test failures:

[Lldb-commits] [PATCH] D148050: [lldb] Change formatter helper function parameter list to remove ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e22b8cba786: [lldb] Change formatter helper function parameter list to remove ConstString (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0e22b8c - [lldb] Change formatter helper function parameter list to remove ConstString

Author: Alex Langford Date: 2023-04-12T11:20:24-07:00 New Revision: 0e22b8cba786a5da61b9279c4d2d10c756392a2e URL: https://github.com/llvm/llvm-project/commit/0e22b8cba786a5da61b9279c4d2d10c756392a2e DIFF: https://github.com/llvm/llvm-project/commit/0e22b8cba786a5da61b9279c4d2d10c756392a2e.diff

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 512891. kuilpd marked 6 inline comments as done. kuilpd added a comment. Added comments, changed memory strings formatting, added disassembler check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files:

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

alexfh added a comment. In D148099#4260897 , @DavidSpickett wrote: > Looks good to me. Thanks for the prompt and helpful review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148099/new/

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca7a20df1082: [lldb] Reduce chances of spurious failures in some build setups (authored by alexfh). Changed prior to commit:

[Lldb-commits] [lldb] ca7a20d - [lldb] Reduce chances of spurious failures in some build setups

Author: Alexander Kornienko Date: 2023-04-12T13:05:39+02:00 New Revision: ca7a20df108290ed9cd0ceb3137b253c8256a861 URL: https://github.com/llvm/llvm-project/commit/ca7a20df108290ed9cd0ceb3137b253c8256a861 DIFF:

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148099/new/

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

alexfh updated this revision to Diff 512748. alexfh added a comment. Use full expressions in the CHECK-NOT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148099/new/ https://reviews.llvm.org/D148099 Files:

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

DavidSpickett added a comment. Could you look for the full output line instead? (lldb) expression 1+1 (int) $0 = 2 Even if `$0` changes maybe `= ` can be checked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148099/new/

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

alexfh created this revision. alexfh added reviewers: JDevlieghere, rupprecht, brooksmoses. Herald added a project: All. alexfh requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The test may fail when running from a directory that contains

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 512710. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 Files: lldb/include/lldb/Core/DumpRegisterValue.h

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 512702. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/new/ https://reviews.llvm.org/D145574 Files: lldb/include/lldb/Target/DynamicRegisterInfo.h

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 512692. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.llvm.org/D145566 Files: lldb/include/lldb/Target/RegisterFlags.h

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/watchpoints/unaligned-watchpoint/main.c:8-11 + printf("%lld %lld\n", (*u64_p)++, (*u64_p)++); + printf("%lld %lld\n", (*u64_p)++, (*u64_p)++); + printf("%lld %lld\n", (*u64_p)++, (*u64_p)++); +

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks good to me as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147816/new/ https://reviews.llvm.org/D147816

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

DavidSpickett added a comment. Looks good to me, @omjavaid ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147816/new/ https://reviews.llvm.org/D147816 ___ lldb-commits mailing list