[Lldb-commits] [PATCH] D149040: Refactor and generalize debugserver code for setting hardware watchpoints on AArch64

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:833-835 +std::vector +DNBArchMachARM64::AlignRequestedWatchpoint(nub_addr_t user_addr, + nub_size_t user_size) {

[Lldb-commits] [PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai added a comment. Ping. Want to remind everyone that it is OK to review only a subset of files. The change spans multiple sub-projects and it is understandable nobody is comfortable reviewing //all// of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1465cd49efc: [lldb] Create a way to force remove commands (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b1465cd - [lldb] Create a way to force remove commands

Author: walter erquinigo Date: 2023-04-26T19:31:19-05:00 New Revision: b1465cd49efcbc114a75220b153f5a055ce7911f URL: https://github.com/llvm/llvm-project/commit/b1465cd49efcbc114a75220b153f5a055ce7911f DIFF: https://github.com/llvm/llvm-project/commit/b1465cd49efcbc114a75220b153f5a055ce7911f.di

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace updated this revision to Diff 517399. wallace added a comment. remove whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

rriddle accepted this revision. rriddle added a comment. LGTM with comment addressed, and white space changes dropped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 _

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

bzcheeseman accepted this revision. bzcheeseman added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:329 + /// is provided, the command is removed regardless of its removable status. + bool Remove

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some LLDB set ups need to hide certain commands for security reasons, so I'm adding a flag that allows removing non-user co

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

JDevlieghere added a comment. In D149214#4300547 , @bulbazord wrote: > In D149214#4300491 , @aprantl wrote: > >> Did you also measure the extra memory consumption? I would be surprised if >> this mattered, but we

[Lldb-commits] [PATCH] D149300: [lldb] Change return type of FileSpec::GetFileNameExtension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fcdfc378c2f: [lldb] Change return type of FileSpec::GetFileNameExtension (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] 6fcdfc3 - [lldb] Change return type of FileSpec::GetFileNameExtension

Author: Alex Langford Date: 2023-04-26T15:56:29-07:00 New Revision: 6fcdfc378c2f926ed5a175326fe799844c1c80b2 URL: https://github.com/llvm/llvm-project/commit/6fcdfc378c2f926ed5a175326fe799844c1c80b2 DIFF: https://github.com/llvm/llvm-project/commit/6fcdfc378c2f926ed5a175326fe799844c1c80b2.diff

[Lldb-commits] [lldb] 7777b30 - Fix CI failure - this depended on constants only defined on arm64 macs

Author: Jason Molenda Date: 2023-04-26T15:45:29-07:00 New Revision: b305bff3ea156311612941664ef8280a4d10 URL: https://github.com/llvm/llvm-project/commit/b305bff3ea156311612941664ef8280a4d10 DIFF: https://github.com/llvm/llvm-project/commit/b305bff3ea156311612941664ef8280a4d10.diff

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord added a comment. In D149214#4300491 , @aprantl wrote: > Did you also measure the extra memory consumption? I would be surprised if > this mattered, but we do parse a lot of DWARF DIEs... > > Generally this seems fine. I compared the memory pro

[Lldb-commits] [PATCH] D149300: [lldb] Change return type of FileSpec::GetFileNameExtension

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149300/new/ https://reviews.llvm.org/D149300 ___

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

aprantl added a comment. Did you also measure the extra memory consumption? I would be surprised if this mattered, but we do parse a lot of DWARF DIEs... Generally this seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149214/new/ https:/

[Lldb-commits] [PATCH] D149300: [lldb] Change return type of FileSpec::GetFileNameExtension

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. These do

[Lldb-commits] [lldb] 984dd16 - [lldb] `or` -> `||` in SBDefines.h

Author: Jonas Devlieghere Date: 2023-04-26T15:01:33-07:00 New Revision: 984dd163a7a03c517e419475899b80dda841e752 URL: https://github.com/llvm/llvm-project/commit/984dd163a7a03c517e419475899b80dda841e752 DIFF: https://github.com/llvm/llvm-project/commit/984dd163a7a03c517e419475899b80dda841e752.d

[Lldb-commits] [PATCH] D149284: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d6bd1c6674: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149284

[Lldb-commits] [lldb] 33d6bd1 - [lldb] Remove finding .Bundle directories in PlatformDarwinKernel

Author: Alex Langford Date: 2023-04-26T14:53:55-07:00 New Revision: 33d6bd1c667456f7f4a9d338a7996a30a3af50a3 URL: https://github.com/llvm/llvm-project/commit/33d6bd1c667456f7f4a9d338a7996a30a3af50a3 DIFF: https://github.com/llvm/llvm-project/commit/33d6bd1c667456f7f4a9d338a7996a30a3af50a3.diff

[Lldb-commits] [PATCH] D149284: [lldb] Remove finding .Bundle directories in PlatformDarwinKernel

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thank you for cleaning this one up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149284/new/ https://reviews.llvm.org/D149284

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

bulbazord updated this revision to Diff 517309. bulbazord added a comment. Remove code instead of attempting to fix things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149284/new/ https://reviews.llvm.org/D149284 Files: lldb/source/Plugins/Plat

[Lldb-commits] [PATCH] D147736: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

kastiglione added inline comments. Comment at: lldb/include/lldb/API/SBDefines.h:33 +// supports the attribute. +#if defined(SWIG) or _cplusplus < 201402L +#undef LLDB_DEPRECATED @JDevlieghere should this be `||` instead of `or`? Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D149224: Fix an off-by-one error with armv7 mach-o corefile register contexts (LC_THREADs)

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b6bac2cd81d: Fix off-by-one error in armv7 mach-o corefile register context (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149224

[Lldb-commits] [lldb] 6b6bac2 - Fix off-by-one error in armv7 mach-o corefile register context

Author: Jason Molenda Date: 2023-04-26T13:06:07-07:00 New Revision: 6b6bac2cd81df86354196304815b96c53bd93305 URL: https://github.com/llvm/llvm-project/commit/6b6bac2cd81df86354196304815b96c53bd93305 DIFF: https://github.com/llvm/llvm-project/commit/6b6bac2cd81df86354196304815b96c53bd93305.diff

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

bulbazord added a comment. In D149284#4299933 , @jasonmolenda wrote: > I added this in 2016 via 243bd763ecad466fac748b565ea52c661107684d and I have > no idea what it is for. I know of no such prefix related to kernel > debugging. Let's remove it inst

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

jasonmolenda added a comment. I added this in 2016 via 243bd763ecad466fac748b565ea52c661107684d and I have no idea what it is for. I know of no such prefix related to kernel debugging. Let's remove it instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. FileSpec::GetFileNameExtension returns a string where the first character is g

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

bulbazord added a comment. In D149111#4299871 , @bulbazord wrote: > Looks like this test does not pass on windows: > https://lab.llvm.org/buildbot/#/builders/219/builds/2389 > > I'm aware and working on this. I marked the test as unsupported on windows

[Lldb-commits] [lldb] 7590cc9 - [lldb] Skip Watchpoint/ExpressionLanguage.test on Windows

Author: Alex Langford Date: 2023-04-26T12:40:03-07:00 New Revision: 7590cc908807b1bfc63695ca016a60327c1aacdf URL: https://github.com/llvm/llvm-project/commit/7590cc908807b1bfc63695ca016a60327c1aacdf DIFF: https://github.com/llvm/llvm-project/commit/7590cc908807b1bfc63695ca016a60327c1aacdf.diff

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

bulbazord added a comment. Looks like this test does not pass on windows: https://lab.llvm.org/buildbot/#/builders/219/builds/2389 I'm aware and working on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149111/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339 + if (stack_frame_size == 0) +stack_frame_size = arch == llvm::Triple::msp430 ? 512 : 512 * 1024; bulbazord wrote: > jingham wrote: > > This doesn't seem ap

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339 + if (stack_frame_size == 0) +stack_frame_size = arch == llvm::Triple::msp430 ?

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

jingham added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339 + if (stack_frame_size == 0) +stack_frame_size = arch == llvm::Triple::msp430 ? 512 : 512 * 1024; This doesn't seem appropriate in generic code. You shoul

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

This revision was automatically updated to reflect the committed changes. Closed by commit rGc997acb97a9b: [lldb] Add support for specifying language when setting watchpoint by expression (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] c997acb - [lldb] Add support for specifying language when setting watchpoint by expression

Author: Alex Langford Date: 2023-04-26T10:24:28-07:00 New Revision: c997acb97a9b15468d991116c28bb003afecb07c URL: https://github.com/llvm/llvm-project/commit/c997acb97a9b15468d991116c28bb003afecb07c DIFF: https://github.com/llvm/llvm-project/commit/c997acb97a9b15468d991116c28bb003afecb07c.diff

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd created this revision. kuilpd added reviewers: asl, bulbazord, DavidSpickett. kuilpd added projects: LLDB, All. Herald added subscribers: Michael137, JDevlieghere, arichardson. kuilpd requested review of this revision. Herald added a subscriber: lldb-commits. Expression evaluation allocates

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. So what are next steps? Are we going for implementation of `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? @dblaikie @aprantl @Michael137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

omjavaid added a comment. In D148752#4283899 , @manojgupta wrote: > I am building on ChromeOS. We only have headers from linux kernel 4.14 > available in our build system (The actual running kernel could be a higher > version). > But given these functi